From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753795AbdBVCrf (ORCPT ); Tue, 21 Feb 2017 21:47:35 -0500 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:36354 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753068AbdBVCr1 (ORCPT ); Tue, 21 Feb 2017 21:47:27 -0500 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.249.23 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Wed, 22 Feb 2017 11:47:21 +0900 From: Minchan Kim To: Shaohua Li CC: , , , , , , , , , Subject: Re: [PATCH V2 6/7] proc: show MADV_FREE pages info in smaps Message-ID: <20170222024721.GA17580@blaptop> References: <1239fb2871c55d63e7e649ad14c6dabaef131d66.1486163864.git.shli@fb.com> MIME-Version: 1.0 In-Reply-To: <1239fb2871c55d63e7e649ad14c6dabaef131d66.1486163864.git.shli@fb.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2017/02/22 11:47:23, Serialize by Router on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2017/02/22 11:47:23, Serialize complete at 2017/02/22 11:47:23 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 03, 2017 at 03:33:22PM -0800, Shaohua Li wrote: > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Hugh Dickins > Cc: Johannes Weiner > Cc: Rik van Riel > Cc: Mel Gorman > Cc: Andrew Morton > Signed-off-by: Shaohua Li > --- > fs/proc/task_mmu.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index ee3efb2..8f2423f 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -440,6 +440,7 @@ struct mem_size_stats { > unsigned long private_dirty; > unsigned long referenced; > unsigned long anonymous; > + unsigned long lazyfree; > unsigned long anonymous_thp; > unsigned long shmem_thp; > unsigned long swap; > @@ -456,8 +457,11 @@ static void smaps_account(struct mem_size_stats *mss, struct page *page, > int i, nr = compound ? 1 << compound_order(page) : 1; > unsigned long size = nr * PAGE_SIZE; > > - if (PageAnon(page)) > + if (PageAnon(page)) { > mss->anonymous += size; > + if (!PageSwapBacked(page)) How about this? if (!PageSwapBacked(page) && !dirty && !PageDirty(page)) > + mss->lazyfree += size; > + } > > mss->resident += size; > /* Accumulate the size in pages that have been accessed. */ > @@ -770,6 +774,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) > "Private_Dirty: %8lu kB\n" > "Referenced: %8lu kB\n" > "Anonymous: %8lu kB\n" > + "LazyFree: %8lu kB\n" > "AnonHugePages: %8lu kB\n" > "ShmemPmdMapped: %8lu kB\n" > "Shared_Hugetlb: %8lu kB\n" > @@ -788,6 +793,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) > mss.private_dirty >> 10, > mss.referenced >> 10, > mss.anonymous >> 10, > + mss.lazyfree >> 10, > mss.anonymous_thp >> 10, > mss.shmem_thp >> 10, > mss.shared_hugetlb >> 10, > -- > 2.9.3 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id 63D826B038A for ; Tue, 21 Feb 2017 21:47:28 -0500 (EST) Received: by mail-pg0-f69.google.com with SMTP id v63so107137386pgv.0 for ; Tue, 21 Feb 2017 18:47:28 -0800 (PST) Received: from lgeamrelo11.lge.com (LGEAMRELO11.lge.com. [156.147.23.51]) by mx.google.com with ESMTP id x17si23830323pfk.215.2017.02.21.18.47.26 for ; Tue, 21 Feb 2017 18:47:27 -0800 (PST) Date: Wed, 22 Feb 2017 11:47:21 +0900 From: Minchan Kim Subject: Re: [PATCH V2 6/7] proc: show MADV_FREE pages info in smaps Message-ID: <20170222024721.GA17580@blaptop> References: <1239fb2871c55d63e7e649ad14c6dabaef131d66.1486163864.git.shli@fb.com> MIME-Version: 1.0 In-Reply-To: <1239fb2871c55d63e7e649ad14c6dabaef131d66.1486163864.git.shli@fb.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-ID: To: Shaohua Li Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Kernel-team@fb.com, danielmicay@gmail.com, mhocko@suse.com, hughd@google.com, hannes@cmpxchg.org, riel@redhat.com, mgorman@techsingularity.net, akpm@linux-foundation.org On Fri, Feb 03, 2017 at 03:33:22PM -0800, Shaohua Li wrote: > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Hugh Dickins > Cc: Johannes Weiner > Cc: Rik van Riel > Cc: Mel Gorman > Cc: Andrew Morton > Signed-off-by: Shaohua Li > --- > fs/proc/task_mmu.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index ee3efb2..8f2423f 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -440,6 +440,7 @@ struct mem_size_stats { > unsigned long private_dirty; > unsigned long referenced; > unsigned long anonymous; > + unsigned long lazyfree; > unsigned long anonymous_thp; > unsigned long shmem_thp; > unsigned long swap; > @@ -456,8 +457,11 @@ static void smaps_account(struct mem_size_stats *mss, struct page *page, > int i, nr = compound ? 1 << compound_order(page) : 1; > unsigned long size = nr * PAGE_SIZE; > > - if (PageAnon(page)) > + if (PageAnon(page)) { > mss->anonymous += size; > + if (!PageSwapBacked(page)) How about this? if (!PageSwapBacked(page) && !dirty && !PageDirty(page)) > + mss->lazyfree += size; > + } > > mss->resident += size; > /* Accumulate the size in pages that have been accessed. */ > @@ -770,6 +774,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) > "Private_Dirty: %8lu kB\n" > "Referenced: %8lu kB\n" > "Anonymous: %8lu kB\n" > + "LazyFree: %8lu kB\n" > "AnonHugePages: %8lu kB\n" > "ShmemPmdMapped: %8lu kB\n" > "Shared_Hugetlb: %8lu kB\n" > @@ -788,6 +793,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) > mss.private_dirty >> 10, > mss.referenced >> 10, > mss.anonymous >> 10, > + mss.lazyfree >> 10, > mss.anonymous_thp >> 10, > mss.shmem_thp >> 10, > mss.shared_hugetlb >> 10, > -- > 2.9.3 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org