From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754436AbdBVHzF (ORCPT ); Wed, 22 Feb 2017 02:55:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:40709 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754363AbdBVHyz (ORCPT ); Wed, 22 Feb 2017 02:54:55 -0500 Date: Wed, 22 Feb 2017 08:54:51 +0100 From: Michal Hocko To: Tetsuo Handa Cc: david@fromorbit.com, dchinner@redhat.com, hch@lst.de, mgorman@suse.de, viro@ZenIV.linux.org.uk, linux-mm@kvack.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/2] mm, vmscan: account the number of isolated pages per zone Message-ID: <20170222075450.GA5753@dhcp22.suse.cz> References: <20170202101415.GE22806@dhcp22.suse.cz> <201702031957.AGH86961.MLtOQVFOSHJFFO@I-love.SAKURA.ne.jp> <20170221094034.GF15595@dhcp22.suse.cz> <201702212335.DJB30777.JOFMHSFtVLQOOF@I-love.SAKURA.ne.jp> <20170221155337.GK15595@dhcp22.suse.cz> <201702221102.EHH69234.OQLOMFSOtJFVHF@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201702221102.EHH69234.OQLOMFSOtJFVHF@I-love.SAKURA.ne.jp> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 22-02-17 11:02:21, Tetsuo Handa wrote: > Michal Hocko wrote: > > On Tue 21-02-17 23:35:07, Tetsuo Handa wrote: > > > Michal Hocko wrote: > > > > OK, so it seems that all the distractions are handled now and linux-next > > > > should provide a reasonable base for testing. You said you weren't able > > > > to reproduce the original long stalls on too_many_isolated(). I would be > > > > still interested to see those oom reports and potential anomalies in the > > > > isolated counts before I send the patch for inclusion so your further > > > > testing would be more than appreciated. Also stalls > 10s without any > > > > previous occurrences would be interesting. > > > > > > I confirmed that linux-next-20170221 with kmallocwd applied can reproduce > > > infinite too_many_isolated() loop problem. Please send your patches to linux-next. > > > > So I assume that you didn't see the lockup with the patch applied and > > the OOM killer has resolved the situation by killing other tasks, right? > > Can I assume your Tested-by? > > No. I tested linux-next-20170221 which does not include your patch. > I didn't test linux-next-20170221 with your patch applied. Your patch will > avoid infinite too_many_isolated() loop problem in shrink_inactive_list(). > But we need to test different workloads by other people. Thus, I suggest > you to send your patches to linux-next without my testing. I will send the patch to Andrew later after merge window closes. It would be really helpful, though, to see how it handles your workload which is known to reproduce the oom starvation. -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f71.google.com (mail-wm0-f71.google.com [74.125.82.71]) by kanga.kvack.org (Postfix) with ESMTP id 094356B0387 for ; Wed, 22 Feb 2017 02:54:55 -0500 (EST) Received: by mail-wm0-f71.google.com with SMTP id r141so1436554wmg.4 for ; Tue, 21 Feb 2017 23:54:54 -0800 (PST) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id 19si706166wrb.21.2017.02.21.23.54.53 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 21 Feb 2017 23:54:53 -0800 (PST) Date: Wed, 22 Feb 2017 08:54:51 +0100 From: Michal Hocko Subject: Re: [RFC PATCH 1/2] mm, vmscan: account the number of isolated pages per zone Message-ID: <20170222075450.GA5753@dhcp22.suse.cz> References: <20170202101415.GE22806@dhcp22.suse.cz> <201702031957.AGH86961.MLtOQVFOSHJFFO@I-love.SAKURA.ne.jp> <20170221094034.GF15595@dhcp22.suse.cz> <201702212335.DJB30777.JOFMHSFtVLQOOF@I-love.SAKURA.ne.jp> <20170221155337.GK15595@dhcp22.suse.cz> <201702221102.EHH69234.OQLOMFSOtJFVHF@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201702221102.EHH69234.OQLOMFSOtJFVHF@I-love.SAKURA.ne.jp> Sender: owner-linux-mm@kvack.org List-ID: To: Tetsuo Handa Cc: david@fromorbit.com, dchinner@redhat.com, hch@lst.de, mgorman@suse.de, viro@ZenIV.linux.org.uk, linux-mm@kvack.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org On Wed 22-02-17 11:02:21, Tetsuo Handa wrote: > Michal Hocko wrote: > > On Tue 21-02-17 23:35:07, Tetsuo Handa wrote: > > > Michal Hocko wrote: > > > > OK, so it seems that all the distractions are handled now and linux-next > > > > should provide a reasonable base for testing. You said you weren't able > > > > to reproduce the original long stalls on too_many_isolated(). I would be > > > > still interested to see those oom reports and potential anomalies in the > > > > isolated counts before I send the patch for inclusion so your further > > > > testing would be more than appreciated. Also stalls > 10s without any > > > > previous occurrences would be interesting. > > > > > > I confirmed that linux-next-20170221 with kmallocwd applied can reproduce > > > infinite too_many_isolated() loop problem. Please send your patches to linux-next. > > > > So I assume that you didn't see the lockup with the patch applied and > > the OOM killer has resolved the situation by killing other tasks, right? > > Can I assume your Tested-by? > > No. I tested linux-next-20170221 which does not include your patch. > I didn't test linux-next-20170221 with your patch applied. Your patch will > avoid infinite too_many_isolated() loop problem in shrink_inactive_list(). > But we need to test different workloads by other people. Thus, I suggest > you to send your patches to linux-next without my testing. I will send the patch to Andrew later after merge window closes. It would be really helpful, though, to see how it handles your workload which is known to reproduce the oom starvation. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org