From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Subject: Re: [PATCH 2/2] net/mlx4: support basic flow items and actions Date: Wed, 22 Feb 2017 11:10:01 +0100 Message-ID: <20170222101001.GJ23344@autoinstall.dev.6wind.com> References: <74798f347a5b1fad28037b713ad83048c227a2ca.1487685098.git.vasilyf@mellanox.com> <7dfd4feed27ce41c118b402f0f93c4332ff05ba2.1487685098.git.vasilyf@mellanox.com> <20170222083742.GI23344@autoinstall.dev.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, Adrien Mazarguil To: Vasily Philipov Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id C2CCF2A5E for ; Wed, 22 Feb 2017 11:10:10 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id v77so7154736wmv.0 for ; Wed, 22 Feb 2017 02:10:10 -0800 (PST) Content-Disposition: inline In-Reply-To: <20170222083742.GI23344@autoinstall.dev.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 22, 2017 at 09:37:42AM +0100, Nélio Laranjeiro wrote: > On Tue, Feb 21, 2017 at 02:07:03PM +0000, Vasily Philipov wrote: > > Adding support for the next items: eth, vlan, ipv4, udp, tcp and for the > > next actions: queue, drop > > > > Signed-off-by: Vasily Philipov > > --- > > drivers/net/mlx4/Makefile | 3 +- > > drivers/net/mlx4/mlx4.c | 60 ++- > > drivers/net/mlx4/mlx4.h | 3 + > > drivers/net/mlx4/mlx4_flow.c | 1053 ++++++++++++++++++++++++++++++++++++++++++ > > drivers/net/mlx4/mlx4_flow.h | 104 +++++ > > 5 files changed, 1220 insertions(+), 3 deletions(-) > > create mode 100644 drivers/net/mlx4/mlx4_flow.c > > create mode 100644 drivers/net/mlx4/mlx4_flow.h > > >[...] > > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > > index 82ccac8..cc2ebfa 100644 > > --- a/drivers/net/mlx4/mlx4.c > > +++ b/drivers/net/mlx4/mlx4.c > > @@ -3985,8 +3989,9 @@ struct txq_mp2mr_mbuf_check_data { > > return -ret; > > } while ((--r) && ((rxq = (*priv->rxqs)[++i]), i)); > > priv_dev_interrupt_handler_install(priv, dev); > > + err = mlx4_priv_flow_start(priv); > > priv_unlock(priv); > > - return 0; > > + return -err; >[...] Hi Vasily, There is an issue in this mlx4_dev_start() when flows cannot be re-applied (like in mlx5 [1][2]). Can you fix it in a v2 please? Thanks, [1] http://dpdk.org/ml/archives/dev/2017-February/058111.html [2] http://dpdk.org/dev/patchwork/patch/20664/ -- Nélio Laranjeiro 6WIND