All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Bragg <robert@sixbynine.org>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/3] drm/i915/perf: improve invalid OA format debug message
Date: Wed, 22 Feb 2017 15:25:08 +0000	[thread overview]
Message-ID: <20170222152510.5039-2-robert@sixbynine.org> (raw)
In-Reply-To: <20170222152510.5039-1-robert@sixbynine.org>

A minor improvement to debugging output

Signed-off-by: Robert Bragg <robert@sixbynine.org>
---
 drivers/gpu/drm/i915/i915_perf.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 383b5769a851..19d0e4222974 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -1898,11 +1898,13 @@ static int read_properties_unlocked(struct drm_i915_private *dev_priv,
 			break;
 		case DRM_I915_PERF_PROP_OA_FORMAT:
 			if (value == 0 || value >= I915_OA_FORMAT_MAX) {
-				DRM_DEBUG("Invalid OA report format\n");
+				DRM_DEBUG("Out-of-range OA report format %llu\n",
+					  value);
 				return -EINVAL;
 			}
 			if (!dev_priv->perf.oa.oa_formats[value].size) {
-				DRM_DEBUG("Invalid OA report format\n");
+				DRM_DEBUG("Unsupported OA report format %llu\n",
+					  value);
 				return -EINVAL;
 			}
 			props->oa_format = value;
-- 
2.11.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-02-22 15:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22 15:25 [PATCH 0/3] Some minor i915-perf prep changes Robert Bragg
2017-02-22 15:25 ` Robert Bragg [this message]
2017-02-27 12:21   ` [PATCH 1/3] drm/i915/perf: improve invalid OA format debug message Matthew Auld
2017-02-22 15:25 ` [PATCH 2/3] drm/i915/perf: better pipeline aged/aging tail updates Robert Bragg
2017-02-28 13:17   ` Matthew Auld
2017-02-22 15:25 ` [PATCH 3/3] drm/i915/perf: rate limit spurious oa report notice Robert Bragg
2017-02-28 13:28   ` Matthew Auld
2017-02-28 13:33     ` Chris Wilson
2017-03-20 16:21       ` Robert Bragg
2017-03-23 19:25         ` [PATCH v2] " Robert Bragg
2017-03-27 21:30           ` Matthew Auld
2017-04-05 15:41             ` [PATCH v3] " Robert Bragg
2017-04-05 16:09               ` Matthew Auld
2017-02-22 18:22 ` ✓ Fi.CI.BAT: success for Some minor i915-perf prep changes Patchwork
2017-03-24 10:01 ` ✗ Fi.CI.BAT: failure for Some minor i915-perf prep changes (rev2) Patchwork
2017-04-05 16:09 ` ✓ Fi.CI.BAT: success for Some minor i915-perf prep changes (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170222152510.5039-2-robert@sixbynine.org \
    --to=robert@sixbynine.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.