From: Jesper Dangaard Brouer <brouer@redhat.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Netdev <netdev@vger.kernel.org>,
Tom Herbert <tom@herbertland.com>,
Alexei Starovoitov <ast@kernel.org>,
John Fastabend <john.r.fastabend@intel.com>,
Daniel Borkmann <daniel@iogearbox.net>,
David Miller <davem@davemloft.net>,
brouer@redhat.com
Subject: Re: Questions on XDP
Date: Wed, 22 Feb 2017 22:59:24 +0100 [thread overview]
Message-ID: <20170222225924.59cdd82c@redhat.com> (raw)
In-Reply-To: <58ADC5A5.7020408@gmail.com>
On Wed, 22 Feb 2017 09:08:53 -0800
John Fastabend <john.fastabend@gmail.com> wrote:
> > GSO/TSO is getting into advanced stuff I would rather not have to get
> > into right now. I figure we need to take this portion one step at a
> > time. To support GSO we need more information like the mss.
> >
>
> Agreed lets get the driver support for basic things first. But this
> is on my list. I'm just repeating myself but VM to VM performance uses
> TSO/LRO heavily.
Sorry, but I get annoyed every time I hear we need to support
TSO/LRO/GRO for performance reasons. If you take one step back, you
are actually saying we need bulking for better performance. And the
bulking you are proposing is a TCP protocol specific bulking mechanism.
I'm saying is let's make bulking protocol agnostic, by doing it at the
packet level. And once the bulk enters the VM, by-all-means it should
construct a GRO packet it can send into it's own network stack.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2017-02-22 22:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 23:31 Questions on XDP Alexei Starovoitov
2017-02-18 23:48 ` John Fastabend
2017-02-18 23:59 ` Eric Dumazet
2017-02-19 2:16 ` Alexander Duyck
2017-02-19 3:48 ` John Fastabend
2017-02-20 20:06 ` Jakub Kicinski
2017-02-22 5:02 ` John Fastabend
2017-02-21 3:18 ` Alexei Starovoitov
2017-02-21 3:39 ` John Fastabend
2017-02-21 4:00 ` Alexander Duyck
2017-02-21 7:55 ` Alexei Starovoitov
2017-02-21 17:44 ` Alexander Duyck
2017-02-22 17:08 ` John Fastabend
2017-02-22 21:59 ` Jesper Dangaard Brouer [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-18 23:59 Alexei Starovoitov
2017-02-16 20:41 Alexander Duyck
2017-02-16 22:36 ` John Fastabend
2017-02-18 16:34 ` Jesper Dangaard Brouer
2017-02-18 17:41 ` Eric Dumazet
2017-02-18 18:18 ` Alexander Duyck
2017-02-18 23:28 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170222225924.59cdd82c@redhat.com \
--to=brouer@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.