From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754884AbdBWAlZ (ORCPT ); Wed, 22 Feb 2017 19:41:25 -0500 Received: from mail.kernel.org ([198.145.29.136]:49802 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753449AbdBWAlR (ORCPT ); Wed, 22 Feb 2017 19:41:17 -0500 Date: Wed, 22 Feb 2017 16:41:14 -0800 From: Jaegeuk Kim To: Yunlong Song Cc: cm224.lee@samsung.com, yuchao0@huawei.com, chao@kernel.org, sylinux@163.com, miaoxie@huawei.com, bintian.wang@huawei.com, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] f2fs: clean up codes in get_ssr_segment Message-ID: <20170223004114.GF4003@jaegeuk.local> References: <1487767851-819-1-git-send-email-yunlong.song@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487767851-819-1-git-send-email-yunlong.song@huawei.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yunlong, This is NOT clean-up. What's your point here? Thanks, On 02/22, Yunlong Song wrote: > Signed-off-by: Yunlong Song > --- > fs/f2fs/segment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index df2ff5c..80997f5 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -1541,7 +1541,7 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type) > struct curseg_info *curseg = CURSEG_I(sbi, type); > const struct victim_selection *v_ops = DIRTY_I(sbi)->v_ops; > > - if (IS_NODESEG(type) || !has_not_enough_free_secs(sbi, 0, 0)) > + if (IS_NODESEG(type)) > return v_ops->get_victim(sbi, > &(curseg)->next_segno, BG_GC, type, SSR); > > -- > 1.8.5.2