From: "Dmitry V. Levin" <ldv@altlinux.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uapi: fix linux/kexec.h userspace compilation errors
Date: Thu, 23 Feb 2017 05:07:02 +0300 [thread overview]
Message-ID: <20170223020702.GA16308@altlinux.org> (raw)
In-Reply-To: <87h93l3cwl.fsf@xmission.com>
[-- Attachment #1: Type: text/plain, Size: 995 bytes --]
On Thu, Feb 23, 2017 at 02:37:46PM +1300, Eric W. Biederman wrote:
> "Dmitry V. Levin" <ldv@altlinux.org> writes:
>
> > Include <stddef.h> (guarded by #ifndef __KERNEL__) to fix the following
> > linux/kexec.h userspace compilation errors:
> >
> > /usr/include/linux/kexec.h:53:2: error: unknown type name 'size_t'
> > size_t bufsz;
> > /usr/include/linux/kexec.h:55:2: error: unknown type name 'size_t'
> > size_t memsz;
>
> Were these failures generated with a static checker?
Yes, with
gcc -S -o/dev/null -xc /dev/null -include /usr/include/linux/kexec.h
> What changed that you are seeing new failures in old essentially static
> headers?
Every uapi header file should be standalone, i.e. it must include,
directly or indirectly, every definition it uses, so that no user
should have to guess header dependencies.
It's not the first time I'm seeing this compilation error,
but now I've got some time to submit a fix. Better late than never.
--
ldv
[-- Attachment #2: Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uapi: fix linux/kexec.h userspace compilation errors
Date: Thu, 23 Feb 2017 05:07:02 +0300 [thread overview]
Message-ID: <20170223020702.GA16308@altlinux.org> (raw)
In-Reply-To: <87h93l3cwl.fsf@xmission.com>
[-- Attachment #1.1: Type: text/plain, Size: 995 bytes --]
On Thu, Feb 23, 2017 at 02:37:46PM +1300, Eric W. Biederman wrote:
> "Dmitry V. Levin" <ldv@altlinux.org> writes:
>
> > Include <stddef.h> (guarded by #ifndef __KERNEL__) to fix the following
> > linux/kexec.h userspace compilation errors:
> >
> > /usr/include/linux/kexec.h:53:2: error: unknown type name 'size_t'
> > size_t bufsz;
> > /usr/include/linux/kexec.h:55:2: error: unknown type name 'size_t'
> > size_t memsz;
>
> Were these failures generated with a static checker?
Yes, with
gcc -S -o/dev/null -xc /dev/null -include /usr/include/linux/kexec.h
> What changed that you are seeing new failures in old essentially static
> headers?
Every uapi header file should be standalone, i.e. it must include,
directly or indirectly, every definition it uses, so that no user
should have to guess header dependencies.
It's not the first time I'm seeing this compilation error,
but now I've got some time to submit a fix. Better late than never.
--
ldv
[-- Attachment #1.2: Type: application/pgp-signature, Size: 801 bytes --]
[-- Attachment #2: Type: text/plain, Size: 143 bytes --]
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2017-02-23 2:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 22:46 [PATCH] uapi: fix linux/kexec.h userspace compilation errors Dmitry V. Levin
2017-02-22 22:46 ` Dmitry V. Levin
2017-02-23 1:37 ` Eric W. Biederman
2017-02-23 1:37 ` Eric W. Biederman
2017-02-23 2:07 ` Dmitry V. Levin [this message]
2017-02-23 2:07 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223020702.GA16308@altlinux.org \
--to=ldv@altlinux.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.