All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v4 15/16] drm/i915: Immediately process a reset before starting waiting
Date: Thu, 23 Feb 2017 07:44:21 +0000	[thread overview]
Message-ID: <20170223074422.4125-16-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20170223074422.4125-1-chris@chris-wilson.co.uk>

As we handoff the GPU reset to the waiter, we need to check we don't
miss a wakeup if it has already been sent prior to us starting the wait.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem_request.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c
index ee601e13e28a..eaa333a35f7c 100644
--- a/drivers/gpu/drm/i915/i915_gem_request.c
+++ b/drivers/gpu/drm/i915/i915_gem_request.c
@@ -1081,8 +1081,10 @@ long i915_wait_request(struct drm_i915_gem_request *req,
 	trace_i915_gem_request_wait_begin(req, flags);
 
 	add_wait_queue(&req->execute, &exec);
-	if (flags & I915_WAIT_LOCKED)
+	if (flags & I915_WAIT_LOCKED) {
 		add_wait_queue(errq, &reset);
+		__i915_wait_request_check_and_reset(req);
+	}
 
 	intel_wait_init(&wait);
 
@@ -1120,7 +1122,8 @@ long i915_wait_request(struct drm_i915_gem_request *req,
 		goto complete;
 
 	set_current_state(state);
-	if (intel_engine_add_wait(req->engine, &wait))
+	if (intel_engine_add_wait(req->engine, &wait) ||
+	    flags & I915_WAIT_LOCKED)
 		/* In order to check that we haven't missed the interrupt
 		 * as we enabled it, we need to kick ourselves to do a
 		 * coherent check on the seqno before we sleep.
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-02-23  7:44 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23  7:44 Preemption preparation pass phaw Chris Wilson
2017-02-23  7:44 ` [PATCH v4 01/16] drm/i915: Check against the signaled bit for fences/requests Chris Wilson
2017-02-23  7:44 ` [PATCH v4 02/16] drm/i915: Keep a global seqno per-engine Chris Wilson
2017-02-23  7:44 ` [PATCH v4 03/16] drm/i915: Move reserve_seqno() next to unreserve_seqno() Chris Wilson
2017-02-23  7:44 ` [PATCH v4 04/16] drm/i915: Use a local to shorten req->i915->gpu_error.wait_queue Chris Wilson
2017-02-23  7:44 ` [PATCH v4 05/16] drm/i915: Add ourselves to the gpu error waitqueue for the entire wait Chris Wilson
2017-02-23  7:44 ` [PATCH v4 06/16] drm/i915: Inline __i915_gem_request_wait_for_execute() Chris Wilson
2017-02-23  7:44 ` [PATCH v4 07/16] drm/i915: Deconstruct execute fence Chris Wilson
2017-02-23  7:44 ` [PATCH v4 08/16] drm/i915: Protect the request->global_seqno with the engine->timeline lock Chris Wilson
2017-02-23  7:44 ` [PATCH v4 09/16] drm/i915: Take a reference whilst processing the signaler request Chris Wilson
2017-02-23  7:44 ` [PATCH v4 10/16] drm/i915: Allow a request to be cancelled Chris Wilson
2017-02-23  7:44 ` [PATCH v4 11/16] drm/i915: Remove the preempted request from the execution queue Chris Wilson
2017-02-23 12:11   ` Tvrtko Ursulin
2017-02-23  7:44 ` [PATCH v4 12/16] drm/i915: Exercise request cancellation using a mock selftest Chris Wilson
2017-02-23 12:21   ` Tvrtko Ursulin
2017-02-23  7:44 ` [PATCH v4 13/16] drm/i915: Replace reset_wait_queue with default_wake_function Chris Wilson
2017-02-23  7:44 ` [PATCH v4 14/16] drm/i915: Refactor direct GPU reset from request waiters Chris Wilson
2017-02-23 12:23   ` Tvrtko Ursulin
2017-02-23  7:44 ` Chris Wilson [this message]
2017-02-23 12:35   ` [PATCH v4 15/16] drm/i915: Immediately process a reset before starting waiting Tvrtko Ursulin
2017-02-23 12:41     ` Chris Wilson
2017-02-23 12:45       ` Tvrtko Ursulin
2017-02-23  7:44 ` [PATCH v4 16/16] drm/i915: Remove one level of indention from wait-for-execute Chris Wilson
2017-02-23  8:18 ` ✓ Fi.CI.BAT: success for series starting with [v4,01/16] drm/i915: Check against the signaled bit for fences/requests Patchwork
2017-02-23 15:21   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170223074422.4125-16-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.