From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?U8WCYXdvbWlyIFN0xJlwaWXFhCAoTm9raWEgLSBQTC9Xcm9jbGF3KQ==?= Subject: Re: [PATCH v2] gpio: pl061: use all specified IRQs for chained handler Date: Thu, 23 Feb 2017 13:58:01 +0100 Message-ID: <20170223125801.GB1488@sstepien> References: <20170222123049.17588-1-alexander.sverdlin@nokia.com> <7e183e70-50e0-61ed-6b33-e691046df725@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: Received: from mail-db5eur01on0131.outbound.protection.outlook.com ([104.47.2.131]:51009 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751041AbdBWNRu (ORCPT ); Thu, 23 Feb 2017 08:17:50 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij Cc: Alexander Sverdlin , Marc Zyngier , Krzysztof Adamski , Alexandre Courbot , "linux-gpio@vger.kernel.org" On Feb 23, 2017 10:45, Linus Walleij wrote: > On Wed, Feb 22, 2017 at 1:57 PM, Alexander Sverdlin > wrote: > > >> - If the component has 8 IRQ lines, create a hierarchical IRQdomain > >> and chip using a gpiolib core helper. > > > > This was an option of course, the only this is, PL061 spec says, there is > > GPIOINTR and if someone has forgot it, we can support it with a quirk. > > I don't know about that. The PL061 manual says: > > "The contents of this register are made available externally through the > intra-chip (or on-chip) GPIOMIS[7:0] signals." > > They don't say why, but it is reasonable to assume that this is an > either-or not both-and integration point. > > EITHER you route GPIOMIS[7:0] to individual IRQ lines to the CPU > OR you route GPIOINTR to the CPU. On page 2-10, 2.3.4 you can read: "a single interrupt output GPIOINTR and/or the individual interrupts can be sent to the interrupt controller." Also see figure 2-1, 4-2. Does it not says that there are two independent options available? -- Best regards Sławomir Stępień