All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 15/25] luaposix: fix runtime by selecting "bit32" instead of "bitop"
Date: Thu, 23 Feb 2017 18:00:37 +0100	[thread overview]
Message-ID: <20170223170047.24417-16-arnout@mind.be> (raw)
In-Reply-To: <20170223170047.24417-1-arnout@mind.be>

Since the bump of luaposix to 33.4.0, it doesn't work anymore at
runtime with LuaJIT or Lua 5.1. This can be tested with the following
defconfig:

BR2_x86_64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_LUA=y
BR2_PACKAGE_LUA_5_1=y
BR2_PACKAGE_LUAPOSIX=y

/usr/bin/lua: /usr/share/lua/5.1/posix/init.lua:17: module 'bit32' not found:
...

In older luaposix versions, it would try to load the 'bit' instead of
'bit32' module if LUAVER == 5.1. However, this feature was removed in
33.4.0.

So instead of adding a runtime dependency on luabitop, depend on
lua-bit32.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/luaposix/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/luaposix/Config.in b/package/luaposix/Config.in
index 9707cdeeff..91abcb9e32 100644
--- a/package/luaposix/Config.in
+++ b/package/luaposix/Config.in
@@ -1,8 +1,10 @@
 config BR2_PACKAGE_LUAPOSIX
 	bool "luaposix"
 	depends on BR2_PACKAGE_HAS_LUAINTERPRETER
-	select BR2_PACKAGE_LUABITOP if BR2_PACKAGE_LUA_5_1
-	# LuaBitOp is already included in LuaJIT
+	# "bit32" is included in Lua 5.2+. luajit has an equivalent
+	# "bit" module, but since it has a different name, luaposix
+	# doesn't find it.
+	select BR2_PACKAGE_LUA_BIT32 if BR2_PACKAGE_LUA_5_1 || BR2_PACKAGE_LUAJIT
 	help
 	  This is a POSIX binding for LuaJIT, Lua 5.1, 5.2 and 5.3;
 	  like most libraries it simply binds to C APIs on the
-- 
2.11.0

  parent reply	other threads:[~2017-02-23 17:00 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 17:00 [Buildroot] [PATCH for-next 0/25] Lua(Rocks) improvements Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 01/25] lutok: move to Lua libraries menu Arnout Vandecappelle
2017-03-02 21:29   ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 02/25] cosmo: remove broken package Arnout Vandecappelle
2017-03-02 21:31   ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 03/25] luarocks-package: use $(HOST_PKG_VERSION) instead of $(PKG_VERSION) Arnout Vandecappelle
2017-03-02 21:43   ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 04/25] manual: luarocks: improve tutorial example Arnout Vandecappelle
2017-03-02 21:43   ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 05/25] lpty: remove LPTY_VERSION_UPSTREAM Arnout Vandecappelle
2017-03-02 21:45   ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 06/25] lua-periphery: remove LUA_PERIPHERY_VERSION_UPSTREAM Arnout Vandecappelle
2017-03-02 21:45   ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 07/25] luasec: remove LUASEC_VERSION_UPSTREAM Arnout Vandecappelle
2017-03-02 21:45   ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 08/25] ljlinenoise: remove default definition of PKG_SUBDIR Arnout Vandecappelle
2017-03-02 21:48   ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 09/25] lua-csnappy: " Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 10/25] lua-iconv: " Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 11/25] luacrypto: " Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 12/25] lunit: " Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 13/25] package/Config.in: explain that lua package names should start with lua Arnout Vandecappelle
2017-03-02 21:50   ` Thomas Petazzoni
2017-03-02 22:19     ` Arnout Vandecappelle
2017-03-02 22:22       ` Thomas Petazzoni
2017-03-02 22:26         ` Arnout Vandecappelle
2017-03-02 22:38           ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 14/25] lua-bit32: new package Arnout Vandecappelle
2017-03-02 21:54   ` Thomas Petazzoni
2017-03-02 22:24     ` Arnout Vandecappelle
2017-03-17 16:14       ` Thomas Petazzoni
2017-03-17 22:17         ` Arnout Vandecappelle
2017-03-18 10:42           ` Thomas Petazzoni
2017-03-18 13:17             ` Arnout Vandecappelle
2017-03-18 13:49               ` [Buildroot] Orphan package notification Thomas Petazzoni
2017-03-18 14:03                 ` Arnout Vandecappelle
2017-02-23 17:00 ` Arnout Vandecappelle [this message]
2017-03-02 21:58   ` [Buildroot] [PATCH 15/25] luaposix: fix runtime by selecting "bit32" instead of "bitop" Thomas Petazzoni
2017-03-02 22:25     ` Arnout Vandecappelle
2017-03-02 22:28   ` Thomas Petazzoni
2017-03-02 23:02     ` Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 16/25] luarocks-package: rework extraction Arnout Vandecappelle
2017-03-02 22:24   ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 17/25] lua-bit32: remove custom extract commands Arnout Vandecappelle
2017-03-02 22:24   ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 18/25] luarocks-package: introduce PKG_NAME_UPSTREAM Arnout Vandecappelle
2017-03-02 22:26   ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 19/25] lua-bit32: use PKG_NAME_UPSTREAM Arnout Vandecappelle
2017-03-02 22:26   ` Thomas Petazzoni
2017-02-23 17:00 ` [Buildroot] [PATCH 20/25] luarocks-package: lowercase the upstream name for LuaRocks Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 21/25] lua-coat: use PKG_NAME_UPSTREAM Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 22/25] lua-cjson: use LUA_CJSON_SUBDIR Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 23/25] lua-testmore: use PKG_NAME_UPSTREAM Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 24/25] luabitop: " Arnout Vandecappelle
2017-02-23 17:00 ` [Buildroot] [PATCH 25/25] lua: remove documentation from target Arnout Vandecappelle
2017-02-24  6:59 ` [Buildroot] [PATCH for-next 0/25] Lua(Rocks) improvements François Perrad
2017-02-24  9:09   ` Arnout Vandecappelle
2017-02-24 10:57     ` François Perrad
2017-03-05 21:05 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170223170047.24417-16-arnout@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.