From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751306AbdBXGQo (ORCPT ); Fri, 24 Feb 2017 01:16:44 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:42624 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbdBXGQh (ORCPT ); Fri, 24 Feb 2017 01:16:37 -0500 Date: Thu, 23 Feb 2017 22:15:50 -0800 From: Shaohua Li To: Minchan Kim CC: , , , , , , , , Subject: Re: [PATCH V4 3/6] mm: move MADV_FREE pages into LRU_INACTIVE_FILE list Message-ID: <20170224061549.GB86912@brenorobert-mbp.dhcp.thefacebook.com> References: <20170224014939.GC9818@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170224014939.GC9818@bbox> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [2620:10d:c090:180::e50a] X-ClientProxiedBy: BY2PR02CA0105.namprd02.prod.outlook.com (10.163.44.159) To MWHPR15MB1648.namprd15.prod.outlook.com (10.175.139.151) X-MS-Office365-Filtering-Correlation-Id: 6f2a1a8e-d423-4569-c657-08d45c7c9948 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR15MB1648; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1648;3:sBk6HEhf3wxsj3hthJqRjWwxXFqs+MGIsysKUAJ/drNgwoVzUZZbiW+ahFY2dM4pjWkSPw0KY6Xyev/ROGdP1rcAKdT+fr6pBd3Ggmy2+yo3E64DkswycwQMQF3sx8H2xkylJE5ZhfUJIYRtszIPIecBC+Ul5QUlBU+gIE6wGUp7Jc7moLB1HRa7lD51APNYrCXS6mOTtMFUW/Z8VfGzbWzjVQLHfqNxWVYstwbq8i+J+KXe0lBetX4WbJhyViIYU6HI3rHICKkFPe0p8qgXLg==;25:d6FHuuhwdgz9mAn/dy3jnyoFBQKAM0AvyxpH0l0ykShbborBE13L/XR8xWXRnRY5KSNlkKnk9M4+9hU70M1ZMXS1llkOuyK//I61ZN5hWvhQAK2s3LJzYbw5ujp24NSZZ6vUCI0I3yHR7ylQRscugyqK8IlInyNKWXF+TSvDHdm6X4FIKBJCC/DHoarIOYD9qUUD4ShBgZkujihbRnzDONtYmHrkQmz/cF9Csu3Kspz2NzDcXiGJ7f/kce31awXpgWn2sfTtlYm8RHcibc/E6LjrF3f/hDGr63VnqqlvFPLm6z5Pyw6m22IT62yTDX0dSXtH7TB0LyvzbdDqu0IPBZ+O2PpPYDtI5hv8+4ScWTYTBNFMW9hIgMNo7kSqdzolb6tvx/u+6JYVAdUF7LCJrT5uVBxprOSm4jgLSITBlCZj4W4X1/XyZMDuDXT6sEXZJuZrPRvHa3hED7T60GvOOQ== X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1648;31:8cV6N1OZGb/gaU30zVlu3aYS1xMwqRQ1hyZCxYltBJ1C/pl5lNCjzXei8+am6qsAkpWn19jlHnLzPRedX+5bP6m7zqAn+bmyHw+Z9Up6f934esq7vSUSLTVgD/XWV3vZuTNDwnUyit5FQebtKMqRWgg4LcZRhWwG4YPPGuAFaw4gRGwxNA2M+VhJT4u/xg1nCeL3JjA5M6lAfiRPw6TDEQaGhXQDMno6SKvXd9cRq1hPoZE08j42asZYPNMPcWZA;20:QNYflFFbp8CdJpauG1OwlRTZJcTMJzhHZOyBC7RT+fdGvTaOe2bLJxCmuw631DVtiRiXLnIASISDr2lnait4wSgK3FdiGLLo+kYcI6oN2++wati2frGdWv1KRHA86lHJ9sHABro7W5NtupyzABXfq50Zys2qYqBxN1+b2s7+FLQG3lCIEyyrSUMDolq6llvl+pxgtDIYhH7FWkcrGQiLRLrAkXdGFVDfwau6HYkPk614y4VQv9/rYT5cLKiXk2fidn+gnU3Zd+4ctDzBMz4OmARNnUXJ0nP+zW7iR02H4HQDYevTz7i+LGddELqF2k8Dzj96FkXMtkuwczKkk1FpWmS7IGcdVqgR8MD5CY09ifAz/vtRyfyWz4m63V3+bCvs3HNL6N5E924jua97GlvtdeCOQJPpbNSR/lE5s/PByTrR8fD4VDuUw2kef56BKwHjjH2mNkWLduKmKNnvy6f7HI1ht08y1tjlUTbprqlPT3ZmiAcEd7AAS+HGnhNIS0++ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484)(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123558025)(20161123560025)(6072148);SRVR:MWHPR15MB1648;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1648; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1648;4:1+5bCt/sQsQ3fenB4pXUHadc7uX2xHMcd002iWqFrumzgrHmFJxiq9yL4I5MO2yEjYFSYoRBv2rO6dSWZSNzGw453/SEQUvyJbfJEEgTFTOledoDOwSwlla5Tb12rmAws0EqWCuVMhJqodqkI9EgIbOe6biTMskC1zsj68fcljY6iI0JCm/Ad8swtb79dLPLYV+kh4rQ6xcWG74A4pEPK3ss3Cfm/Y/TPgmEgcz43n5gg/eGC+eyYMl4ff2Qnj4dt9cxLrPIqYVdWpk1ZIUWYrFOJOTwwtQEhnVAmyQ0tIRSCUGDTW2b6lkso6EiSBqvMto7CJci5Gmdqo1p3ldTRGfxmezyx9WYrmwUaQeVRPw0qWQRjxe2WcUrkFpcL5Q1SUnK1BreMYhZhyY1EIoQWXgMQlz3sOFGedRdssD62g3u4z83wb2pw7rWI51YU+QGcnxqkC+0cvp/qEcjzsXDvyFkV5W18KnrRfcFdMkOpTRsavBBUW2DzYqC/dmaDP+53lRBLocpbO6O8COoyBJutwHH+dNcAnyHitfVxIPVVDx7Ovfar8b8GSX6eCBPQMVdoUAlhT2B4Wv7pbfgMydptMYV8yNIlnlNTb3qkIpBQI/cjcoPEZEL48Dy5DQi8otPxSMOdAuLTzQOb/+CTx3d1/cl5P4xy4ewLTLGIoSFhdv/xCk/DKaOWzzuvchUNgLB X-Forefront-PRVS: 0228DDDDD7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39450400003)(24454002)(199003)(189002)(23726003)(1076002)(305945005)(7736002)(6246003)(4326007)(81166006)(83506001)(81156014)(68736007)(2906002)(46406003)(33656002)(4001350100001)(189998001)(25786008)(110136004)(38730400002)(8676002)(97736004)(53936002)(9686003)(86362001)(54906002)(55016002)(101416001)(105586002)(5660300001)(6506006)(229853002)(97756001)(47776003)(92566002)(6916009)(2950100002)(50466002)(6116002)(106356001)(42186005)(6666003)(50986999)(54356999)(76176999)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1648;H:brenorobert-mbp.dhcp.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR15MB1648;23:jDRCVDW/Hy3ePSfMPoiXKsuPK8u5++B8XiSaLOlI+?= =?us-ascii?Q?AWIHExHY1bClY9l3fq3dCGydjzzS42f1WqWVLjjQms2KecetwHVOq1jInQoO?= =?us-ascii?Q?npNi18t6cL4W4ZjPR6jU7ID9Dn0lWtNnroWlLukAx1GZeBebZ1uUig2PDpNk?= =?us-ascii?Q?Ohdt5N8ZbEzhhJHHnhA6Ns9oPie4hk8q9n/ixBjQx6d+BxMX1SFYR5CYo2P/?= =?us-ascii?Q?+dDkYSvLIPz3UPMWEBZCK2jok+WNHixeKigROm9XOPIIjbTT4ghu0R0rVnqz?= =?us-ascii?Q?gf044w7ENpnoKJv7CjYbrvjkxY1ogo+ppG0NjEKXs87v8VFvrHRPI5HsyC4z?= =?us-ascii?Q?Qrhz7t7tdebgjzwhbzYQIXdZh4f/HGuBVDebj8bEynE/XkuyZZPjL0XH+cz3?= =?us-ascii?Q?klUUMaKymDGIaoe+ncg78OQ+sb4JdTgIqr7WG4pnVqXrz7btadH75EztcedL?= =?us-ascii?Q?EcmED4E4xhCGq4rchp9fnYZZkZ2JTC0OlRyjOZM/8eq3R9LRQEJcqxXnukL4?= =?us-ascii?Q?IAjRlqkkyT0A9rlI6zFEDn0l7OJA3BykUKffrdYrjUB7WvBJV8RDD1FBQAOm?= =?us-ascii?Q?9HZFUGCksKwNQ1pTKmzwRKBZ981jjCMXtjvsxdahZg9WWhImyD0Iowlg8sKB?= =?us-ascii?Q?qPTKOKVmtgYvPJdcDIfqj146hv4TMf6umq7kCa0g7IWa1bSJzmHhlC0fky4H?= =?us-ascii?Q?XzZLcwEAMn0SXdwfytigblrq8jNoOm5RWEljxiNu3dt7n7JTVR39GpOVpmtM?= =?us-ascii?Q?rRedQMRBtumwoZTZmOEv9adZGEfOgVvq7w9z1ekxEaX8BSTguIkLCjpzQZog?= =?us-ascii?Q?yz+4RGjHzdyBk0lwvAso6BuL5IfhHxY+D5o1ZA305sP7DIFFLds8rCWesPJb?= =?us-ascii?Q?w3LBGpmWycODdhdD/6YU/jHaBYySRP1lRLHNbMXk8ntofiDRG5p82wzNS03K?= =?us-ascii?Q?hDaSU+KKISqt915vkbo85cja5RuzG+5Gn7YG0oNg+PN67iajNyP9QRcitnWn?= =?us-ascii?Q?USCAEMzpFcAqODMgfo+W6/uzMb6XZ8k0oGKmP3Ot+M7aeEiwmg9GcbxeFAiJ?= =?us-ascii?Q?lcVGPHKWZi1n2UplXgvH3it1jZjcNgeNVXqYzTWnAkoqGhQBBGjbS5QWeGoh?= =?us-ascii?Q?IamFvsEq0PnzxYg8xkKTiHBjdKI9voUf0sd4kfo+ZV1xm2ocSTW3ViQHFtmw?= =?us-ascii?Q?KZjlxSYd8yVhqcVWTUa7JTjxWqp9ELmC2gPWeh68eLngm6bVlz7Yc9ebw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1648;6:oZaZ1XYKNL5ELhWSBmAl98+CyO7CO2aqhVIZFT98BlGA0XjOwIvf0x8556c/yJBIf6zgScED3rsVA7rJU+m6J9iS+HaTUACQw1VrzgFKZiVIbuFH+jmPPJf/HlArTELZHEn39m8GTMIE430+uzmN3NWExW66k4uLqvw7WeTX9efYuOHSFLTd3uNHtxxl2HVC3/Ol2PlDX/GZqiebTZineXvju/FLOHRZJgNDS6R4Q15uLEtasx2B4JfmkN8ksYGKz5dyX09ks9IscQglm3J9LVMh88Ac/mdHRNRKSRgmm6xRjUvxUWkKIhAOGiWGVHTBUVzf4RbQJX/GiKoDQDXca4+4KV9qNFyMTMsldORCaP15wi7zmSWuch1xnSCSi+ZOhvHgaBU6Flsu76soZIkoVA==;5:wPpV15qqJH56/N+ESHmwx6K5YA9R2YFsr3Cz46Je5xq/oR0q4sI2EkD2HINShl8buBE3faD/e5qo3n+qkmf/eRoN5oFMUSn6H1QGJtjzq0+wzCpaWpq1+GNa973RFNgBpHXY6k0yUVlW/fAcboL6ww==;24:US2nI2Am079emcTEVhAkMsqKpZ42aBdB3bkvibvZubTOW3d2hEo1km+FvX7TRaph5N71aWYH0cygC/8TUPjcniPM0Adr3ZEr7Lqq9sX+gIM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1648;7:yWAIXpc4JxfddxNuQrk5xm+9ZhOGseA1yT/7mtIVQO3jKjQ6681ogkWgei9SXCAB96UwINTDJGcJ9S6QpStMcZgrAoL1ADJQh85iRqkr0F1cpr2YlRR0pWCKNZk7+HetGLZuDeBs2yWAebGzNYh7+cLthx70KMSDv+YrUxDUqOJTiq8Eunj8oCq8iEqhohLLce5TW+Vn5tbJkEpcpnvdCeBvhbshsFozG/qWO//OZdoS9lpxunI0Q4HwNSwZHv9Jr8vHiW33yLeaSqzVs9+fwyOtsjz12GdGAZrZx5vEidL6/avdJqR65ZbzaVAZ5/n2xYHDKYBsRiUtEyfgNHnnuQ==;20:NpKU0N+MiBn+RgGcVmv9diWhpJi34dBEWRg7uL3h+tAWvQROTswTeiHZAQultr0RlwVd8jeJqRaBGgAOm4sNoE/YqsvhJHtLZt+CVlq/tNy68Ab8GyPdf/EE73oOqqOmsJaNXrnesY+X8eo8MzLkXQiDN2Ho1gDPy4l2Op1JrvA= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2017 06:15:57.0635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1648 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-24_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 24, 2017 at 10:49:39AM +0900, Minchan Kim wrote: > On Wed, Feb 22, 2017 at 10:50:41AM -0800, Shaohua Li wrote: > > madv MADV_FREE indicate pages are 'lazyfree'. They are still anonymous > > pages, but they can be freed without pageout. To destinguish them > > against normal anonymous pages, we clear their SwapBacked flag. > > > > MADV_FREE pages could be freed without pageout, so they pretty much like > > used once file pages. For such pages, we'd like to reclaim them once > > there is memory pressure. Also it might be unfair reclaiming MADV_FREE > > pages always before used once file pages and we definitively want to > > reclaim the pages before other anonymous and file pages. > > > > To speed up MADV_FREE pages reclaim, we put the pages into > > LRU_INACTIVE_FILE list. The rationale is LRU_INACTIVE_FILE list is tiny > > nowadays and should be full of used once file pages. Reclaiming > > MADV_FREE pages will not have much interfere of anonymous and active > > file pages. And the inactive file pages and MADV_FREE pages will be > > reclaimed according to their age, so we don't reclaim too many MADV_FREE > > pages too. Putting the MADV_FREE pages into LRU_INACTIVE_FILE_LIST also > > means we can reclaim the pages without swap support. This idea is > > suggested by Johannes. > > > > This patch doesn't move MADV_FREE pages to LRU_INACTIVE_FILE list yet to > > avoid bisect failure, next patch will do it. > > > > The patch is based on Minchan's original patch. > > > > Cc: Michal Hocko > > Cc: Minchan Kim > > Cc: Hugh Dickins > > Cc: Rik van Riel > > Cc: Mel Gorman > > Cc: Andrew Morton > > Suggested-by: Johannes Weiner > > Signed-off-by: Shaohua Li > > Other than that Johannes pointed out, code itself looks good to me. > However, I hope to merge this patch with next one. > It's enough simple to merge, change behavior(about deactivation), > mark_page_lazyfree is introduced but there is no callsite to use it > in this patch. > > I don't think it's worth to separate. I think it's more clear in this way, doing one thing in one patch. Thanks, Shaohua From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f198.google.com (mail-qk0-f198.google.com [209.85.220.198]) by kanga.kvack.org (Postfix) with ESMTP id 48C236B0389 for ; Fri, 24 Feb 2017 01:16:08 -0500 (EST) Received: by mail-qk0-f198.google.com with SMTP id u188so12721329qkc.1 for ; Thu, 23 Feb 2017 22:16:08 -0800 (PST) Received: from mx0b-00082601.pphosted.com (mx0b-00082601.pphosted.com. [67.231.153.30]) by mx.google.com with ESMTPS id i10si4960180qtg.210.2017.02.23.22.16.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Feb 2017 22:16:07 -0800 (PST) Date: Thu, 23 Feb 2017 22:15:50 -0800 From: Shaohua Li Subject: Re: [PATCH V4 3/6] mm: move MADV_FREE pages into LRU_INACTIVE_FILE list Message-ID: <20170224061549.GB86912@brenorobert-mbp.dhcp.thefacebook.com> References: <20170224014939.GC9818@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170224014939.GC9818@bbox> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kernel-team@fb.com, mhocko@suse.com, hughd@google.com, hannes@cmpxchg.org, riel@redhat.com, mgorman@techsingularity.net, akpm@linux-foundation.org On Fri, Feb 24, 2017 at 10:49:39AM +0900, Minchan Kim wrote: > On Wed, Feb 22, 2017 at 10:50:41AM -0800, Shaohua Li wrote: > > madv MADV_FREE indicate pages are 'lazyfree'. They are still anonymous > > pages, but they can be freed without pageout. To destinguish them > > against normal anonymous pages, we clear their SwapBacked flag. > > > > MADV_FREE pages could be freed without pageout, so they pretty much like > > used once file pages. For such pages, we'd like to reclaim them once > > there is memory pressure. Also it might be unfair reclaiming MADV_FREE > > pages always before used once file pages and we definitively want to > > reclaim the pages before other anonymous and file pages. > > > > To speed up MADV_FREE pages reclaim, we put the pages into > > LRU_INACTIVE_FILE list. The rationale is LRU_INACTIVE_FILE list is tiny > > nowadays and should be full of used once file pages. Reclaiming > > MADV_FREE pages will not have much interfere of anonymous and active > > file pages. And the inactive file pages and MADV_FREE pages will be > > reclaimed according to their age, so we don't reclaim too many MADV_FREE > > pages too. Putting the MADV_FREE pages into LRU_INACTIVE_FILE_LIST also > > means we can reclaim the pages without swap support. This idea is > > suggested by Johannes. > > > > This patch doesn't move MADV_FREE pages to LRU_INACTIVE_FILE list yet to > > avoid bisect failure, next patch will do it. > > > > The patch is based on Minchan's original patch. > > > > Cc: Michal Hocko > > Cc: Minchan Kim > > Cc: Hugh Dickins > > Cc: Rik van Riel > > Cc: Mel Gorman > > Cc: Andrew Morton > > Suggested-by: Johannes Weiner > > Signed-off-by: Shaohua Li > > Other than that Johannes pointed out, code itself looks good to me. > However, I hope to merge this patch with next one. > It's enough simple to merge, change behavior(about deactivation), > mark_page_lazyfree is introduced but there is no callsite to use it > in this patch. > > I don't think it's worth to separate. I think it's more clear in this way, doing one thing in one patch. Thanks, Shaohua -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org