From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v7 08/17] test: change params to distributor
	autotest
Date: Fri, 24 Feb 2017 14:14:42 +0000
Message-ID: <20170224141442.GJ106392@bricha3-MOBL3.ger.corp.intel.com>
References: <1485163480-156507-2-git-send-email-david.hunt@intel.com>
 <1487647073-129064-1-git-send-email-david.hunt@intel.com>
 <1487647073-129064-9-git-send-email-david.hunt@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: David Hunt <david.hunt@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 2D66A2BB4
 for <dev@dpdk.org>; Fri, 24 Feb 2017 15:14:46 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1487647073-129064-9-git-send-email-david.hunt@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Feb 21, 2017 at 03:17:44AM +0000, David Hunt wrote:
> In the next few patches, we'll want to test old and new API,
> so here we're allowing different parameters to be passed to
> the tests, instead of just a distributor struct.
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
>  app/test/test_distributor.c | 64 +++++++++++++++++++++++++++++----------------
>  1 file changed, 42 insertions(+), 22 deletions(-)
> 
> diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
> index 6a4e20b..fdfa793 100644
> --- a/app/test/test_distributor.c
> +++ b/app/test/test_distributor.c
> @@ -45,6 +45,13 @@
>  #define BURST 32
>  #define BIG_BATCH 1024
>  
> +struct worker_params {
> +	char name[64];
> +	struct rte_distributor_v20 *dist;
> +};
> +
> +struct worker_params worker_params;
> +
>  /* statics - all zero-initialized by default */
>  static volatile int quit;      /**< general quit variable for all threads */
>  static volatile int zero_quit; /**< var for when we just want thr0 to quit*/
> @@ -81,7 +88,8 @@ static int
>  handle_work(void *arg)
>  {
>  	struct rte_mbuf *pkt = NULL;
> -	struct rte_distributor_v20 *d = arg;
> +	struct worker_params *wp = arg;
> +	struct rte_distributor_v20 *d = wp->dist;

The cover letter indicated that using new vs old API was just a matter
of passing a different parameter to create. I therefore would not expect
to see references to v20 APIs or structures in any code outside the lib
itself. Am I missing something?

/Bruce