From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v7 15/17] lib: make v20 header file private
Date: Fri, 24 Feb 2017 14:18:33 +0000
Message-ID: <20170224141833.GM106392@bricha3-MOBL3.ger.corp.intel.com>
References: <1485163480-156507-2-git-send-email-david.hunt@intel.com>
 <1487647073-129064-1-git-send-email-david.hunt@intel.com>
 <1487647073-129064-16-git-send-email-david.hunt@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: David Hunt <david.hunt@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 26B03376C
 for <dev@dpdk.org>; Fri, 24 Feb 2017 15:18:36 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1487647073-129064-16-git-send-email-david.hunt@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Feb 21, 2017 at 03:17:51AM +0000, David Hunt wrote:
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
>  lib/librte_distributor/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile
> index 5b599c6..3017398 100644
> --- a/lib/librte_distributor/Makefile
> +++ b/lib/librte_distributor/Makefile
> @@ -53,8 +53,7 @@ endif
>  
>  
>  # install this header file
> -SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor_v20.h
> -SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include += rte_distributor.h
> +SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor.h
>  

Minor nits:
1/ I think this patch should go earlier in the set.
2/ you can keep the += in the assignment. It actually makes it less
error prone for anyone changing/adding things later as they can
copy-paste or reorder the lines without causing themselves problems.

/Bruce