All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [PATCH 00/29] Refactor xl code
Date: Fri, 24 Feb 2017 16:12:45 +0000	[thread overview]
Message-ID: <20170224161314.22154-1-wei.liu2@citrix.com> (raw)

xl_cmdimpl.c has become prohibitively large (almost 10k lines in one single
file). Try to split it up into multiple files according to the functionality of
the code.

I will run a full osstest flight before merging. Send the first version  out as
quick as possible to gather feedback because I know other people are also
touching this area of code.

Further improvements are certainly desired, for example we should probably give
functions better names, but this series is already very long, so let's save
that for another day.

Wei Liu (29):
  xl: remove accidentally committed hunk from Makefile
  xl: update copyright information
  xl: remove inclusion of libxl_osdeps.h
  xl: use <> variant to include Xen tools library headers
  xl: generate _paths.h
  xl: remove trailing spaces in xl_cmdimpl.c
  xl: lift a bunch of macros to xl_utils.h
  xl: move some helper functions to xl_utils.c
  xl: split out tmem related code to xl_tmem.c
  xl: split out xl_parse.[ch]
  xl: split out cpupool related code
  xl: split out flask related code
  xl: split out vtpm related code
  xl: split out block related code
  xl: split out network related code
  xl: split out usb related code
  xl: split out scheduler related code
  xl: split out pci related code
  xl: split out vcpu related code
  xl: split out cd related code
  xl: split out memory related code
  xl: split out psr related code
  xl: split out functions to print out information
  xl: split out vnc and console related code
  xl: split out miscellaneous functions
  xl: split out vm lifecycle control functions
  xl: split out save/restore related code
  xl: split out migration related code
  xl: merge xl_cmdimpl.c into xl.c

 .gitignore                |    1 +
 tools/xl/Makefile         |   19 +-
 tools/xl/xl.c             |   70 +-
 tools/xl/xl.h             |   77 +-
 tools/xl/xl_block.c       |  129 +
 tools/xl/xl_cd.c          |  114 +
 tools/xl/xl_cmdimpl.c     | 9642 ---------------------------------------------
 tools/xl/xl_cmdtable.c    |    4 +-
 tools/xl/xl_console.c     |  130 +
 tools/xl/xl_cpupool.c     |  624 +++
 tools/xl/xl_flask.c       |  153 +
 tools/xl/xl_info.c        |  925 +++++
 tools/xl/xl_mem.c         |  167 +
 tools/xl/xl_migrate.c     |  754 ++++
 tools/xl/xl_misc.c        |  355 ++
 tools/xl/xl_nic.c         |  172 +
 tools/xl/xl_parse.c       | 2052 ++++++++++
 tools/xl/xl_parse.h       |   65 +
 tools/xl/xl_pci.c         |  278 ++
 tools/xl/xl_psr.c         |  567 +++
 tools/xl/xl_saverestore.c |  273 ++
 tools/xl/xl_sched.c       |  888 +++++
 tools/xl/xl_sxp.c         |   10 +-
 tools/xl/xl_tmem.c        |  251 ++
 tools/xl/xl_usb.c         |  222 ++
 tools/xl/xl_utils.c       |  328 ++
 tools/xl/xl_utils.h       |  157 +
 tools/xl/xl_vcpu.c        |  337 ++
 tools/xl/xl_vmcontrol.c   | 1225 ++++++
 tools/xl/xl_vtpm.c        |  153 +
 30 files changed, 10474 insertions(+), 9668 deletions(-)
 create mode 100644 tools/xl/xl_block.c
 create mode 100644 tools/xl/xl_cd.c
 delete mode 100644 tools/xl/xl_cmdimpl.c
 create mode 100644 tools/xl/xl_console.c
 create mode 100644 tools/xl/xl_cpupool.c
 create mode 100644 tools/xl/xl_flask.c
 create mode 100644 tools/xl/xl_info.c
 create mode 100644 tools/xl/xl_mem.c
 create mode 100644 tools/xl/xl_migrate.c
 create mode 100644 tools/xl/xl_misc.c
 create mode 100644 tools/xl/xl_nic.c
 create mode 100644 tools/xl/xl_parse.c
 create mode 100644 tools/xl/xl_parse.h
 create mode 100644 tools/xl/xl_pci.c
 create mode 100644 tools/xl/xl_psr.c
 create mode 100644 tools/xl/xl_saverestore.c
 create mode 100644 tools/xl/xl_sched.c
 create mode 100644 tools/xl/xl_tmem.c
 create mode 100644 tools/xl/xl_usb.c
 create mode 100644 tools/xl/xl_utils.c
 create mode 100644 tools/xl/xl_utils.h
 create mode 100644 tools/xl/xl_vcpu.c
 create mode 100644 tools/xl/xl_vmcontrol.c
 create mode 100644 tools/xl/xl_vtpm.c

-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

             reply	other threads:[~2017-02-24 16:13 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24 16:12 Wei Liu [this message]
2017-02-24 16:12 ` [PATCH 01/29] xl: remove accidentally committed hunk from Makefile Wei Liu
2017-02-27 15:53   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 02/29] xl: update copyright information Wei Liu
2017-02-27 15:54   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 03/29] xl: remove inclusion of libxl_osdeps.h Wei Liu
2017-02-27 15:53   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 04/29] xl: use <> variant to include Xen tools library headers Wei Liu
2017-02-27 15:54   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 05/29] xl: generate _paths.h Wei Liu
2017-02-27 15:54   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 06/29] xl: remove trailing spaces in xl_cmdimpl.c Wei Liu
2017-02-27 15:54   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 07/29] xl: lift a bunch of macros to xl_utils.h Wei Liu
2017-02-27 15:54   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 08/29] xl: move some helper functions to xl_utils.c Wei Liu
2017-02-27 15:53   ` Ian Jackson
2017-02-27 17:44     ` [PATCH] " Wei Liu
2017-02-28 10:32       ` Ian Jackson
2017-02-24 16:12 ` [PATCH 09/29] xl: split out tmem related code to xl_tmem.c Wei Liu
2017-02-27 15:54   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 10/29] xl: split out xl_parse.[ch] Wei Liu
2017-02-27 15:57   ` Ian Jackson
2017-02-27 17:47     ` [PATCH 1/3] xl: rename cpurange_parse to parse_cpurange Wei Liu
2017-02-27 17:47       ` [PATCH 2/3] xl: introduce a function to get shutdown action name Wei Liu
2017-02-27 18:11         ` Ian Jackson
2017-02-27 17:47       ` [PATCH 3/3] xl: split out xl_parse.[ch] Wei Liu
2017-02-27 18:11         ` Ian Jackson
2017-02-27 18:11       ` [PATCH 1/3] xl: rename cpurange_parse to parse_cpurange Ian Jackson
2017-02-24 16:12 ` [PATCH 11/29] xl: split out cpupool related code Wei Liu
2017-02-27 15:59   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 12/29] xl: split out flask " Wei Liu
2017-02-27 16:01   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 13/29] xl: split out vtpm " Wei Liu
2017-02-27 15:55   ` Ian Jackson
2017-02-24 16:12 ` [PATCH 14/29] xl: split out block " Wei Liu
2017-02-27 15:58   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 15/29] xl: split out network " Wei Liu
2017-02-27 16:01   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 16/29] xl: split out usb " Wei Liu
2017-02-27 16:00   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 17/29] xl: split out scheduler " Wei Liu
2017-02-27 15:57   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 18/29] xl: split out pci " Wei Liu
2017-02-27 16:01   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 19/29] xl: split out vcpu " Wei Liu
2017-02-27 15:59   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 20/29] xl: split out cd " Wei Liu
2017-02-27 15:56   ` Ian Jackson
2017-02-27 16:23     ` Wei Liu
2017-02-27 16:36       ` Ian Jackson
2017-02-27 16:38         ` Wei Liu
2017-02-27 16:44           ` Ian Jackson
2017-02-27 16:45             ` Wei Liu
2017-02-24 16:13 ` [PATCH 21/29] xl: split out memory " Wei Liu
2017-02-27 16:01   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 22/29] xl: split out psr " Wei Liu
2017-02-27 15:55   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 23/29] xl: split out functions to print out information Wei Liu
2017-02-27 16:00   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 24/29] xl: split out vnc and console related code Wei Liu
2017-02-27 15:59   ` Ian Jackson
2017-02-27 17:48     ` [PATCH 1/2] xl: call libxl_vncviewer_exec in main_vncviewer Wei Liu
2017-02-27 17:48       ` [PATCH 2/2] xl: split out vnc and console related code Wei Liu
2017-02-27 18:13         ` Ian Jackson
2017-02-27 18:12       ` [PATCH 1/2] xl: call libxl_vncviewer_exec in main_vncviewer Ian Jackson
2017-02-24 16:13 ` [PATCH 25/29] xl: split out miscellaneous functions Wei Liu
2017-02-27 15:58   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 26/29] xl: split out vm lifecycle control functions Wei Liu
2017-02-27 16:00   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 27/29] xl: split out save/restore related code Wei Liu
2017-02-27 16:01   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 28/29] xl: split out migration " Wei Liu
2017-02-27 15:59   ` Ian Jackson
2017-02-24 16:13 ` [PATCH 29/29] xl: merge xl_cmdimpl.c into xl.c Wei Liu
2017-02-27 15:58   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170224161314.22154-1-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.