From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Wajdeczko Subject: Re: [PATCH 08/10] drm/i915/uc: Simplify firmware path handling Date: Fri, 24 Feb 2017 18:46:02 +0100 Message-ID: <20170224174602.GE103056@mwajdecz-MOBL1.ger.corp.intel.com> References: <20170224154004.17821-1-arkadiusz.hiler@intel.com> <20170224154004.17821-9-arkadiusz.hiler@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1390B6E191 for ; Fri, 24 Feb 2017 17:46:06 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170224154004.17821-9-arkadiusz.hiler@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Arkadiusz Hiler Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBGZWIgMjQsIDIwMTcgYXQgMDQ6NDA6MDJQTSArMDEwMCwgQXJrYWRpdXN6IEhpbGVy IHdyb3RlOgo+IEN1cnJlbnRseSBmdy0+cGF0aCB2YWx1ZXMgY2FuIHJlcHJlc2VudCBvbmUgb2Yg dGhyZWUgcG9zc2libGUgc3RhdGVzOgo+IAo+ICAxKSBOVUxMIC0gZGV2aWNlIHdpdGhvdXQgdGhl IHVDCj4gIDIpICdcMCcgLSBkZXZpY2Ugd2l0aCB0aGUgdUMgYnV0IGhhdmUgbm8gZmlybXdhcmUK PiAgMykgZWxzZSAtIGRldmljZSB3aXRoIHRoZSB1QyBhbmQgd2UgaGF2ZSBmaXJtd2FyZQo+IAo+ IFNlY29uZCBjYXNlIGlzIHVzZWQgb25seSB0byBXQVJOIGF0IGEgbGF0ZXIgc3RhZ2UuCj4gCj4g V2UgY2FuIFdBUk4gcmlnaHQgYXdheSBhbmQgbWVyZ2UgY2FzZXMgMSBhbmQgMi4KPiAKPiBDb2Rl IGNhbiBiZSBldmVuIGZ1cnRoZXIgc2ltcGxpZmllZCBhbmQgY29tbW9uIChIdUMvR3VDIGxvZ2lj KSBoYXBwZW5pbmcKPiByaWdodCBiZWZvcmUgdGhlIGZldGNoIGNhbiBiZSBvZmZsb2FkZWQgdG8g dGhlIGNvbW1vbiBmdW5jdGlvbi4KPiAKPiB2MjogZmV3ZXIgdGVtcG9yYXJ5IHZhcmlhYmxlcywg bW9yZSBzdHJhaWdodGZvcndhcmQgZmxvdyAoTS4gV2FqZGVjemtvKQo+IHYzOiBEUk1fRVJST1Ig aW5zdGVhZCBvZiBXQVJOIChNLiBXYWpkZWN6a28pCj4gdjQ6IGNvZGluZyBzdGFuZGFyZCAoSi4g TGFodGluZW4pCj4gCj4gQ2M6IEFudXNoYSBTcml2YXRzYSA8YW51c2hhLnNyaXZhdHNhQGludGVs LmNvbT4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBD YzogTWljaGFsIFdpbmlhcnNraSA8bWljaGFsLndpbmlhcnNraUBpbnRlbC5jb20+Cj4gQ2M6IE1p Y2hhbCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+IENjOiBKb29uYXMg TGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1i eTogQXJrYWRpdXN6IEhpbGVyIDxhcmthZGl1c3ouaGlsZXJAaW50ZWwuY29tPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMgfCAzOSArKysrKysrKysrKy0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaHVjLmMg ICAgICAgIHwgMjAgKysrKystLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfdWMuYyAgICAgICAgIHwgIDQgKysrLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlv bnMoKyksIDQxIGRlbGV0aW9ucygtKQo+IAoKPHNuaXA+Cgo+IEBAIC00ODMsMzkgKzQ3OCwzMSBA QCBpbnQgaW50ZWxfZ3VjX2luaXRfaHcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICB2b2lkIGludGVsX2d1Y19pbml0X2Z3KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgewo+ ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZ3VjX3RvX2k5MTUoZ3VjKTsK PiAtCWNvbnN0IGNoYXIgKmZ3X3BhdGg7Cj4gIAo+IC0JaWYgKCFIQVNfR1VDX1VDT0RFKGRldl9w cml2KSkgewo+IC0JCWZ3X3BhdGggPSBOVUxMOwo+IC0JfSBlbHNlIGlmIChJU19TS1lMQUtFKGRl dl9wcml2KSkgewo+IC0JCWZ3X3BhdGggPSBJOTE1X1NLTF9HVUNfVUNPREU7Cj4gKwlndWMtPmZ3 LnBhdGggPSBOVUxMOwo+ICsJZ3VjLT5mdy5mZXRjaF9zdGF0dXMgPSBJTlRFTF9VQ19GSVJNV0FS RV9OT05FOwo+ICsJZ3VjLT5mdy5sb2FkX3N0YXR1cyA9IElOVEVMX1VDX0ZJUk1XQVJFX05PTkU7 Cj4gKwlndWMtPmZ3LmZ3ID0gSU5URUxfVUNfRldfVFlQRV9HVUM7Cj4gKwo+ICsJaWYgKElTX1NL WUxBS0UoZGV2X3ByaXYpKSB7Cj4gKwkJZ3VjLT5mdy5wYXRoID0gSTkxNV9TS0xfR1VDX1VDT0RF Owo+ICAJCWd1Yy0+ZncubWFqb3JfdmVyX3dhbnRlZCA9IFNLTF9GV19NQUpPUjsKPiAgCQlndWMt PmZ3Lm1pbm9yX3Zlcl93YW50ZWQgPSBTS0xfRldfTUlOT1I7Cj4gIAl9IGVsc2UgaWYgKElTX0JS T1hUT04oZGV2X3ByaXYpKSB7Cj4gLQkJZndfcGF0aCA9IEk5MTVfQlhUX0dVQ19VQ09ERTsKPiAr CQlndWMtPmZ3LnBhdGggPSBJOTE1X0JYVF9HVUNfVUNPREU7Cj4gIAkJZ3VjLT5mdy5tYWpvcl92 ZXJfd2FudGVkID0gQlhUX0ZXX01BSk9SOwo+ICAJCWd1Yy0+ZncubWlub3JfdmVyX3dhbnRlZCA9 IEJYVF9GV19NSU5PUjsKPiAgCX0gZWxzZSBpZiAoSVNfS0FCWUxBS0UoZGV2X3ByaXYpKSB7Cj4g LQkJZndfcGF0aCA9IEk5MTVfS0JMX0dVQ19VQ09ERTsKPiArCQlndWMtPmZ3LnBhdGggPSBJOTE1 X0tCTF9HVUNfVUNPREU7Cj4gIAkJZ3VjLT5mdy5tYWpvcl92ZXJfd2FudGVkID0gS0JMX0ZXX01B Sk9SOwo+ICAJCWd1Yy0+ZncubWlub3JfdmVyX3dhbnRlZCA9IEtCTF9GV19NSU5PUjsKPiAgCX0g ZWxzZSB7Cj4gLQkJZndfcGF0aCA9ICIiOwkvKiB1bmtub3duIGRldmljZSAqLwo+ICsJCURSTV9F UlJPUigiTm8gR3VDIGZpcm13YXJlIGtub3duIGZvciBwbGF0Zm9ybSB3aXRoIEd1QyFcbiIpOwo+ ICsJCWk5MTUuZW5hYmxlX2d1Y19sb2FkaW5nID0gMDsKCkhtbSwgSSBkb24ndCBsaWtlIHRoYXQg d2UncmUgbW9kaWZ5aW5nIHBhcmFtIG91dHNpZGUgb2YgaW50ZWxfdWNfc2FuaXRpemVfb3B0aW9u cygpCklmIHdlIHNwbGl0IHRoaXMgZnVuY3Rpb24gaW50byBmdyBmaWxlbmFtZSBzZWxlY3Rpb24g YW5kIGFjdHVhbCBwcmVwYXJlL2ZldGNoIHRoZW4Kd2UgY291bGQgZG8gdGhpcyBmdyBpbml0aWFs IHNhbml0aXphdGlvbiBpbiBwcm9wZXIgcGxhY2UgYXM6CgoJaTkxNS5lbmFibGVfZ3VjX2xvYWRp bmcgPSBpbnRlbF9zYW5pdGl6ZV9ndWNfZncoZGV2X3ByaXYpOwoKCj4gKwkJcmV0dXJuOwo+ICAJ fQo+ICAKPiAtCWd1Yy0+ZncucGF0aCA9IGZ3X3BhdGg7Cj4gLQlndWMtPmZ3LmZldGNoX3N0YXR1 cyA9IElOVEVMX1VDX0ZJUk1XQVJFX05PTkU7Cj4gLQlndWMtPmZ3LmxvYWRfc3RhdHVzID0gSU5U RUxfVUNfRklSTVdBUkVfTk9ORTsKPiAtCj4gLQlpZiAoZndfcGF0aCA9PSBOVUxMKQo+IC0JCXJl dHVybjsKPiAtCWlmICgqZndfcGF0aCA9PSAnXDAnKQo+IC0JCXJldHVybjsKPiAtCj4gLQlndWMt PmZ3LmZldGNoX3N0YXR1cyA9IElOVEVMX1VDX0ZJUk1XQVJFX1BFTkRJTkc7Cj4gLQlEUk1fREVC VUdfRFJJVkVSKCJHdUMgZmlybXdhcmUgcGVuZGluZywgcGF0aCAlc1xuIiwgZndfcGF0aCk7Cj4g IAlpbnRlbF91Y19wcmVwYXJlX2Z3KGRldl9wcml2LCAmZ3VjLT5mdyk7Cj4gLQkvKiBzdGF0dXMg bXVzdCBub3cgYmUgRkFJTCBvciBTVUNDRVNTICovCj4gIH0KPiAgCj4gIC8qKgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9odWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2h1Yy5jCj4gaW5kZXggNmYwODExYy4uNzU3ZjYxOCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9odWMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2h1Yy5jCj4gQEAgLTE1NSwzNyArMTU1LDI5IEBAIHN0YXRpYyBpbnQgaHVjX3Vj b2RlX3hmZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB2b2lkIGludGVs X2h1Y19pbml0X2Z3KHN0cnVjdCBpbnRlbF9odWMgKmh1YykKPiAgewo+ICAJc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2ID0gaHVjX3RvX2k5MTUoaHVjKTsKPiAtCWNvbnN0IGNoYXIg KmZ3X3BhdGggPSBOVUxMOwo+ICAKPiAgCWh1Yy0+ZncucGF0aCA9IE5VTEw7Cj4gIAlodWMtPmZ3 LmZldGNoX3N0YXR1cyA9IElOVEVMX1VDX0ZJUk1XQVJFX05PTkU7Cj4gIAlodWMtPmZ3LmxvYWRf c3RhdHVzID0gSU5URUxfVUNfRklSTVdBUkVfTk9ORTsKPiAgCWh1Yy0+ZncuZncgPSBJTlRFTF9V Q19GV19UWVBFX0hVQzsKPiAgCj4gLQlpZiAoIUhBU19IVUNfVUNPREUoZGV2X3ByaXYpKQo+IC0J CXJldHVybjsKPiAtCj4gIAlpZiAoSVNfU0tZTEFLRShkZXZfcHJpdikpIHsKPiAtCQlmd19wYXRo ID0gSTkxNV9TS0xfSFVDX1VDT0RFOwo+ICsJCWh1Yy0+ZncucGF0aCA9IEk5MTVfU0tMX0hVQ19V Q09ERTsKPiAgCQlodWMtPmZ3Lm1ham9yX3Zlcl93YW50ZWQgPSBTS0xfSFVDX0ZXX01BSk9SOwo+ ICAJCWh1Yy0+ZncubWlub3JfdmVyX3dhbnRlZCA9IFNLTF9IVUNfRldfTUlOT1I7Cj4gIAl9IGVs c2UgaWYgKElTX0JST1hUT04oZGV2X3ByaXYpKSB7Cj4gLQkJZndfcGF0aCA9IEk5MTVfQlhUX0hV Q19VQ09ERTsKPiArCQlodWMtPmZ3LnBhdGggPSBJOTE1X0JYVF9IVUNfVUNPREU7Cj4gIAkJaHVj LT5mdy5tYWpvcl92ZXJfd2FudGVkID0gQlhUX0hVQ19GV19NQUpPUjsKPiAgCQlodWMtPmZ3Lm1p bm9yX3Zlcl93YW50ZWQgPSBCWFRfSFVDX0ZXX01JTk9SOwo+ICAJfSBlbHNlIGlmIChJU19LQUJZ TEFLRShkZXZfcHJpdikpIHsKPiAtCQlmd19wYXRoID0gSTkxNV9LQkxfSFVDX1VDT0RFOwo+ICsJ CWh1Yy0+ZncucGF0aCA9IEk5MTVfS0JMX0hVQ19VQ09ERTsKPiAgCQlodWMtPmZ3Lm1ham9yX3Zl cl93YW50ZWQgPSBLQkxfSFVDX0ZXX01BSk9SOwo+ICAJCWh1Yy0+ZncubWlub3JfdmVyX3dhbnRl ZCA9IEtCTF9IVUNfRldfTUlOT1I7Cj4gKwl9IGVsc2Ugewo+ICsJCURSTV9FUlJPUigiTm8gSHVD IGZpcm13YXJlIGtub3duIGZvciBwbGF0Zm9ybSB3aXRoIEh1QyFcbiIpOwo+ICsJCXJldHVybjsK PiAgCX0KPiAgCj4gLQlodWMtPmZ3LnBhdGggPSBmd19wYXRoOwo+IC0JaHVjLT5mdy5mZXRjaF9z dGF0dXMgPSBJTlRFTF9VQ19GSVJNV0FSRV9QRU5ESU5HOwo+IC0KPiAtCURSTV9ERUJVR19EUklW RVIoIkh1QyBmaXJtd2FyZSBwZW5kaW5nLCBwYXRoICVzXG4iLCBmd19wYXRoKTsKPiAtCj4gLQlX QVJOKGh1Yy0+ZncucGF0aCA9PSBOVUxMLCAiSHVDIHByZXNlbnQgYnV0IG5vIGZ3IHBhdGhcbiIp Owo+IC0KPiAgCWludGVsX3VjX3ByZXBhcmVfZncoZGV2X3ByaXYsICZodWMtPmZ3KTsKPiAgfQo+ ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMKPiBpbmRleCA3MDlmOTY0Li5hYzlhZDU5IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4gQEAgLTI2Nyw4ICsyNjcsMTAgQEAgdm9pZCBpbnRl bF91Y19wcmVwYXJlX2Z3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCXNp emVfdCBzaXplOwo+ICAJaW50IGVycjsKPiAgCj4gKwl1Y19mdy0+ZmV0Y2hfc3RhdHVzID0gSU5U RUxfVUNfRklSTVdBUkVfUEVORElORzsKPiArCj4gIAlEUk1fREVCVUdfRFJJVkVSKCJiZWZvcmUg cmVxdWVzdGluZyBmaXJtd2FyZTogdUMgZncgZmV0Y2ggc3RhdHVzICVzXG4iLAo+IC0JCWludGVs X3VjX2Z3X3N0YXR1c19yZXByKHVjX2Z3LT5mZXRjaF9zdGF0dXMpKTsKPiArCQkJIGludGVsX3Vj X2Z3X3N0YXR1c19yZXByKHVjX2Z3LT5mZXRjaF9zdGF0dXMpKTsKPiAgCj4gIAllcnIgPSByZXF1 ZXN0X2Zpcm13YXJlKCZmdywgdWNfZnctPnBhdGgsICZwZGV2LT5kZXYpOwo+ICAJaWYgKGVycikK CgpJIHRoaW5rIHByZXZpb3VzIHBhdGNoZXMgd2lsbCBsb29rIHNpbXBsZXIgaWYgeW91IHN0YXJ0 IHdpdGggdGhpcyBwYXRjaCBlYXJsaWVyLgpUaGlzIG1vdmUgd2lsbCBhbHNvIGFkZHJlc3Mgc29t ZSBwcmV2aW91c2x5IHBvc3RlZCBjb21tZW50cy4KCi1NaWNoYWwKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==