From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751902AbdB0P2G (ORCPT ); Mon, 27 Feb 2017 10:28:06 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:35760 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbdB0P2D (ORCPT ); Mon, 27 Feb 2017 10:28:03 -0500 Date: Mon, 27 Feb 2017 08:29:48 -0600 From: Rob Herring To: Fabrice Gasnier Cc: Jonathan Cameron , linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, mark.rutland@arm.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, lars@metafoo.de, knaack.h@gmx.de, pmeerw@pmeerw.net Subject: Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set resolution Message-ID: <20170227142948.eejne6j42lkzsiyq@rob-hp-laptop> References: <1487177757-19427-1-git-send-email-fabrice.gasnier@st.com> <1487177757-19427-2-git-send-email-fabrice.gasnier@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 24, 2017 at 05:04:45PM +0100, Fabrice Gasnier wrote: > On 02/19/2017 01:09 PM, Jonathan Cameron wrote: > > On 15/02/17 16:55, Fabrice Gasnier wrote: > > > Add documentation for 'st,adc-res' dt optional property. > > > > > > Signed-off-by: Fabrice Gasnier > > I'm happy with this, but would like to leave time for a device tree review. > > > > Ultimately we may well want to make this a generic property and call it something > > like adc-resolution but perhaps we need to wait until we have a few more devices > > supporting setting it via device tree to figure out what the best interface is. > > It would exactly be a problem to support this as a deprecated binding at that > > point. > > Hi Jonathan, > > I agree with you on this... It may be better to have generic property > for this, especially if you see that it will come in the near future. > May I suggest this prop to be less restrictive, e.g. like resolution-bits as > is may also be worth for other device types, e.g. DAC as an example ? Yes, please make this a commmon property. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set resolution Date: Mon, 27 Feb 2017 08:29:48 -0600 Message-ID: <20170227142948.eejne6j42lkzsiyq@rob-hp-laptop> References: <1487177757-19427-1-git-send-email-fabrice.gasnier@st.com> <1487177757-19427-2-git-send-email-fabrice.gasnier@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Fabrice Gasnier Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, lars@metafoo.de, alexandre.torgue@st.com, linux-iio@vger.kernel.org, pmeerw@pmeerw.net, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, Jonathan Cameron , mcoquelin.stm32@gmail.com, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Fri, Feb 24, 2017 at 05:04:45PM +0100, Fabrice Gasnier wrote: > On 02/19/2017 01:09 PM, Jonathan Cameron wrote: > > On 15/02/17 16:55, Fabrice Gasnier wrote: > > > Add documentation for 'st,adc-res' dt optional property. > > > > > > Signed-off-by: Fabrice Gasnier > > I'm happy with this, but would like to leave time for a device tree review. > > > > Ultimately we may well want to make this a generic property and call it something > > like adc-resolution but perhaps we need to wait until we have a few more devices > > supporting setting it via device tree to figure out what the best interface is. > > It would exactly be a problem to support this as a deprecated binding at that > > point. > > Hi Jonathan, > > I agree with you on this... It may be better to have generic property > for this, especially if you see that it will come in the near future. > May I suggest this prop to be less restrictive, e.g. like resolution-bits as > is may also be worth for other device types, e.g. DAC as an example ? Yes, please make this a commmon property. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Mon, 27 Feb 2017 08:29:48 -0600 Subject: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set resolution In-Reply-To: References: <1487177757-19427-1-git-send-email-fabrice.gasnier@st.com> <1487177757-19427-2-git-send-email-fabrice.gasnier@st.com> Message-ID: <20170227142948.eejne6j42lkzsiyq@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 24, 2017 at 05:04:45PM +0100, Fabrice Gasnier wrote: > On 02/19/2017 01:09 PM, Jonathan Cameron wrote: > > On 15/02/17 16:55, Fabrice Gasnier wrote: > > > Add documentation for 'st,adc-res' dt optional property. > > > > > > Signed-off-by: Fabrice Gasnier > > I'm happy with this, but would like to leave time for a device tree review. > > > > Ultimately we may well want to make this a generic property and call it something > > like adc-resolution but perhaps we need to wait until we have a few more devices > > supporting setting it via device tree to figure out what the best interface is. > > It would exactly be a problem to support this as a deprecated binding at that > > point. > > Hi Jonathan, > > I agree with you on this... It may be better to have generic property > for this, especially if you see that it will come in the near future. > May I suggest this prop to be less restrictive, e.g. like resolution-bits as > is may also be worth for other device types, e.g. DAC as an example ? Yes, please make this a commmon property. Rob