From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbdB0PgA (ORCPT ); Mon, 27 Feb 2017 10:36:00 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:59208 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548AbdB0PfN (ORCPT ); Mon, 27 Feb 2017 10:35:13 -0500 Date: Mon, 27 Feb 2017 15:34:54 +0100 From: Sebastian Sewior To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Ingo Molnar , Mike Galbraith , Dan Murphy Subject: [PATCH] lockdep: Fix compilation error for !CONFIG_MODULES and !CONFIG_SMP Message-ID: <20170227143454.r6rdk27jqmjmjjpz@linutronix.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Murphy When CONFIG_MODULES is not set then it fails to compile in lockdep: |kernel/locking/lockdep.c: In function 'look_up_lock_class': |kernel/locking/lockdep.c:684:12: error: implicit declaration of function | '__is_module_percpu_address' [-Werror=implicit-function-declaration] If CONFIG_MODULES is set but CONFIG_SMP is not, then it compiles but fails link at the end: |kernel/locking/lockdep.c:684: undefined reference to `__is_module_percpu_address' |kernel/built-in.o:(.debug_addr+0x1e674): undefined reference to `__is_module_percpu_address' This patch adds the function for both cases. Signed-off-by: Dan Murphy [bigeasy: merge the two patches from Dan into one, adapt changelog] Signed-off-by: Sebastian Andrzej Siewior --- include/linux/module.h | 5 +++++ kernel/module.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/include/linux/module.h b/include/linux/module.h index 2d209ecbfde1..ec5c4e63201a 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -664,6 +664,11 @@ static inline bool is_module_percpu_address(unsigned long addr) return false; } +static inline bool __is_module_percpu_address(unsigned long addr, unsigned long *can_addr) +{ + return false; +} + static inline bool is_module_text_address(unsigned long addr) { return false; diff --git a/kernel/module.c b/kernel/module.c index 0bbfcf69760c..b54cb4fbbcad 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -737,6 +737,11 @@ bool is_module_percpu_address(unsigned long addr) return false; } +bool __is_module_percpu_address(unsigned long addr, unsigned long *can_addr) +{ + return false; +} + #endif /* CONFIG_SMP */ #define MODINFO_ATTR(field) \ -- 2.11.0