From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3 net] net: solve a NAPI race
Date: Mon, 27 Feb 2017 15:23:15 -0800 [thread overview]
Message-ID: <20170227152315.7e3b284f@xeon-e3> (raw)
In-Reply-To: <20170227.174854.1727197935165904806.davem@davemloft.net>
On Mon, 27 Feb 2017 17:48:54 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> Date: Mon, 27 Feb 2017 14:44:55 -0800
>
> > On Mon, 27 Feb 2017 14:35:17 -0800
> > Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >
> >> On Mon, 2017-02-27 at 14:14 -0800, Stephen Hemminger wrote:
> >>
> >> > The original design (as Davem mentioned) was that IRQ's must be disabled
> >> > during device polling. If that was true, then the race above
> >> > would be impossible.
> >>
> >> I would love to see an alternative patch.
> >
> > Turn off busy poll?
> > The poll stuff runs risk of breaking more things.
>
> Eric is exactly trying to make busy poll even more prominent in
> the stack, not less prominent.
>
> It's an important component of some performance improvements he is
> working on.
Maybe making IRQ controlled as part of the network device model
(instead of a side effect left to device driver to handle) would
be less problematic.
Really just shooting in the dark because I don't have any of the problematic
hardware to play with.
next prev parent reply other threads:[~2017-02-28 1:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 14:22 [PATCH net] net/mlx4_en: reception NAPI/IRQ race breaker Eric Dumazet
2017-02-26 16:32 ` Saeed Mahameed
2017-02-26 17:34 ` Eric Dumazet
2017-02-26 17:40 ` Eric Dumazet
2017-02-26 18:03 ` Eric Dumazet
2017-02-27 3:31 ` [PATCH net] net: solve a NAPI race Eric Dumazet
2017-02-27 14:06 ` Eric Dumazet
2017-02-27 14:21 ` [PATCH v2 " Eric Dumazet
2017-02-27 16:19 ` David Miller
2017-02-27 16:44 ` Eric Dumazet
2017-02-27 17:10 ` Eric Dumazet
2017-02-28 2:08 ` David Miller
2017-03-01 0:22 ` Francois Romieu
2017-03-01 1:04 ` Stephen Hemminger
2017-02-27 21:00 ` Alexander Duyck
2017-02-27 20:18 ` [PATCH v3 " Eric Dumazet
2017-02-27 22:14 ` Stephen Hemminger
2017-02-27 22:35 ` Eric Dumazet
2017-02-27 22:44 ` Stephen Hemminger
2017-02-27 22:48 ` David Miller
2017-02-27 23:23 ` Stephen Hemminger [this message]
2017-02-28 10:14 ` David Laight
2017-02-28 13:04 ` Eric Dumazet
2017-02-28 13:20 ` Eric Dumazet
2017-02-28 16:17 ` Stephen Hemminger
2017-02-28 16:57 ` Eric Dumazet
2017-02-28 18:34 ` [PATCH v4 " Eric Dumazet
2017-03-01 17:53 ` David Miller
2017-02-28 17:20 ` [PATCH v2 " Alexander Duyck
2017-02-28 17:47 ` Eric Dumazet
2017-03-01 10:41 ` David Laight
2017-03-01 16:14 ` Alexander Duyck
2017-03-01 17:32 ` Eric Dumazet
2017-03-02 10:24 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227152315.7e3b284f@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.