From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Subject: Re: [PATCH 07/10] drm/i915/guc: Simplify
	intel_guc_init_hw()
Date: Mon, 27 Feb 2017 16:48:37 +0100
Message-ID: <20170227154837.GA1444@ahiler-desk.igk.intel.com>
References: <20170224154004.17821-1-arkadiusz.hiler@intel.com>
 <20170224154004.17821-8-arkadiusz.hiler@intel.com>
 <20170224172610.GD103056@mwajdecz-MOBL1.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 237706E511
 for <intel-gfx@lists.freedesktop.org>; Mon, 27 Feb 2017 15:48:46 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20170224172610.GD103056@mwajdecz-MOBL1.ger.corp.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBGZWIgMjQsIDIwMTcgYXQgMDY6MjY6MTBQTSArMDEwMCwgTWljaGFsIFdhamRlY3pr
byB3cm90ZToKPiBPbiBGcmksIEZlYiAyNCwgMjAxNyBhdCAwNDo0MDowMVBNICswMTAwLCBBcmth
ZGl1c3ogSGlsZXIgd3JvdGU6Cj4gPiBDdXJyZW50IHZlcnNpb24gb2YgaW50ZWxfZ3VjX2luaXRf
aHcoKSBkb2VzIGEgbG90Ogo+ID4gIC0gY2FyZXMgYWJvdXQgc3VibWlzc2lvbgo+ID4gIC0gbG9h
ZHMgaHVjCj4gPiAgLSBpbXBsZW1lbnQgV0EKPiA+IAo+ID4gVGhpcyBjaGFuZ2Ugb2ZmbG9hZHMg
c29tZSBvZiB0aGUgbG9naWMgdG8gaW50ZWxfdWNfaW5pdF9odygpLCB3aGljaCBub3cKPiA+IGNh
cmVzIGFib3V0IHRoZSBhYm92ZS4KPiA+IAo+ID4gdjI6IHJlbmFtZSBndWNfaHdfcmVzZXQgYW5k
IGZpeCB0eXBvIGluIGRlZmluZSBuYW1lIChNLiBXYWpkZWN6a28pCj4gPiB2MzogcmVuYW1lIG9u
Y2UgYWdhaW4KPiA+IHY0OiByZW1vdmUgc3B1cmlvdXMgY29tbWVudHMgYW5kIGFkZCBzb21lIHN0
eWxlIChKLiBMYWh0aW5lbikKPiA+IAo+ID4gQ2M6IEFudXNoYSBTcml2YXRzYSA8YW51c2hhLnNy
aXZhdHNhQGludGVsLmNvbT4KPiA+IENjOiBNaWNoYWwgV2luaWFyc2tpIDxtaWNoYWwud2luaWFy
c2tpQGludGVsLmNvbT4KPiA+IENjOiBNaWNoYWwgV2FqZGVjemtvIDxtaWNoYWwud2FqZGVjemtv
QGludGVsLmNvbT4KPiA+IENjOiBEYW5pZWxlIENlcmFvbG8gU3B1cmlvIDxkYW5pZWxlLmNlcmFv
bG9zcHVyaW9AaW50ZWwuY29tPgo+ID4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRp
bmVuQGxpbnV4LmludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IEFya2FkaXVzeiBIaWxlciA8
YXJrYWRpdXN6LmhpbGVyQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfZ2VtLmMgICAgICAgICB8ICAgMiArLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX2d1Y19sb2FkZXIuYyB8IDE0NCArKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMgICAgICAgICB8IDExMCArKysr
KysrKysrKysrKysrKysrKysrKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5o
ICAgICAgICAgfCAgIDMgKwo+ID4gIDQgZmlsZXMgY2hhbmdlZCwgMTI4IGluc2VydGlvbnMoKyks
IDEzMSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPiBpbmRl
eCA1YjM2NTI0Li44OTQzYzRlIDEwMDY0NAo+ID4gQEAgLTQ0Myw0MiArNDI1LDI0IEBAIGludCBp
bnRlbF9ndWNfaW5pdF9odyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAg
ewo+IDxTTklQPgo+ID4gLQkvKiBMb2FkaW5nIGZvcmJpZGRlbiwgb3Igbm8gZmlybXdhcmUgdG8g
bG9hZD8gKi8KPiA+IC0JaWYgKCFpOTE1LmVuYWJsZV9ndWNfbG9hZGluZykgewo+ID4gLQkJZXJy
ID0gMDsKPiA+IC0JCWdvdG8gZmFpbDsKPiA+IC0JfSBlbHNlIGlmIChmd19wYXRoID09IE5VTEwp
IHsKPiA+IC0JCS8qIERldmljZSBpcyBrbm93biB0byBoYXZlIG5vIHVDb2RlIChlLmcuIG5vIEd1
QykgKi8KPiA+IC0JCWVyciA9IC1FTlhJTzsKPiA+IC0JCWdvdG8gZmFpbDsKPiA+ICsJaWYgKCFm
d19wYXRoKSB7Cj4gPiArCQlyZXR1cm4gLUVOWElPOwo+ID4gIAl9IGVsc2UgaWYgKCpmd19wYXRo
ID09ICdcMCcpIHsKPiAKPiBIbW0sIGlzIHRoaXMgY2FzZSBzdGlsbCBwb3NzaWJsZT8KCkluIHRo
aXMgcmV2aXNpb24gLSB5ZXMsIGJ1dCB1bmxpa2VseS4KCkhBU19HVUMoKSBpcyB0cnVlIGJ1dCBm
aXJtd2FyZSBmb3IgdGhlIGRldmljZSBpcyBub3Qga25vd24gKHNlZQppbml0X2Z3KCkpLiBJIHRo
aW5rIHRoYXQgdGhlIGluaXRpYWwgZmxvdyB3YXMgZGVzaWduZWQgaW4gdGhpcyBjYXNlIGluCm1p
bmQuCgo+ID4gLQkJLyogRGV2aWNlIGhhcyBhIEd1QyBidXQgd2UgZG9uJ3Qga25vdyB3aGF0IGYv
dyB0byBsb2FkPyAqLwo+ID4gIAkJV0FSTigxLCAiTm8gR3VDIGZpcm13YXJlIGtub3duIGZvciB0
aGlzIHBsYXRmb3JtIVxuIik7Cj4gPiAtCQllcnIgPSAtRU5PREVWOwo+ID4gLQkJZ290byBmYWls
Owo+ID4gKwkJcmV0dXJuIC1FTk9ERVY7Cj4gPiAgCX0KPiA+ICAKPiA+IC0JLyogRmV0Y2ggZmFp
bGVkLCBvciBhbHJlYWR5IGZldGNoZWQgYnV0IGZhaWxlZCB0byBsb2FkPyAqLwo+ID4gLQlpZiAo
Z3VjX2Z3LT5mZXRjaF9zdGF0dXMgIT0gSU5URUxfVUNfRklSTVdBUkVfU1VDQ0VTUykgewo+ID4g
LQkJZXJyID0gLUVJTzsKPiA+IC0JCWdvdG8gZmFpbDsKPiA+IC0JfSBlbHNlIGlmIChndWNfZnct
PmxvYWRfc3RhdHVzID09IElOVEVMX1VDX0ZJUk1XQVJFX0ZBSUwpIHsKPiA+IC0JCWVyciA9IC1F
Tk9FWEVDOwo+ID4gLQkJZ290byBmYWlsOwo+ID4gLQl9Cj4gPiAtCj4gPiAtCWd1Y19pbnRlcnJ1
cHRzX3JlbGVhc2UoZGV2X3ByaXYpOwo+ID4gLQlnZW45X3Jlc2V0X2d1Y19pbnRlcnJ1cHRzKGRl
dl9wcml2KTsKPiA+IC0KPiA+IC0JLyogV2UgbmVlZCB0byBub3RpZnkgdGhlIGd1YyB3aGVuZXZl
ciB3ZSBjaGFuZ2UgdGhlIEdHVFQgKi8KPiA+IC0JaTkxNV9nZ3R0X2VuYWJsZV9ndWMoZGV2X3By
aXYpOwo+ID4gKwlpZiAoZ3VjX2Z3LT5mZXRjaF9zdGF0dXMgIT0gSU5URUxfVUNfRklSTVdBUkVf
U1VDQ0VTUykKPiA+ICsJCXJldHVybiAtRUlPOwo+ID4gKwllbHNlIGlmIChndWNfZnctPmxvYWRf
c3RhdHVzID09IElOVEVMX1VDX0ZJUk1XQVJFX0ZBSUwpCj4gPiArCQlyZXR1cm4gLUVOT0VYRUM7
Cj4gCj4gSG1tLCBpdCBsb29rcyBsaWtlIHlvdSdyZSBjaGVja2luZyBmb3IgbG9hZCBmYWlsdXJl
IGhlcmUsIGJ1dCBhY3R1YWwKPiBsb2FkIGlzIGFib3V0IHRvIHN0YXJ0IGJlbG93ID8gRGlkIEkg
bWlzc2VkIHNvbWV0aGluZyA/CgpUaGUgc3RhdHVzIEZJUk1XQVJFX0ZBSUwgaXMgbm90IHVzZWQg
YXQgYWxsIGluIHRoZSBHdUMgcGF0aCAoSHVDKSB1c2VzCml0LiBOb3RlZCBkb3duIHRvIGdpdmUg
aXQgYSBjbG9zZXIgbG9vay4KClRoZSBjaGVjayBpcyBnb25lLCBhcyBpdCBkb2VzIG5vdCBtYWtl
IHNlbnNlLCB0aGFua3MuCgo+ID4gIAlndWNfZnctPmxvYWRfc3RhdHVzID0gSU5URUxfVUNfRklS
TVdBUkVfUEVORElORzsKPiAKPiBJIGd1ZXNzIHRoaXMgc3RhdHVzIGNhbiBiZSBzZXQgaW4gZ3Vj
X3Vjb2RlX3hmZXIoKSBhcyBpdCB1c2VzIGd1Y19mdyBvYmplY3QuCgo+ID4gIAo+ID4gQEAgLTQ4
NiwxMDQgKzQ1MCwyNCBAQCBpbnQgaW50ZWxfZ3VjX2luaXRfaHcoc3RydWN0IGRybV9pOTE1X3By
aXZhdGUgKmRldl9wcml2KQo+ID4gIAkJaW50ZWxfdWNfZndfc3RhdHVzX3JlcHIoZ3VjX2Z3LT5m
ZXRjaF9zdGF0dXMpLAo+ID4gIAkJaW50ZWxfdWNfZndfc3RhdHVzX3JlcHIoZ3VjX2Z3LT5sb2Fk
X3N0YXR1cykpOwo+ID4gIAo+ID4gLQllcnIgPSBpOTE1X2d1Y19zdWJtaXNzaW9uX2luaXQoZGV2
X3ByaXYpOwo+ID4gLQlpZiAoZXJyKQo+ID4gLQkJZ290byBmYWlsOwo+ID4gLQo+ID4gIAkvKgo+
ID4gIAkgKiBXYUVuYWJsZXVLZXJuZWxIZWFkZXJWYWxpZEZpeDpza2wsYnh0Cj4gPiAgCSAqIEZv
ciBCWFQsIHRoaXMgaXMgb25seSB1cHRvIEIwIGJ1dCBiZWxvdyBXQSBpcyByZXF1aXJlZCBmb3Ig
bGF0ZXIKPiA+ICAJICogc3RlcHBpbmdzIGFsc28gc28gdGhpcyBpcyBleHRlbmRlZCBhcyB3ZWxs
Lgo+ID4gIAkgKi8KPiAKPiBSZWJhc2UgaXNzdWU/CgpZZWFoLiBJJ3ZlIHN0cmVhbWxpbmVkIHRo
ZSB3aG9sZSB0aGluZyB0byBiZToKCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KaW50IGF0dGVtcHRzOwpjb25zdCBpbnQgZ3VjX3dhX2hh
c2hfY2hlY2tfbm90X3NldF9hdHRlbXB0cyA9IDM7Cgo8U05JUD4KCi8qIFdhRW5hYmxldUtlcm5l
bEhlYWRlclZhbGlkRml4OnNrbCAqLwovKiBXYUVuYWJsZUd1Q0Jvb3RIYXNoQ2hlY2tOb3RTZXQ6
c2tsLGJ4dCxrYmwgKi8KaWYgKElTX0dFTjkoZGV2X3ByaXYpKQogICAgICAgIGF0dGVtcHRzID0g
Z3VjX3dhX2hhc2hfY2hlY2tfbm90X3NldF9hdHRlbXB0czsKZWxzZQogICAgICAgIGF0dGVtcHRz
ID0gMTsKCndoaWxlIChhdHRlbXB0cy0tKSAuLi4KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQoKCmFuZCBkcm9wcGVkIHRoZSBXQSBjb21t
ZW50cyBpbiB0aGUgZ3VjX2luaXRfaHcoKQoKCgo+ID4gK2ludCBpbnRlbF91Y19pbml0X2h3KHN0
cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICt7Cj4gPFNOSVA+Cj4gPiArZmFp
bDoKPiA+ICsJLyoKPiA+ICsJICogV2UndmUgZmFpbGVkIHRvIGxvYWQgdGhlIGZpcm13YXJlIDoo
Cj4gPiArCSAqCj4gPiArCSAqIERlY2lkZSB3aGV0aGVyIHRvIGRpc2FibGUgR3VDIHN1Ym1pc3Np
b24gYW5kIGZhbGwgYmFjayB0bwo+ID4gKwkgKiBleGVjbGlzdCBtb2RlLCBhbmQgd2hldGhlciB0
byBoaWRlIHRoZSBlcnJvciBieSByZXR1cm5pbmcKPiA+ICsJICogemVybyBvciB0byByZXR1cm4g
LUVJTywgd2hpY2ggdGhlIGNhbGxlciB3aWxsIHRyZWF0IGFzIGEKPiA+ICsJICogbm9uZmF0YWwg
ZXJyb3IgKGkuZS4gaXQgZG9lc24ndCBwcmV2ZW50IGRyaXZlciBsb2FkLCBidXQKPiA+ICsJICog
bWFya3MgdGhlIEdQVSBhcyB3ZWRnZWQgdW50aWwgcmVzZXQpLgo+ID4gKwkgKi8KPiA+ICsJRFJN
X0VSUk9SKCJHdUMgaW5pdCBmYWlsZWRcbiIpOwo+ID4gKwlpZiAoaTkxNS5lbmFibGVfZ3VjX2xv
YWRpbmcgPiAxIHx8IGk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uID4gMSkKPiAKPiBOb256ZXJv
IGk5MTUuZW5hYmxlX2d1Y19sb2FkaW5nIGlzIGd1YXJhbnRlZWQgKHNlZSB5b3VyIGZpcnN0ICJp
ZiIgaW4gdGhpcyBmdW5jdGlvbikKClRoYXQncyB3aHkgdGhpcyBub3QgYSBjaGVjayBmb3IgIm5v
bi16ZXJvbmVzcyIuCgpJdCdzIGNoZWVraW5nIGZvciAiZ3JlYXRlciB0aGFuIG9uZSIsIGFkaGVy
aW5nIHRvIGV4aXN0aW5nIGJlaGF2aW9yOgogMCAgID0gZGlzYWJsZWQKIDEgICA9IGVuYWJsZWQg
d2l0aCBwb3NzaWJsZSBmYWxsYmFjayAoaS5lLiBpZ25vcmUgdGhlIGVycm9yIGFuZCB1c2UgZXhl
Y2xpc3RzKQogPiAxID0gd2VkZ2UgaWYgdGhpcyBmYWlsCgo+ID4gKy8qIFdhRW5hYmxlR3VDQm9v
dEhhc2hDaGVja05vdFNldDpza2wsYnh0ICovCj4gPiArI2RlZmluZSBHVUNfV0FfSEFTSF9DSEVD
S19OT1RfU0VUX0FUVEVNUFRTIDMKPiA+ICsKPiAKPiBIbW0sIGlzIGl0IHdvcnRoIHRvIGRlZmlu
ZSB0aGlzIG1hY3JvIGhlcmUgYXMgaXQgaXMgdXNlZCBvbmx5IG9uY2UgYW5kCj4gaXQgaXMgdmVy
eSBzcGVjaWZpYyA/IERvIHlvdSBwbGFuIHRvIGRlZmluZSBtb3JlIHNpbWlsYXIgbWFjcm9zPwoK
Q2hhbmdlZCB0byBjb25zdCwgYnV0IGk5MTUgc2VlbXMgdG8gYmUgZ2VuZXJhbGx5IGRlZmluZS1i
aWFzZWQgZm9yCnNpbWlsYXIgdGhpbmdzLgoKLS0gCkNoZWVycywKQXJlawpfX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0
CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv
cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK