From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751605AbdB0RRA (ORCPT ); Mon, 27 Feb 2017 12:17:00 -0500 Received: from mail-ot0-f196.google.com ([74.125.82.196]:33261 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdB0RQ0 (ORCPT ); Mon, 27 Feb 2017 12:16:26 -0500 Date: Mon, 27 Feb 2017 10:40:54 -0600 From: Rob Herring To: Kishon Vijay Abraham I Cc: Bjorn Helgaas , Jingoo Han , Joao Pinto , linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nsekhar@ti.com Subject: Re: [PATCH v2 14/22] dt-bindings: PCI: dra7xx: Add dt bindings to enable legacy mode Message-ID: <20170227164054.xcubjpaf2qx3pxol@rob-hp-laptop> References: <1487325042-28227-1-git-send-email-kishon@ti.com> <1487325042-28227-15-git-send-email-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487325042-28227-15-git-send-email-kishon@ti.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2017 at 03:20:34PM +0530, Kishon Vijay Abraham I wrote: > Update device tree binding documentation of TI's dra7xx PCI > controller to include property for enabling legacy mode. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/pci/ti-pci.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt > index 190828a..72ebe2b 100644 > --- a/Documentation/devicetree/bindings/pci/ti-pci.txt > +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt > @@ -39,6 +39,10 @@ DEVICE MODE > - interrupts : one interrupt entries must be specified for main interrupt. > - num-ib-windows : number of inbound address translation windows > - num-ob-windows : number of outbound address translation windows > + - syscon-legacy-mode: phandle to the syscon dt node. The 1st argument should > + contain the register offset within syscon and the 2nd > + argument should contain the bit field for setting the > + legacy mode Vendor prefix needed and what does "legacy mode" mean? Perhaps name this around what the mode is/does, not that it is legacy. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 14/22] dt-bindings: PCI: dra7xx: Add dt bindings to enable legacy mode Date: Mon, 27 Feb 2017 10:40:54 -0600 Message-ID: <20170227164054.xcubjpaf2qx3pxol@rob-hp-laptop> References: <1487325042-28227-1-git-send-email-kishon@ti.com> <1487325042-28227-15-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1487325042-28227-15-git-send-email-kishon@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Kishon Vijay Abraham I Cc: devicetree@vger.kernel.org, Joao Pinto , linux-doc@vger.kernel.org, Jingoo Han , nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Fri, Feb 17, 2017 at 03:20:34PM +0530, Kishon Vijay Abraham I wrote: > Update device tree binding documentation of TI's dra7xx PCI > controller to include property for enabling legacy mode. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/pci/ti-pci.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt > index 190828a..72ebe2b 100644 > --- a/Documentation/devicetree/bindings/pci/ti-pci.txt > +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt > @@ -39,6 +39,10 @@ DEVICE MODE > - interrupts : one interrupt entries must be specified for main interrupt. > - num-ib-windows : number of inbound address translation windows > - num-ob-windows : number of outbound address translation windows > + - syscon-legacy-mode: phandle to the syscon dt node. The 1st argument should > + contain the register offset within syscon and the 2nd > + argument should contain the bit field for setting the > + legacy mode Vendor prefix needed and what does "legacy mode" mean? Perhaps name this around what the mode is/does, not that it is legacy. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Mon, 27 Feb 2017 10:40:54 -0600 From: Rob Herring To: Kishon Vijay Abraham I Subject: Re: [PATCH v2 14/22] dt-bindings: PCI: dra7xx: Add dt bindings to enable legacy mode Message-ID: <20170227164054.xcubjpaf2qx3pxol@rob-hp-laptop> References: <1487325042-28227-1-git-send-email-kishon@ti.com> <1487325042-28227-15-git-send-email-kishon@ti.com> MIME-Version: 1.0 In-Reply-To: <1487325042-28227-15-git-send-email-kishon@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Joao Pinto , linux-doc@vger.kernel.org, Jingoo Han , nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Fri, Feb 17, 2017 at 03:20:34PM +0530, Kishon Vijay Abraham I wrote: > Update device tree binding documentation of TI's dra7xx PCI > controller to include property for enabling legacy mode. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/pci/ti-pci.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt > index 190828a..72ebe2b 100644 > --- a/Documentation/devicetree/bindings/pci/ti-pci.txt > +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt > @@ -39,6 +39,10 @@ DEVICE MODE > - interrupts : one interrupt entries must be specified for main interrupt. > - num-ib-windows : number of inbound address translation windows > - num-ob-windows : number of outbound address translation windows > + - syscon-legacy-mode: phandle to the syscon dt node. The 1st argument should > + contain the register offset within syscon and the 2nd > + argument should contain the bit field for setting the > + legacy mode Vendor prefix needed and what does "legacy mode" mean? Perhaps name this around what the mode is/does, not that it is legacy. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Mon, 27 Feb 2017 10:40:54 -0600 Subject: [PATCH v2 14/22] dt-bindings: PCI: dra7xx: Add dt bindings to enable legacy mode In-Reply-To: <1487325042-28227-15-git-send-email-kishon@ti.com> References: <1487325042-28227-1-git-send-email-kishon@ti.com> <1487325042-28227-15-git-send-email-kishon@ti.com> Message-ID: <20170227164054.xcubjpaf2qx3pxol@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 17, 2017 at 03:20:34PM +0530, Kishon Vijay Abraham I wrote: > Update device tree binding documentation of TI's dra7xx PCI > controller to include property for enabling legacy mode. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/pci/ti-pci.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt > index 190828a..72ebe2b 100644 > --- a/Documentation/devicetree/bindings/pci/ti-pci.txt > +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt > @@ -39,6 +39,10 @@ DEVICE MODE > - interrupts : one interrupt entries must be specified for main interrupt. > - num-ib-windows : number of inbound address translation windows > - num-ob-windows : number of outbound address translation windows > + - syscon-legacy-mode: phandle to the syscon dt node. The 1st argument should > + contain the register offset within syscon and the 2nd > + argument should contain the bit field for setting the > + legacy mode Vendor prefix needed and what does "legacy mode" mean? Perhaps name this around what the mode is/does, not that it is legacy. Rob