From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751563AbdB1AQj (ORCPT ); Mon, 27 Feb 2017 19:16:39 -0500 Received: from mail-oi0-f68.google.com ([209.85.218.68]:32852 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbdB1AQe (ORCPT ); Mon, 27 Feb 2017 19:16:34 -0500 Date: Mon, 27 Feb 2017 18:15:47 -0600 From: Rob Herring To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Daniel Lezcano , arm@kernel.org, Mark Rutland , support@lemaker.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mp-cs@actions-semi.com, 96boards@ucrobotics.com, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC v2 03/17] dt-bindings: timer: Document Owl timer Message-ID: <20170228001547.gzu2fzlx63dqesrg@rob-hp-laptop> References: <20170224034055.18807-1-afaerber@suse.de> <20170224034055.18807-4-afaerber@suse.de> <0c3f94c0-b920-25f9-7347-b43407d66dfa@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0c3f94c0-b920-25f9-7347-b43407d66dfa@suse.de> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 27, 2017 at 03:40:07PM +0100, Andreas Färber wrote: > Am 24.02.2017 um 04:40 schrieb Andreas Färber: > > The Actions Semi S500 SoC contains a timer block with two timers. > > > > Signed-off-by: Andreas Färber > > --- > > v2: new > > > > .../devicetree/bindings/timer/actions,owl-timer.txt | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > > > diff --git a/Documentation/devicetree/bindings/timer/actions,owl-timer.txt b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > new file mode 100644 > > index 0000000..141bc7b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > @@ -0,0 +1,16 @@ > > +Actions Semi Owl Timer > > + > > +Required properties: > > +- compatible : "actions,owl-timer" > > +- reg : Offset and length of the register set for the device. > > +- interrupts : Should contain two timer interrupts. > > + > > + > > +Example: > > + > > + timer@b0168000 { > > + compatible = "actions,owl-timer"; > > + reg = <0xb0168000 0x100>; > > + interrupts = , > > + ; > > + }; > > I need to modify these bindings for upcoming v3 in the following ways: > > * "actions,s500-timer", "actions,owl-timer" to deal with S500 vs. S900 > differences while keeping a single driver registration (or would two > registrations be preferred, dropping the second compatible? they do > share a common subset) The former is fine. > > * Use named interrupts to deal with 2x 2Hz + 2x Timer vs. 4x Timer for > complete hardware description The compatible should imply this difference. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC v2 03/17] dt-bindings: timer: Document Owl timer Date: Mon, 27 Feb 2017 18:15:47 -0600 Message-ID: <20170228001547.gzu2fzlx63dqesrg@rob-hp-laptop> References: <20170224034055.18807-1-afaerber@suse.de> <20170224034055.18807-4-afaerber@suse.de> <0c3f94c0-b920-25f9-7347-b43407d66dfa@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <0c3f94c0-b920-25f9-7347-b43407d66dfa@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Mark Rutland , support@lemaker.org, devicetree@vger.kernel.org, Daniel Lezcano , linux-kernel@vger.kernel.org, arm@kernel.org, mp-cs@actions-semi.com, 96boards@ucrobotics.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Mon, Feb 27, 2017 at 03:40:07PM +0100, Andreas F=E4rber wrote: > Am 24.02.2017 um 04:40 schrieb Andreas F=E4rber: > > The Actions Semi S500 SoC contains a timer block with two timers. > > = > > Signed-off-by: Andreas F=E4rber > > --- > > v2: new > > = > > .../devicetree/bindings/timer/actions,owl-timer.txt | 16 ++++++++= ++++++++ > > 1 file changed, 16 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/timer/actions,owl= -timer.txt > > = > > diff --git a/Documentation/devicetree/bindings/timer/actions,owl-timer.= txt b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > new file mode 100644 > > index 0000000..141bc7b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > @@ -0,0 +1,16 @@ > > +Actions Semi Owl Timer > > + > > +Required properties: > > +- compatible : "actions,owl-timer" > > +- reg : Offset and length of the register set for the device. > > +- interrupts : Should contain two timer interrupts. > > + > > + > > +Example: > > + > > + timer@b0168000 { > > + compatible =3D "actions,owl-timer"; > > + reg =3D <0xb0168000 0x100>; > > + interrupts =3D , > > + ; > > + }; > = > I need to modify these bindings for upcoming v3 in the following ways: > = > * "actions,s500-timer", "actions,owl-timer" to deal with S500 vs. S900 > differences while keeping a single driver registration (or would two > registrations be preferred, dropping the second compatible? they do > share a common subset) The former is fine. > = > * Use named interrupts to deal with 2x 2Hz + 2x Timer vs. 4x Timer for > complete hardware description The compatible should imply this difference. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Mon, 27 Feb 2017 18:15:47 -0600 Subject: [RFC v2 03/17] dt-bindings: timer: Document Owl timer In-Reply-To: <0c3f94c0-b920-25f9-7347-b43407d66dfa@suse.de> References: <20170224034055.18807-1-afaerber@suse.de> <20170224034055.18807-4-afaerber@suse.de> <0c3f94c0-b920-25f9-7347-b43407d66dfa@suse.de> Message-ID: <20170228001547.gzu2fzlx63dqesrg@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Feb 27, 2017 at 03:40:07PM +0100, Andreas F?rber wrote: > Am 24.02.2017 um 04:40 schrieb Andreas F?rber: > > The Actions Semi S500 SoC contains a timer block with two timers. > > > > Signed-off-by: Andreas F?rber > > --- > > v2: new > > > > .../devicetree/bindings/timer/actions,owl-timer.txt | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > > > diff --git a/Documentation/devicetree/bindings/timer/actions,owl-timer.txt b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > new file mode 100644 > > index 0000000..141bc7b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/timer/actions,owl-timer.txt > > @@ -0,0 +1,16 @@ > > +Actions Semi Owl Timer > > + > > +Required properties: > > +- compatible : "actions,owl-timer" > > +- reg : Offset and length of the register set for the device. > > +- interrupts : Should contain two timer interrupts. > > + > > + > > +Example: > > + > > + timer at b0168000 { > > + compatible = "actions,owl-timer"; > > + reg = <0xb0168000 0x100>; > > + interrupts = , > > + ; > > + }; > > I need to modify these bindings for upcoming v3 in the following ways: > > * "actions,s500-timer", "actions,owl-timer" to deal with S500 vs. S900 > differences while keeping a single driver registration (or would two > registrations be preferred, dropping the second compatible? they do > share a common subset) The former is fine. > > * Use named interrupts to deal with 2x 2Hz + 2x Timer vs. 4x Timer for > complete hardware description The compatible should imply this difference. Rob