From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sreya Mittal <sreyamittal5@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH 2/2 v3] staging: speakup: Clean up if conditions
Date: Tue, 28 Feb 2017 06:48:19 +0100 [thread overview]
Message-ID: <20170228054818.GA25790@kroah.com> (raw)
In-Reply-To: <20170227160940.24674-1-sreyamittal5@gmail.com>
On Mon, Feb 27, 2017 at 09:39:40PM +0530, Sreya Mittal wrote:
> Found by checkpatch.pl
> Logical conditions are on the next line, useless parentheses present
> Clean up the if tests by
>
> * Put logical conditions on the previous line
> * Remove useless parentheses
> * Line up the tests
>
> Signed-off-by: Sreya Mittal <sreyamittal5@gmail.com>
>
> ---
>
> Changes in v3:
> *Correct placement of patch changes
Why do I have 3 copies of this same email sent out? Which one am I
supposed to use?
I'm still confused, please resend both of these patches, as a "v4", so I
know what to pick up.
Remember, it should be _very_ obvious to the maintainer as to what
patches to review/accept, you don't want to make me have to think, as I
don't do that very well :)
thanks,
greg k-h
next prev parent reply other threads:[~2017-02-28 5:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 16:09 [PATCH 2/2 v3] staging: speakup: Clean up if conditions Sreya Mittal
2017-02-28 5:48 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-27 16:03 Sreya Mittal
2017-02-27 15:43 Sreya Mittal
2017-02-24 21:33 Sreya Mittal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170228054818.GA25790@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris@the-brannons.com \
--cc=kirk@reisers.ca \
--cc=outreachy-kernel@googlegroups.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=sreyamittal5@gmail.com \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.