From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbdB1JDL (ORCPT ); Tue, 28 Feb 2017 04:03:11 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34114 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbdB1JCv (ORCPT ); Tue, 28 Feb 2017 04:02:51 -0500 Date: Tue, 28 Feb 2017 10:01:10 +0100 From: Daniel Vetter To: Lorenzo Stoakes Cc: Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org Subject: Re: [PATCH RESEND] drm/via: use get_user_pages_unlocked() Message-ID: <20170228090110.m4pxtjlbgaft7oet@phenom.ffwll.local> Mail-Followup-To: Lorenzo Stoakes , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org References: <20170227215008.21457-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170227215008.21457-1-lstoakes@gmail.com> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 27, 2017 at 09:50:08PM +0000, Lorenzo Stoakes wrote: > Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code > and takes advantage of VM_FAULT_RETRY functionality when faulting in pages. > > Signed-off-by: Lorenzo Stoakes Queued for 4.12, thanks for the patch. -Daniel > --- > drivers/gpu/drm/via/via_dmablit.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/via_dmablit.c > index 1a3ad769f8c8..98aae9809249 100644 > --- a/drivers/gpu/drm/via/via_dmablit.c > +++ b/drivers/gpu/drm/via/via_dmablit.c > @@ -238,13 +238,9 @@ via_lock_all_dma_pages(drm_via_sg_info_t *vsg, drm_via_dmablit_t *xfer) > vsg->pages = vzalloc(sizeof(struct page *) * vsg->num_pages); > if (NULL == vsg->pages) > return -ENOMEM; > - down_read(¤t->mm->mmap_sem); > - ret = get_user_pages((unsigned long)xfer->mem_addr, > - vsg->num_pages, > - (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0, > - vsg->pages, NULL); > - > - up_read(¤t->mm->mmap_sem); > + ret = get_user_pages_unlocked((unsigned long)xfer->mem_addr, > + vsg->num_pages, vsg->pages, > + (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0); > if (ret != vsg->num_pages) { > if (ret < 0) > return ret; > -- > 2.11.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f198.google.com (mail-wr0-f198.google.com [209.85.128.198]) by kanga.kvack.org (Postfix) with ESMTP id A4CA66B038F for ; Tue, 28 Feb 2017 04:01:14 -0500 (EST) Received: by mail-wr0-f198.google.com with SMTP id 73so2655738wrb.1 for ; Tue, 28 Feb 2017 01:01:14 -0800 (PST) Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com. [2a00:1450:400c:c0c::244]) by mx.google.com with ESMTPS id v202si7936890wmv.158.2017.02.28.01.01.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Feb 2017 01:01:13 -0800 (PST) Received: by mail-wr0-x244.google.com with SMTP id l37so742324wrc.3 for ; Tue, 28 Feb 2017 01:01:13 -0800 (PST) Date: Tue, 28 Feb 2017 10:01:10 +0100 From: Daniel Vetter Subject: Re: [PATCH RESEND] drm/via: use get_user_pages_unlocked() Message-ID: <20170228090110.m4pxtjlbgaft7oet@phenom.ffwll.local> References: <20170227215008.21457-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170227215008.21457-1-lstoakes@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Lorenzo Stoakes Cc: Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org On Mon, Feb 27, 2017 at 09:50:08PM +0000, Lorenzo Stoakes wrote: > Moving from get_user_pages() to get_user_pages_unlocked() simplifies the code > and takes advantage of VM_FAULT_RETRY functionality when faulting in pages. > > Signed-off-by: Lorenzo Stoakes Queued for 4.12, thanks for the patch. -Daniel > --- > drivers/gpu/drm/via/via_dmablit.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/via_dmablit.c > index 1a3ad769f8c8..98aae9809249 100644 > --- a/drivers/gpu/drm/via/via_dmablit.c > +++ b/drivers/gpu/drm/via/via_dmablit.c > @@ -238,13 +238,9 @@ via_lock_all_dma_pages(drm_via_sg_info_t *vsg, drm_via_dmablit_t *xfer) > vsg->pages = vzalloc(sizeof(struct page *) * vsg->num_pages); > if (NULL == vsg->pages) > return -ENOMEM; > - down_read(¤t->mm->mmap_sem); > - ret = get_user_pages((unsigned long)xfer->mem_addr, > - vsg->num_pages, > - (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0, > - vsg->pages, NULL); > - > - up_read(¤t->mm->mmap_sem); > + ret = get_user_pages_unlocked((unsigned long)xfer->mem_addr, > + vsg->num_pages, vsg->pages, > + (vsg->direction == DMA_FROM_DEVICE) ? FOLL_WRITE : 0); > if (ret != vsg->num_pages) { > if (ret < 0) > return ret; > -- > 2.11.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH RESEND] drm/via: use get_user_pages_unlocked() Date: Tue, 28 Feb 2017 10:01:10 +0100 Message-ID: <20170228090110.m4pxtjlbgaft7oet@phenom.ffwll.local> References: <20170227215008.21457-1-lstoakes@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 42AE26E655 for ; Tue, 28 Feb 2017 09:01:14 +0000 (UTC) Received: by mail-wr0-x242.google.com with SMTP id q39so743853wrb.2 for ; Tue, 28 Feb 2017 01:01:14 -0800 (PST) Content-Disposition: inline In-Reply-To: <20170227215008.21457-1-lstoakes@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lorenzo Stoakes Cc: linux-mm@kvack.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBGZWIgMjcsIDIwMTcgYXQgMDk6NTA6MDhQTSArMDAwMCwgTG9yZW56byBTdG9ha2Vz IHdyb3RlOgo+IE1vdmluZyBmcm9tIGdldF91c2VyX3BhZ2VzKCkgdG8gZ2V0X3VzZXJfcGFnZXNf dW5sb2NrZWQoKSBzaW1wbGlmaWVzIHRoZSBjb2RlCj4gYW5kIHRha2VzIGFkdmFudGFnZSBvZiBW TV9GQVVMVF9SRVRSWSBmdW5jdGlvbmFsaXR5IHdoZW4gZmF1bHRpbmcgaW4gcGFnZXMuCj4gCj4g U2lnbmVkLW9mZi1ieTogTG9yZW56byBTdG9ha2VzIDxsc3RvYWtlc0BnbWFpbC5jb20+CgpRdWV1 ZWQgZm9yIDQuMTIsIHRoYW5rcyBmb3IgdGhlIHBhdGNoLgotRGFuaWVsCgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vdmlhL3ZpYV9kbWFibGl0LmMgfCAxMCArKystLS0tLS0tCj4gIDEgZmlsZSBj aGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS92aWEvdmlhX2RtYWJsaXQuYyBiL2RyaXZlcnMvZ3B1L2RybS92aWEv dmlhX2RtYWJsaXQuYwo+IGluZGV4IDFhM2FkNzY5ZjhjOC4uOThhYWU5ODA5MjQ5IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92aWEvdmlhX2RtYWJsaXQuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS92aWEvdmlhX2RtYWJsaXQuYwo+IEBAIC0yMzgsMTMgKzIzOCw5IEBAIHZpYV9sb2Nr X2FsbF9kbWFfcGFnZXMoZHJtX3ZpYV9zZ19pbmZvX3QgKnZzZywgIGRybV92aWFfZG1hYmxpdF90 ICp4ZmVyKQo+ICAJdnNnLT5wYWdlcyA9IHZ6YWxsb2Moc2l6ZW9mKHN0cnVjdCBwYWdlICopICog dnNnLT5udW1fcGFnZXMpOwo+ICAJaWYgKE5VTEwgPT0gdnNnLT5wYWdlcykKPiAgCQlyZXR1cm4g LUVOT01FTTsKPiAtCWRvd25fcmVhZCgmY3VycmVudC0+bW0tPm1tYXBfc2VtKTsKPiAtCXJldCA9 IGdldF91c2VyX3BhZ2VzKCh1bnNpZ25lZCBsb25nKXhmZXItPm1lbV9hZGRyLAo+IC0JCQkgICAg IHZzZy0+bnVtX3BhZ2VzLAo+IC0JCQkgICAgICh2c2ctPmRpcmVjdGlvbiA9PSBETUFfRlJPTV9E RVZJQ0UpID8gRk9MTF9XUklURSA6IDAsCj4gLQkJCSAgICAgdnNnLT5wYWdlcywgTlVMTCk7Cj4g LQo+IC0JdXBfcmVhZCgmY3VycmVudC0+bW0tPm1tYXBfc2VtKTsKPiArCXJldCA9IGdldF91c2Vy X3BhZ2VzX3VubG9ja2VkKCh1bnNpZ25lZCBsb25nKXhmZXItPm1lbV9hZGRyLAo+ICsJCQl2c2ct Pm51bV9wYWdlcywgdnNnLT5wYWdlcywKPiArCQkJKHZzZy0+ZGlyZWN0aW9uID09IERNQV9GUk9N X0RFVklDRSkgPyBGT0xMX1dSSVRFIDogMCk7Cj4gIAlpZiAocmV0ICE9IHZzZy0+bnVtX3BhZ2Vz KSB7Cj4gIAkJaWYgKHJldCA8IDApCj4gIAkJCXJldHVybiByZXQ7Cj4gLS0gCj4gMi4xMS4xCj4g CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K aHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg==