From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/3] drm: Convert drm_framebuffer_remove to atomic, v4. Date: Tue, 28 Feb 2017 13:03:24 +0100 Message-ID: <20170228120324.cc7uqfopfeuzn7mq@phenom.ffwll.local> References: <1487685102-31991-1-git-send-email-maarten.lankhorst@linux.intel.com> <1487685102-31991-3-git-send-email-maarten.lankhorst@linux.intel.com> <20170223150927.GB17822@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170223150927.GB17822@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sean Paul Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBGZWIgMjMsIDIwMTcgYXQgMTA6MDk6MjdBTSAtMDUwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IE9uIFR1ZSwgRmViIDIxLCAyMDE3IGF0IDAyOjUxOjQxUE0gKzAxMDAsIE1hYXJ0ZW4gTGFu a2hvcnN0IHdyb3RlOgo+ID4gSW5zdGVhZCBvZiB0cnlpbmcgdG8gZG8gZXZlcnl0aGluZyBpbiAx IGdvLCBqdXN0IGRvIGEgYmFzaWMgc2FmZQo+ID4gY29udmVyc2lvbiBmaXJzdC4gV2UndmUgYmVl biBiaXR0ZW4gYnkgdG9vIG1hbnkgcmVncmVzc2lvbnMgaW4gdGhlCj4gPiBwYXN0Lgo+ID4gCj4g PiBUaGlzIHBhdGNoIG9ubHkgY29udmVydHMgZHJtX2ZyYW1lYnVmZmVyX3JlbW92ZSB0byBhdG9t aWMuIFRoZQo+ID4gcmVncmVzc2lvbiBzZW5zaXRpdmUgcGFydCBpcyBzcGxpdCBvdXQgdG8gYSBz ZXBhcmF0ZSBwYXRjaC4KPiA+IAo+ID4gdjI6Cj4gPiAtIFJlbW92ZSBwbGFuZS0+ZmIgYXNzaWdu bWVudCwgZG9uZSBieSBkcm1fYXRvbWljX2NsZWFuX29sZF9mYi4KPiA+IC0gQWRkIFdBUk5fT04g d2hlbiBhdG9taWNfcmVtb3ZlX2ZiIGZhaWxzLgo+ID4gLSBBbHdheXMgY2FsbCBkcm1fYXRvbWlj X3N0YXRlX3B1dC4KPiA+IHYzOgo+ID4gLSBVc2UgZHJtX2Rydl91c2VzX2F0b21pY19tb2Rlc2V0 Cj4gPiAtIEhhbmRsZSB0aGUgY2FzZSB3aGVyZSB0aGUgZmlyc3QgcGxhbmUtZGlzYWJsZS1vbmx5 IGNvbW1pdCBmYWlscwo+ID4gICB3aXRoIC1FSU5WQUwuIFNvbWUgZHJpdmVycyBkbyBub3Qgc3Vw cG9ydCB0aGlzLCBmYWxsIGJhY2sgdG8KPiA+ICAgZGlzYWJsaW5nIGFsbCBjcnRjJ3MgaW4gdGhp cyBjYXNlLgo+ID4gdjQ6Cj4gPiAtIFNvbHZlIHZtd2dmeCBjb21wYXRpYmlsaXR5IGlzc3VlIGlu IHRoZWlyIGRyaXZlciwgd2FzIGZpeGVkIGluIHRoaXMKPiA+ICAgcGF0Y2ggYnkgdjMuCj4gPiAt IE1vdmUgb25seSBkaXNhYmxpbmcgcHJpbWFyeSB0byBhIHNlcGFyYXRlIHBhdGNoLgo+ID4gCj4g Cj4gUmV2aWV3ZWQtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgoKT2ssIG1l cmdlZCB0aGUgZmlyc3QgMiBmcm9tIHRoaXMgc2VyaWVzIHRvIGRybS1taXNjLW5leHQuCgpUaGFu a3MsIERhbmllbAoKPiAKPiA+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KPiA+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxt YWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vZHJtX2F0b21pYy5jICAgICAgICB8IDg4ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaW50ZXJuYWwuaCB8ICAx ICsKPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMgICB8ICA3ICsrKwo+ID4g IDMgZmlsZXMgY2hhbmdlZCwgOTYgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWlj LmMKPiA+IGluZGV4IGFmZWM1MzgzMjE0NS4uMjg1ZTFjMjNlOGM5IDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Ry bV9hdG9taWMuYwo+ID4gQEAgLTIwNjEsNiArMjA2MSw5NCBAQCBzdGF0aWMgdm9pZCBjb21wbGV0 ZV9jcnRjX3NpZ25hbGluZyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gIAlrZnJlZShmZW5j ZV9zdGF0ZSk7Cj4gPiAgfQo+ID4gIAo+ID4gK2ludCBkcm1fYXRvbWljX3JlbW92ZV9mYihzdHJ1 Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPiA+ICt7Cj4gPiArCXN0cnVjdCBkcm1fbW9kZXNldF9h Y3F1aXJlX2N0eCBjdHg7Cj4gPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBmYi0+ZGV2Owo+ ID4gKwlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7Cj4gPiArCXN0cnVjdCBkcm1fcGxh bmUgKnBsYW5lOwo+ID4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubjsKPiA+ICsJc3RydWN0 IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4gPiArCWludCBpLCByZXQgPSAwOwo+ ID4gKwl1bnNpZ25lZCBwbGFuZV9tYXNrOwo+ID4gKwo+ID4gKwlzdGF0ZSA9IGRybV9hdG9taWNf c3RhdGVfYWxsb2MoZGV2KTsKPiA+ICsJaWYgKCFzdGF0ZSkKPiA+ICsJCXJldHVybiAtRU5PTUVN Owo+ID4gKwo+ID4gKwlkcm1fbW9kZXNldF9hY3F1aXJlX2luaXQoJmN0eCwgMCk7Cj4gPiArCXN0 YXRlLT5hY3F1aXJlX2N0eCA9ICZjdHg7Cj4gPiArCj4gPiArcmV0cnk6Cj4gPiArCXBsYW5lX21h c2sgPSAwOwo+ID4gKwlyZXQgPSBkcm1fbW9kZXNldF9sb2NrX2FsbF9jdHgoZGV2LCAmY3R4KTsK PiA+ICsJaWYgKHJldCkKPiA+ICsJCWdvdG8gdW5sb2NrOwo+ID4gKwo+ID4gKwlkcm1fZm9yX2Vh Y2hfcGxhbmUocGxhbmUsIGRldikgewo+ID4gKwkJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqcGxh bmVfc3RhdGU7Cj4gPiArCj4gPiArCQlpZiAocGxhbmUtPnN0YXRlLT5mYiAhPSBmYikKPiA+ICsJ CQljb250aW51ZTsKPiA+ICsKPiA+ICsJCXBsYW5lX3N0YXRlID0gZHJtX2F0b21pY19nZXRfcGxh bmVfc3RhdGUoc3RhdGUsIHBsYW5lKTsKPiA+ICsJCWlmIChJU19FUlIocGxhbmVfc3RhdGUpKSB7 Cj4gPiArCQkJcmV0ID0gUFRSX0VSUihwbGFuZV9zdGF0ZSk7Cj4gPiArCQkJZ290byB1bmxvY2s7 Cj4gPiArCQl9Cj4gPiArCj4gPiArCQlpZiAocGxhbmVfc3RhdGUtPmNydGMtPnByaW1hcnkgPT0g cGxhbmUpIHsKPiA+ICsJCQlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gPiAr Cj4gPiArCQkJY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2NydGNfc3RhdGUo c3RhdGUsIHBsYW5lX3N0YXRlLT5jcnRjKTsKPiA+ICsKPiA+ICsJCQlyZXQgPSBkcm1fYXRvbWlj X2FkZF9hZmZlY3RlZF9jb25uZWN0b3JzKHN0YXRlLCBwbGFuZV9zdGF0ZS0+Y3J0Yyk7Cj4gPiAr CQkJaWYgKHJldCkKPiA+ICsJCQkJZ290byB1bmxvY2s7Cj4gPiArCj4gPiArCQkJY3J0Y19zdGF0 ZS0+YWN0aXZlID0gZmFsc2U7Cj4gPiArCQkJcmV0ID0gZHJtX2F0b21pY19zZXRfbW9kZV9mb3Jf Y3J0YyhjcnRjX3N0YXRlLCBOVUxMKTsKPiA+ICsJCQlpZiAocmV0KQo+ID4gKwkJCQlnb3RvIHVu bG9jazsKPiA+ICsJCX0KPiA+ICsKPiA+ICsJCWRybV9hdG9taWNfc2V0X2ZiX2Zvcl9wbGFuZShw bGFuZV9zdGF0ZSwgTlVMTCk7Cj4gPiArCQlyZXQgPSBkcm1fYXRvbWljX3NldF9jcnRjX2Zvcl9w bGFuZShwbGFuZV9zdGF0ZSwgTlVMTCk7Cj4gPiArCQlpZiAocmV0KQo+ID4gKwkJCWdvdG8gdW5s b2NrOwo+ID4gKwo+ID4gKwkJcGxhbmVfbWFzayB8PSBCSVQoZHJtX3BsYW5lX2luZGV4KHBsYW5l KSk7Cj4gPiArCj4gPiArCQlwbGFuZS0+b2xkX2ZiID0gcGxhbmUtPmZiOwo+ID4gKwl9Cj4gPiAr Cj4gPiArCWZvcl9lYWNoX2Nvbm5lY3Rvcl9pbl9zdGF0ZShzdGF0ZSwgY29ubiwgY29ubl9zdGF0 ZSwgaSkgewo+ID4gKwkJcmV0ID0gZHJtX2F0b21pY19zZXRfY3J0Y19mb3JfY29ubmVjdG9yKGNv bm5fc3RhdGUsIE5VTEwpOwo+ID4gKwo+ID4gKwkJaWYgKHJldCkKPiA+ICsJCQlnb3RvIHVubG9j azsKPiA+ICsJfQo+ID4gKwo+ID4gKwlpZiAocGxhbmVfbWFzaykKPiA+ICsJCXJldCA9IGRybV9h dG9taWNfY29tbWl0KHN0YXRlKTsKPiA+ICsKPiA+ICt1bmxvY2s6Cj4gPiArCWlmIChwbGFuZV9t YXNrKQo+ID4gKwkJZHJtX2F0b21pY19jbGVhbl9vbGRfZmIoZGV2LCBwbGFuZV9tYXNrLCByZXQp Owo+ID4gKwo+ID4gKwlpZiAocmV0ID09IC1FREVBRExLKSB7Cj4gPiArCQlkcm1fbW9kZXNldF9i YWNrb2ZmKCZjdHgpOwo+ID4gKwkJZ290byByZXRyeTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlkcm1f YXRvbWljX3N0YXRlX3B1dChzdGF0ZSk7Cj4gPiArCj4gPiArCWRybV9tb2Rlc2V0X2Ryb3BfbG9j a3MoJmN0eCk7Cj4gPiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsKPiA+ICsKPiA+ ICsJcmV0dXJuIHJldDsKPiA+ICt9Cj4gPiArCj4gPiAgaW50IGRybV9tb2RlX2F0b21pY19pb2N0 bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gIAkJCSAgdm9pZCAqZGF0YSwgc3RydWN0IGRy bV9maWxlICpmaWxlX3ByaXYpCj4gPiAgewo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fY3J0Y19pbnRlcm5hbC5oIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjX2ludGVybmFs LmgKPiA+IGluZGV4IDk1NWM1NjkwYmY2NC4uZTA2NzhmOGE1MWNmIDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjX2ludGVybmFsLmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fY3J0Y19pbnRlcm5hbC5oCj4gPiBAQCAtMTgzLDYgKzE4Myw3IEBAIGludCBkcm1f YXRvbWljX2dldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX21vZGVfb2JqZWN0ICpvYmosCj4gPiAgCQkJ ICAgIHN0cnVjdCBkcm1fcHJvcGVydHkgKnByb3BlcnR5LCB1aW50NjRfdCAqdmFsKTsKPiA+ICBp bnQgZHJtX21vZGVfYXRvbWljX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPiAgCQkJ ICB2b2lkICpkYXRhLCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdik7Cj4gPiAraW50IGRybV9h dG9taWNfcmVtb3ZlX2ZiKHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiKTsKPiA+ICAKPiA+ICAK PiA+ICAvKiBkcm1fcGxhbmUuYyAqLwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fZnJhbWVidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYwo+ID4g aW5kZXggMjhhMDEwOGExYWI4Li5jMGU1OTNhN2Y5YjQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f ZnJhbWVidWZmZXIuYwo+ID4gQEAgLTc3Myw2ICs3NzMsMTIgQEAgdm9pZCBkcm1fZnJhbWVidWZm ZXJfcmVtb3ZlKHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiKQo+ID4gIAkgKiBpbiB0aGlzIG1h bm5lci4KPiA+ICAJICovCj4gPiAgCWlmIChkcm1fZnJhbWVidWZmZXJfcmVhZF9yZWZjb3VudChm YikgPiAxKSB7Cj4gPiArCQlpZiAoZHJtX2Rydl91c2VzX2F0b21pY19tb2Rlc2V0KGRldikpIHsK PiA+ICsJCQlpbnQgcmV0ID0gZHJtX2F0b21pY19yZW1vdmVfZmIoZmIpOwo+ID4gKwkJCVdBUk4o cmV0LCAiYXRvbWljIHJlbW92ZV9mYiBmYWlsZWQgd2l0aCAlaVxuIiwgcmV0KTsKPiA+ICsJCQln b3RvIG91dDsKPiA+ICsJCX0KPiA+ICsKPiA+ICAJCWRybV9tb2Rlc2V0X2xvY2tfYWxsKGRldik7 Cj4gPiAgCQkvKiByZW1vdmUgZnJvbSBhbnkgQ1JUQyAqLwo+ID4gIAkJZHJtX2Zvcl9lYWNoX2Ny dGMoY3J0YywgZGV2KSB7Cj4gPiBAQCAtNzkwLDYgKzc5Niw3IEBAIHZvaWQgZHJtX2ZyYW1lYnVm ZmVyX3JlbW92ZShzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPiA+ICAJCWRybV9tb2Rlc2V0 X3VubG9ja19hbGwoZGV2KTsKPiA+ICAJfQo+ID4gIAo+ID4gK291dDoKPiA+ICAJZHJtX2ZyYW1l YnVmZmVyX3VucmVmZXJlbmNlKGZiKTsKPiA+ICB9Cj4gPiAgRVhQT1JUX1NZTUJPTChkcm1fZnJh bWVidWZmZXJfcmVtb3ZlKTsKPiA+IC0tIAo+ID4gMi43LjQKPiA+IAo+ID4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IGRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4gCj4gLS0gCj4g U2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKCi0tIApE YW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8v YmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK