All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
	Lekshmi Pillai <lekshmicpillai@in.ibm.com>,
	NeilBrown <neilb@suse.de>, Omar Sandoval <osandov@osandov.com>
Subject: Re: [PATCH 08/13] bdi: Shutdown writeback on all cgwbs in cgwb_bdi_destroy()
Date: Tue, 28 Feb 2017 11:44:36 -0500	[thread overview]
Message-ID: <20170228164436.GD15287@htj.duckdns.org> (raw)
In-Reply-To: <20170221170958.21845-9-jack@suse.cz>

Hello,

On Tue, Feb 21, 2017 at 06:09:53PM +0100, Jan Kara wrote:
> Currently we waited for all cgwbs to get freed in cgwb_bdi_destroy()
> which also means that writeback has been shutdown on them. Since this
> wait is going away, directly shutdown writeback on cgwbs from
> cgwb_bdi_destroy() to avoid live writeback structures after
> bdi_unregister() has finished.

Hmmm... the only thing which is a bit bothering is that after removing
the shutdown from release_workfn this would make the final flushing
sequential, one cgwb at a time, which in certain cases can take an
unnecessarily long time.  It's not a correctness issue tho and if it
becomes a problem we can deal with it by splitting wb_shutdown() into
two pieces - the unregistration / issuing of the work items, and the
flushing of those.  Other than that, looks good to me.

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

  reply	other threads:[~2017-02-28 16:44 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 17:09 [PATCH 0/13 v2] block: Fix block device shutdown related races Jan Kara
2017-02-21 17:09 ` [PATCH 01/13] block: Move bdev_unhash_inode() after invalidate_partition() Jan Kara
2017-02-21 17:09 ` [PATCH 02/13] block: Unhash also block device inode for the whole device Jan Kara
2017-02-21 17:09 ` [PATCH 03/13] block: Revalidate i_bdev reference in bd_aquire() Jan Kara
2017-02-21 17:09 ` [PATCH 04/13] block: Move bdi_unregister() to del_gendisk() Jan Kara
2017-02-21 19:53   ` Bart Van Assche
2017-02-22  8:51     ` Jan Kara
2017-02-22 17:42       ` Bart Van Assche
2017-02-21 17:09 ` [PATCH 05/13] bdi: Mark congested->bdi as internal Jan Kara
2017-02-28 16:06   ` Tejun Heo
2017-02-21 17:09 ` [PATCH 06/13] bdi: Make wb->bdi a proper reference Jan Kara
2017-02-28 16:07   ` Tejun Heo
2017-02-21 17:09 ` [PATCH 07/13] bdi: Move removal from bdi->wb_list into wb_shutdown() Jan Kara
2017-02-28 16:14   ` Tejun Heo
2017-02-21 17:09 ` [PATCH 08/13] bdi: Shutdown writeback on all cgwbs in cgwb_bdi_destroy() Jan Kara
2017-02-28 16:44   ` Tejun Heo [this message]
2017-02-21 17:09 ` [PATCH 09/13] bdi: Do not wait for cgwbs release in bdi_unregister() Jan Kara
2017-02-28 16:51   ` Tejun Heo
2017-02-21 17:09 ` [PATCH 10/13] bdi: Rename cgwb_bdi_destroy() to cgwb_bdi_unregister() Jan Kara
2017-02-28 16:51   ` Tejun Heo
2017-02-21 17:09 ` [PATCH 11/13] block: Fix oops in locked_inode_to_wb_and_lock_list() Jan Kara
2017-02-28 16:52   ` Tejun Heo
2017-02-21 17:09 ` [PATCH 12/13] kobject: Export kobject_get_unless_zero() Jan Kara
2017-02-21 19:39   ` Bart Van Assche
2017-02-21 17:09 ` [PATCH 13/13] block: Fix oops scsi_disk_get() Jan Kara
2017-02-21 19:33   ` Bart Van Assche
2017-02-21 17:19 ` [PATCH 0/13 v2] block: Fix block device shutdown related races Jan Kara
2017-02-21 18:55   ` Dan Williams
2017-02-21 17:19 ` Jens Axboe
2017-02-22 10:24   ` Jan Kara
2017-03-01  7:25     ` Omar Sandoval
2017-03-01  7:26       ` Omar Sandoval
2017-03-01 15:11         ` Jan Kara
2017-03-06 20:38           ` Omar Sandoval
2017-03-07 13:57             ` Jan Kara
2017-03-07 16:28               ` Omar Sandoval
2017-03-08 13:21                 ` Jan Kara
2017-02-28 16:54 ` Tejun Heo
2017-03-01 15:37   ` Jan Kara
2017-03-01 16:26     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228164436.GD15287@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bauerman@linux.vnet.ibm.com \
    --cc=dan.j.williams@intel.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=lekshmicpillai@in.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.