From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41050)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1cilHF-0006aT-KH
	for qemu-devel@nongnu.org; Tue, 28 Feb 2017 12:09:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1cilHE-0000bZ-Vf
	for qemu-devel@nongnu.org; Tue, 28 Feb 2017 12:09:29 -0500
Date: Tue, 28 Feb 2017 18:09:19 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20170228170919.GQ4090@noname.redhat.com>
References: <1488194450-28056-1-git-send-email-armbru@redhat.com>
	<1488194450-28056-16-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1488194450-28056-16-git-send-email-armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 15/24] test-visitor-serialization: Pass
 &error_abort to qobject_from_json()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, pkrempa@redhat.com, eblake@redhat.com

Am 27.02.2017 um 12:20 hat Markus Armbruster geschrieben:
> qmp_deserialize() calls qobject_from_json() ignoring errors.  It
> passes the result to qobject_input_visitor_new(), which asserts it's
> not null.  Therefore, we can just as well pass &error_abort to
> qobject_from_json().
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>