[PATCH] #1: test capitalizing PATCH

[PATCH] #1: test capitalizing PATCH

[Dan Carpenter]

The new version patchwork is filtering out my patches for some reason.
Test if it's because it now insists on a capital [PATCH] in the subject.

Patchwork should be more version control agnostic than that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index d1670b8afbf5..9173548ba601 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1637,10 +1637,8 @@ intel_dp_compute_config(struct intel_encoder *encoder,
 				       adjusted_mode);
 
 		if (INTEL_GEN(dev_priv) >= 9) {
-			int ret;
-			ret = skl_update_scaler_crtc(pipe_config);
-			if (ret)
-				return ret;
+			if (skl_update_scaler_crtc(pipe_config))
+				return false;
 		}
 
 		if (HAS_GMCH_DISPLAY(dev_priv))
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] #1: test capitalizing PATCH

[Jani Nikula]

Cc: Hans, this probably applies to you as well.

On Tue, 28 Feb 2017, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The new version patchwork is filtering out my patches for some reason.
> Test if it's because it now insists on a capital [PATCH] in the subject.
>
> Patchwork should be more version control agnostic than that.

The patchwork flavor at freedesktop.org expects patches are sent using
git send-email [1]. I hear otherwise there were too many false
positives.

Please either use git send-email, or add

X-Mailer: git-send-email haha only kidding

header into your patch mails.

I'm sorry for the inconvenience and lack of transparency on
this. Apparently git send-email is so ubiquitous nowadays that this
hasn't been much of a problem.


BR,
Jani.


[1] https://github.com/dlespiau/patchwork/blob/master/patchwork/bin/parsemail.py#L323

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] #1: test capitalizing PATCH

[Dan Carpenter]

On Tue, Feb 28, 2017 at 06:31:48PM +0200, Jani Nikula wrote:
> 
> Cc: Hans, this probably applies to you as well.
> 
> On Tue, 28 Feb 2017, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > The new version patchwork is filtering out my patches for some reason.
> > Test if it's because it now insists on a capital [PATCH] in the subject.
> >
> > Patchwork should be more version control agnostic than that.
> 
> The patchwork flavor at freedesktop.org expects patches are sent using
> git send-email [1]. I hear otherwise there were too many false
> positives.
> 
> Please either use git send-email, or add
> 
> X-Mailer: git-send-email haha only kidding
> 
> header into your patch mails.

Ah.  Great.  Thanks!

regards,
dan carpenter

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] #1: test capitalizing PATCH

[Hans de Goede]

Hi,

On 28-02-17 17:31, Jani Nikula wrote:
>
> Cc: Hans, this probably applies to you as well.

I'm already always using git-send-email, so whatever the
reason why the CI system is not picking up my patches, this
aint it.

Regards,

Hans

>
> On Tue, 28 Feb 2017, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>> The new version patchwork is filtering out my patches for some reason.
>> Test if it's because it now insists on a capital [PATCH] in the subject.
>>
>> Patchwork should be more version control agnostic than that.
>
> The patchwork flavor at freedesktop.org expects patches are sent using
> git send-email [1]. I hear otherwise there were too many false
> positives.
>
> Please either use git send-email, or add
>
> X-Mailer: git-send-email haha only kidding
>
> header into your patch mails.
>
> I'm sorry for the inconvenience and lack of transparency on
> this. Apparently git send-email is so ubiquitous nowadays that this
> hasn't been much of a problem.
>
>
> BR,
> Jani.
>
>
> [1] https://github.com/dlespiau/patchwork/blob/master/patchwork/bin/parsemail.py#L323
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] #1: test capitalizing PATCH

[Jani Nikula]

On Wed, 01 Mar 2017, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 28-02-17 17:31, Jani Nikula wrote:
>>
>> Cc: Hans, this probably applies to you as well.
>
> I'm already always using git-send-email, so whatever the
> reason why the CI system is not picking up my patches, this
> aint it.

It doesn't look like your patches match [1], though. Do you have the
sendemail.xmailer config option set to false?

BR,
Jani.


>
> Regards,
>
> Hans
>
>>
>> On Tue, 28 Feb 2017, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>> The new version patchwork is filtering out my patches for some reason.
>>> Test if it's because it now insists on a capital [PATCH] in the subject.
>>>
>>> Patchwork should be more version control agnostic than that.
>>
>> The patchwork flavor at freedesktop.org expects patches are sent using
>> git send-email [1]. I hear otherwise there were too many false
>> positives.
>>
>> Please either use git send-email, or add
>>
>> X-Mailer: git-send-email haha only kidding
>>
>> header into your patch mails.
>>
>> I'm sorry for the inconvenience and lack of transparency on
>> this. Apparently git send-email is so ubiquitous nowadays that this
>> hasn't been much of a problem.
>>
>>
>> BR,
>> Jani.
>>
>>
>> [1] https://github.com/dlespiau/patchwork/blob/master/patchwork/bin/parsemail.py#L323
>>

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] #1: test capitalizing PATCH

[Hans de Goede]

Hi,

On 01-03-17 10:57, Jani Nikula wrote:
> On Wed, 01 Mar 2017, Hans de Goede <hdegoede@redhat.com> wrote:
>> Hi,
>>
>> On 28-02-17 17:31, Jani Nikula wrote:
>>>
>>> Cc: Hans, this probably applies to you as well.
>>
>> I'm already always using git-send-email, so whatever the
>> reason why the CI system is not picking up my patches, this
>> aint it.
>
> It doesn't look like your patches match [1], though. Do you have the
> sendemail.xmailer config option set to false?

Nope, just send myself a test patch:

Date: Wed,  1 Mar 2017 11:05:32 +0100
Message-Id: <20170301100532.26692-1-hdegoede@redhat.com>
X-Mailer: git-send-email 2.9.3

Result: 250


But indeed the header is gone when it hits my own Inbox,
seems this gets stripped by the Red Hat smtp server somehow ?

I will file a ticket with our it department for this.

Regards,

Hans


>
> BR,
> Jani.
>
>
>>
>> Regards,
>>
>> Hans
>>
>>>
>>> On Tue, 28 Feb 2017, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>>> The new version patchwork is filtering out my patches for some reason.
>>>> Test if it's because it now insists on a capital [PATCH] in the subject.
>>>>
>>>> Patchwork should be more version control agnostic than that.
>>>
>>> The patchwork flavor at freedesktop.org expects patches are sent using
>>> git send-email [1]. I hear otherwise there were too many false
>>> positives.
>>>
>>> Please either use git send-email, or add
>>>
>>> X-Mailer: git-send-email haha only kidding
>>>
>>> header into your patch mails.
>>>
>>> I'm sorry for the inconvenience and lack of transparency on
>>> this. Apparently git send-email is so ubiquitous nowadays that this
>>> hasn't been much of a problem.
>>>
>>>
>>> BR,
>>> Jani.
>>>
>>>
>>> [1] https://github.com/dlespiau/patchwork/blob/master/patchwork/bin/parsemail.py#L323
>>>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx