From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbdB1VjO (ORCPT ); Tue, 28 Feb 2017 16:39:14 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:65488 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824AbdB1Vix (ORCPT ); Tue, 28 Feb 2017 16:38:53 -0500 From: Arnd Bergmann To: Guenter Roeck Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org, Arnd Bergmann Subject: [PATCH 5/8] watchdog: menf21bmc: add I2C dependency Date: Tue, 28 Feb 2017 22:01:20 +0100 Message-Id: <20170228210123.3404816-6-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170228210123.3404816-1-arnd@arndb.de> References: <20170228210123.3404816-1-arnd@arndb.de> X-Provags-ID: V03:K0:Zk4Zwck5uU1InffTj3fGNlFUkqQfnD7+reSd1UUwrwbaFElUHML /7oRXJQezdGpDrUvCTfY9OCK2BXChiCZ4PKC6WuypXuZri2EqhheuaMC7Osio7FYNqxwpT7 Irey9rp8lwpAhHbZJN5Kf4klYG3g7eBIS/zGobghIrP/YAZv33uFAk+KHNuBmr0481ME7Ir ArELNn8M66SAF+uaaiv7w== X-UI-Out-Filterresults: notjunk:1;V01:K0:88O3GR7kBRc=:t/kV8jiFJvfJiwCoFRQTXJ A8LO98UXjUzXFfW2tQycZk8dUG8nJ8z+GsoBKT6Z9MTKtRzwZj+xX6ha8Erc+n0u82HSP4amI 4LqGrrJ6Af3UhqdQ5/kFl2M2+q2UiKxu8YmGPGMP80EXr2iwG0GoTx0WIIaJSTgsoRYyYsH96 oT6sz1+xGMCwOeSmR7Flv2oVONMuPCGrcHl8PqfbT2T/Tnp1BMGTo4r8fC7Qs8+4os5FCeQwB YlPSEFsNuQsM2B/rBo0XiHHDw4BgbWHBKr4bDBCofP7KhPBTghn7/pghUEP+l69jFImDMBpvH bgg+Ctgz0mgoEMRGb+uGsepFjlMYzVgxjdWgVeL6LT+UUdOIytnjSoueXFNj6ukNzmDt3LWAT rOlRzjSEz2iYf9hNqK1ejb5HJ1YQdwOBK0GfIScddN5JtaRUguIhwzIOvrX518qxrO5KoNUFp vVoOGkxvL0P6vuyQyH/2zVWQ3W3R5cat5KMo392PopL+yQyG76e239PoTINwvylcyvlOORFMI OOSV4Se/lnnaVVE/UGEgh358YLt5sqKfBMT5eakyEcKRPKwEGecOoYzz7lT+hM+hXnm7RcpjP 07+X4Mw/yK0J+gTXMQ6Ee2ZiZbXcCi0JQChFQm5KqND2vnUkFvqW6JcnpLe1BMpUTMunVkFCS zWT2VrorxCXUmQ62i4r3k+1aIFivyMLGJYaVe5s7EUfczgZwgnKE43Sqp5O11wpaZZQw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver fails to link when CONFIG_I2C is disabled or a loadable module while the watchdog is built-in: drivers/watchdog/built-in.o: In function `menf21bmc_wdt_shutdown': menf21bmc_wdt.c:(.text+0x9b44): undefined reference to `i2c_smbus_write_word_data' menf21bmc_wdt.c:(.text+0x9b44): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `i2c_smbus_write_word_data' This adds a Kconfig dependency for it, to enforce a valid configuration. Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible") Signed-off-by: Arnd Bergmann --- drivers/watchdog/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index de52495ef150..ab0ec389e436 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -142,6 +142,7 @@ config GPIO_WATCHDOG_ARCH_INITCALL config MENF21BMC_WATCHDOG tristate "MEN 14F021P00 BMC Watchdog" depends on MFD_MENF21BMC || COMPILE_TEST + depends on I2C select WATCHDOG_CORE help Say Y here to include support for the MEN 14F021P00 BMC Watchdog. -- 2.9.0