All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Wim Van Sebroeck <wim@iguana.be>,
	linux-watchdog@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] watchdog: bcm2835: add CONFIG_OF dependency
Date: Tue, 28 Feb 2017 13:43:49 -0800	[thread overview]
Message-ID: <20170228214349.GI6651@roeck-us.net> (raw)
In-Reply-To: <20170228210123.3404816-8-arnd@arndb.de>

On Tue, Feb 28, 2017 at 10:01:22PM +0100, Arnd Bergmann wrote:
> Without CONFIG_OF, the driver fails to link:
> 
> drivers/watchdog/built-in.o: In function `bcm2835_power_off':
> bcm2835_wdt.c:(.text+0x1946): undefined reference to `of_find_device_by_node'
> 
> This adds a new dependency, to allow the COMPILE_TEST check to succeed.
> 
> Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 3216012170fa..8cb9b986ee2d 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1496,7 +1496,7 @@ config BCM63XX_WDT
>  
>  config BCM2835_WDT
>  	tristate "Broadcom BCM2835 hardware watchdog"
> -	depends on ARCH_BCM2835 || COMPILE_TEST
> +	depends on ARCH_BCM2835 || (OF && COMPILE_TEST)
>  	select WATCHDOG_CORE
>  	help
>  	  Watchdog driver for the built in watchdog hardware in Broadcom
> -- 
> 2.9.0
> 

  reply	other threads:[~2017-02-28 22:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 21:01 [PATCH 0/8] watchdog fixes for COMPILE_TEST change Arnd Bergmann
2017-02-28 21:01 ` [PATCH 1/8] mfd: retu: add inline alternatives for CONFIG_RETU=n Arnd Bergmann
2017-02-28 21:40   ` Guenter Roeck
2017-02-28 21:01 ` [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Arnd Bergmann
2017-02-28 21:42   ` Guenter Roeck
2017-02-28 21:47     ` Arnd Bergmann
2017-02-28 23:19       ` Guenter Roeck
2017-02-28 23:24       ` Guenter Roeck
2017-03-01  9:17         ` Arnd Bergmann
2017-03-14 11:14   ` Lee Jones
2017-03-14 11:14     ` Lee Jones
2017-03-14 12:09     ` Arnd Bergmann
2017-03-15 10:27       ` Lee Jones
2017-03-15 10:27         ` Lee Jones
2017-03-15 11:36         ` Arnd Bergmann
2017-02-28 21:01 ` [PATCH 3/8] watchdog: wm831x watchdog really needs mfd Arnd Bergmann
2017-02-28 21:36   ` Guenter Roeck
2017-02-28 21:44     ` Arnd Bergmann
2017-02-28 21:48       ` Arnd Bergmann
2017-02-28 23:16         ` Guenter Roeck
2017-03-01  2:50           ` Randy Dunlap
2017-02-28 21:01 ` [PATCH 4/8] watchdog: geode: restore hard CS5535_MFGPT dependency Arnd Bergmann
2017-02-28 21:42   ` Guenter Roeck
2017-02-28 21:01 ` [PATCH 5/8] watchdog: menf21bmc: add I2C dependency Arnd Bergmann
2017-02-28 21:43   ` Guenter Roeck
2017-02-28 21:01 ` [PATCH 6/8] watchdog: sp805: add back AMBA dependency Arnd Bergmann
2017-02-28 21:43   ` Guenter Roeck
2017-02-28 21:01 ` [PATCH 7/8] watchdog: bcm2835: add CONFIG_OF dependency Arnd Bergmann
2017-02-28 21:43   ` Guenter Roeck [this message]
2017-02-28 21:01 ` [PATCH 8/8] watchdog: kempld: revert to full dependency Arnd Bergmann
2017-02-28 21:39   ` Guenter Roeck
2017-02-28 21:31 ` [PATCH 0/8] watchdog fixes for COMPILE_TEST change Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228214349.GI6651@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=arnd@arndb.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.