From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH 2/2] crypto: arm - add build time test for CRC instruction support Date: Wed, 1 Mar 2017 19:52:10 +0800 Message-ID: <20170301115210.GB11489@gondor.apana.org.au> References: <1488292617-27317-1-git-send-email-ard.biesheuvel@linaro.org> <1488292617-27317-2-git-send-email-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: arnd@arndb.de, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jonathanh@nvidia.com To: Ard Biesheuvel Return-path: Content-Disposition: inline In-Reply-To: <1488292617-27317-2-git-send-email-ard.biesheuvel@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-crypto.vger.kernel.org On Tue, Feb 28, 2017 at 02:36:57PM +0000, Ard Biesheuvel wrote: > The accelerated CRC32 module for ARM may use either the scalar CRC32 > instructions, the NEON 64x64 to 128 bit polynomial multiplication > (vmull.p64) instruction, or both, depending on what the current CPU > supports. > > However, this also requires support in binutils, and as it turns out, > versions of binutils exist that support the vmull.p64 instruction but > not the crc32 instructions. > > So refactor the Makefile logic so that this module only gets built if > binutils has support for both. > > Signed-off-by: Ard Biesheuvel Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt From mboxrd@z Thu Jan 1 00:00:00 1970 From: herbert@gondor.apana.org.au (Herbert Xu) Date: Wed, 1 Mar 2017 19:52:10 +0800 Subject: [PATCH 2/2] crypto: arm - add build time test for CRC instruction support In-Reply-To: <1488292617-27317-2-git-send-email-ard.biesheuvel@linaro.org> References: <1488292617-27317-1-git-send-email-ard.biesheuvel@linaro.org> <1488292617-27317-2-git-send-email-ard.biesheuvel@linaro.org> Message-ID: <20170301115210.GB11489@gondor.apana.org.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 28, 2017 at 02:36:57PM +0000, Ard Biesheuvel wrote: > The accelerated CRC32 module for ARM may use either the scalar CRC32 > instructions, the NEON 64x64 to 128 bit polynomial multiplication > (vmull.p64) instruction, or both, depending on what the current CPU > supports. > > However, this also requires support in binutils, and as it turns out, > versions of binutils exist that support the vmull.p64 instruction but > not the crc32 instructions. > > So refactor the Makefile logic so that this module only gets built if > binutils has support for both. > > Signed-off-by: Ard Biesheuvel Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt