From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Fix all
 intel_framebuffer_init failures to take the error path
Date: Wed, 1 Mar 2017 15:00:50 +0200
Message-ID: <20170301130050.GR31595@intel.com>
References: <20170228162233.8709-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 6256B89BDB
 for <intel-gfx@lists.freedesktop.org>; Wed,  1 Mar 2017 13:01:08 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20170228162233.8709-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBGZWIgMjgsIDIwMTcgYXQgMDQ6MjI6MzJQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IE5vIG1vcmUgZGlyZWN0IHJldHVybiAtRUlOVkFMIGFzIHdlIGhhdmUgdG8gdW53aW5k
IHRoZQo+IG9iai0+ZnJhbWVidWZmZXJfcmVmZXJlbmNlcy4KPiAKPiBGaXhlczogMjRkYmY1MWE1
NTE3ICgiZHJtL2k5MTU6IHN0cnVjdF9tdXRleCBpcyBub3QgcmVxdWlyZWQgZm9yIGFsbG9jYXRp
bmcgdGhlIGZyYW1lYnVmZmVyIikKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlz
QGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh
QGxpbnV4LmludGVsLmNvbT4KCmxndG0KClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZp
bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZGlzcGxheS5jIHwgMTYgKysrKysrKystLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl
ZCwgOCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kaXNwbGF5LmMKPiBpbmRleCAxMGU2OGRmYjcyNjAuLjc3OTM2ZGRkODYwYSAxMDA2NDQK
PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTQzODMsNyArMTQzODMsNyBA
QCBzdGF0aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGludGVsX2ZyYW1lYnVm
ZmVyICppbnRlbF9mYiwKPiAgCWlmIChJTlRFTF9JTkZPKGRldl9wcml2KS0+Z2VuIDwgNCAmJgo+
ICAJICAgIHRpbGluZyAhPSBpbnRlbF9mYl9tb2RpZmllcl90b190aWxpbmcobW9kZV9jbWQtPm1v
ZGlmaWVyWzBdKSkgewo+ICAJCURSTV9ERUJVRygidGlsaW5nX21vZGUgbXVzdCBtYXRjaCBmYiBt
b2RpZmllciBleGFjdGx5IG9uIGdlbjIvM1xuIik7Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwkJ
Z290byBlcnI7Cj4gIAl9Cj4gIAo+ICAJc3RyaWRlX2FsaWdubWVudCA9IGludGVsX2ZiX3N0cmlk
ZV9hbGlnbm1lbnQoZGV2X3ByaXYsCj4gQEAgLTE0NDI4LDcgKzE0NDI4LDcgQEAgc3RhdGljIGlu
dCBpbnRlbF9mcmFtZWJ1ZmZlcl9pbml0KHN0cnVjdCBpbnRlbF9mcmFtZWJ1ZmZlciAqaW50ZWxf
ZmIsCj4gIAkJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPiAzKSB7Cj4gIAkJCURSTV9ERUJVRygi
dW5zdXBwb3J0ZWQgcGl4ZWwgZm9ybWF0OiAlc1xuIiwKPiAgCQkJICAgICAgICAgIGRybV9nZXRf
Zm9ybWF0X25hbWUobW9kZV9jbWQtPnBpeGVsX2Zvcm1hdCwgJmZvcm1hdF9uYW1lKSk7Cj4gLQkJ
CXJldHVybiAtRUlOVkFMOwo+ICsJCQlnb3RvIGVycjsKPiAgCQl9Cj4gIAkJYnJlYWs7Cj4gIAlj
YXNlIERSTV9GT1JNQVRfQUJHUjg4ODg6Cj4gQEAgLTE0NDM2LDcgKzE0NDM2LDcgQEAgc3RhdGlj
IGludCBpbnRlbF9mcmFtZWJ1ZmZlcl9pbml0KHN0cnVjdCBpbnRlbF9mcmFtZWJ1ZmZlciAqaW50
ZWxfZmIsCj4gIAkJICAgIElOVEVMX0dFTihkZXZfcHJpdikgPCA5KSB7Cj4gIAkJCURSTV9ERUJV
RygidW5zdXBwb3J0ZWQgcGl4ZWwgZm9ybWF0OiAlc1xuIiwKPiAgCQkJICAgICAgICAgIGRybV9n
ZXRfZm9ybWF0X25hbWUobW9kZV9jbWQtPnBpeGVsX2Zvcm1hdCwgJmZvcm1hdF9uYW1lKSk7Cj4g
LQkJCXJldHVybiAtRUlOVkFMOwo+ICsJCQlnb3RvIGVycjsKPiAgCQl9Cj4gIAkJYnJlYWs7Cj4g
IAljYXNlIERSTV9GT1JNQVRfWEJHUjg4ODg6Cj4gQEAgLTE0NDQ1LDE0ICsxNDQ0NSwxNCBAQCBz
dGF0aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGludGVsX2ZyYW1lYnVmZmVy
ICppbnRlbF9mYiwKPiAgCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDQpIHsKPiAgCQkJRFJN
X0RFQlVHKCJ1bnN1cHBvcnRlZCBwaXhlbCBmb3JtYXQ6ICVzXG4iLAo+ICAJCQkgICAgICAgICAg
ZHJtX2dldF9mb3JtYXRfbmFtZShtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0LCAmZm9ybWF0X25hbWUp
KTsKPiAtCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwkJCWdvdG8gZXJyOwo+ICAJCX0KPiAgCQlicmVh
azsKPiAgCWNhc2UgRFJNX0ZPUk1BVF9BQkdSMjEwMTAxMDoKPiAgCQlpZiAoIUlTX1ZBTExFWVZJ
RVcoZGV2X3ByaXYpICYmICFJU19DSEVSUllWSUVXKGRldl9wcml2KSkgewo+ICAJCQlEUk1fREVC
VUcoInVuc3VwcG9ydGVkIHBpeGVsIGZvcm1hdDogJXNcbiIsCj4gIAkJCSAgICAgICAgICBkcm1f
Z2V0X2Zvcm1hdF9uYW1lKG1vZGVfY21kLT5waXhlbF9mb3JtYXQsICZmb3JtYXRfbmFtZSkpOwo+
IC0JCQlyZXR1cm4gLUVJTlZBTDsKPiArCQkJZ290byBlcnI7Cj4gIAkJfQo+ICAJCWJyZWFrOwo+
ICAJY2FzZSBEUk1fRk9STUFUX1lVWVY6Cj4gQEAgLTE0NDYyLDEzICsxNDQ2MiwxMyBAQCBzdGF0
aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGludGVsX2ZyYW1lYnVmZmVyICpp
bnRlbF9mYiwKPiAgCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDUpIHsKPiAgCQkJRFJNX0RF
QlVHKCJ1bnN1cHBvcnRlZCBwaXhlbCBmb3JtYXQ6ICVzXG4iLAo+ICAJCQkgICAgICAgICAgZHJt
X2dldF9mb3JtYXRfbmFtZShtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0LCAmZm9ybWF0X25hbWUpKTsK
PiAtCQkJcmV0dXJuIC1FSU5WQUw7Cj4gKwkJCWdvdG8gZXJyOwo+ICAJCX0KPiAgCQlicmVhazsK
PiAgCWRlZmF1bHQ6Cj4gIAkJRFJNX0RFQlVHKCJ1bnN1cHBvcnRlZCBwaXhlbCBmb3JtYXQ6ICVz
XG4iLAo+ICAJCSAgICAgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKG1vZGVfY21kLT5waXhlbF9m
b3JtYXQsICZmb3JtYXRfbmFtZSkpOwo+IC0JCXJldHVybiAtRUlOVkFMOwo+ICsJCWdvdG8gZXJy
Owo+ICAJfQo+ICAKPiAgCS8qIEZJWE1FIG5lZWQgdG8gYWRqdXN0IExJTk9GRi9USUxFT0ZGIGFj
Y29yZGluZ2x5LiAqLwo+IEBAIC0xNDQ4MSw3ICsxNDQ4MSw3IEBAIHN0YXRpYyBpbnQgaW50ZWxf
ZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIgKmludGVsX2ZiLAo+ICAK
PiAgCXJldCA9IGludGVsX2ZpbGxfZmJfaW5mbyhkZXZfcHJpdiwgJmludGVsX2ZiLT5iYXNlKTsK
PiAgCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiArCQlnb3RvIGVycjsKPiAgCj4gIAlyZXQg
PSBkcm1fZnJhbWVidWZmZXJfaW5pdChvYmotPmJhc2UuZGV2LAo+ICAJCQkJICAgJmludGVsX2Zi
LT5iYXNlLAo+IC0tIAo+IDIuMTEuMAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h
aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==