From: Christoph Hellwig <email@example.com> To: Chris Mason <firstname.lastname@example.org> Cc: Christoph Hellwig <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [RFC] failure atomic writes for file systems and block devices Date: Wed, 1 Mar 2017 16:07:09 +0100 [thread overview] Message-ID: <20170301150709.GD12248@lst.de> (raw) In-Reply-To: <email@example.com> On Tue, Feb 28, 2017 at 03:48:16PM -0500, Chris Mason wrote: > One thing that isn't clear to me is how we're dealing with boundary bio > mappings, which will get submitted by submit_page_section() > > sdio->boundary = buffer_boundary(map_bh); The old dio code is not supported at all by this code at the moment. We'll either need the new block dev direct I/O code on block devices (and limit to BIO_MAX_PAGES, this is a bug in this patchset if people ever have devices with > 1MB atomic write support. And thanks to NVMe the failure case is silent, sigh..), or we need file system support for out of place writes. > > In btrfs I'd just chain things together and do the extent pointer swap > afterwards, but I didn't follow the XFS code well enough to see how its > handled there. But either way it feels like an error prone surprise > waiting for later, and one gap we really want to get right in the FS > support is O_ATOMIC across a fragmented extent. > > If I'm reading the XFS patches right, the code always cows for atomic. It doesn't really COW - it uses the COW infrastructure to write out of place and then commit it into the file later. Because of that we don't really care about things like boundary blocks (which XFS never used in that form anyway) - data is written first, the cache is flushed and then we swap around the extent pointers. > Are > you planning on adding an optimization to use atomic support in the device > to skip COW when possible? We could do that fairly easily for files that have a contiguous mapping for the atomic write I/O. But at this point I have a lot more trust in the fs code than the devices, especially due to the silent failure mode.
next prev parent reply other threads:[~2017-03-01 15:07 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-28 14:57 Christoph Hellwig 2017-02-28 14:57 ` [PATCH 01/12] uapi/fs: add O_ATOMIC to the open flags Christoph Hellwig 2017-02-28 14:57 ` [PATCH 02/12] iomap: pass IOMAP_* flags to actors Christoph Hellwig 2017-02-28 14:57 ` [PATCH 03/12] iomap: add a IOMAP_ATOMIC flag Christoph Hellwig 2017-02-28 14:57 ` [PATCH 04/12] fs: add a BH_Atomic flag Christoph Hellwig 2017-02-28 14:57 ` [PATCH 05/12] fs: add a F_IOINFO fcntl Christoph Hellwig 2017-02-28 16:51 ` Darrick J. Wong 2017-03-01 15:11 ` Christoph Hellwig 2017-02-28 14:57 ` [PATCH 06/12] xfs: cleanup is_reflink checks Christoph Hellwig 2017-02-28 14:57 ` [PATCH 07/12] xfs: implement failure-atomic writes Christoph Hellwig 2017-02-28 23:09 ` Darrick J. Wong 2017-03-01 15:17 ` Christoph Hellwig 2017-02-28 14:57 ` [PATCH 08/12] xfs: implement the F_IOINFO fcntl Christoph Hellwig 2017-02-28 14:57 ` [PATCH 09/12] block: advertize max atomic write limit Christoph Hellwig 2017-02-28 14:57 ` [PATCH 10/12] block_dev: set REQ_NOMERGE for O_ATOMIC writes Christoph Hellwig 2017-02-28 14:57 ` [PATCH 11/12] block_dev: implement the F_IOINFO fcntl Christoph Hellwig 2017-02-28 14:57 ` [PATCH 12/12] nvme: export the atomic write limit Christoph Hellwig 2017-02-28 20:48 ` [RFC] failure atomic writes for file systems and block devices Chris Mason 2017-02-28 20:48 ` Chris Mason 2017-03-01 15:07 ` Christoph Hellwig [this message] 2017-02-28 23:22 ` Darrick J. Wong 2017-03-01 15:09 ` Christoph Hellwig 2017-03-01 11:21 ` Amir Goldstein 2017-03-01 15:07 ` Christoph Hellwig 2017-03-01 15:07 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170301150709.GD12248@lst.de \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [RFC] failure atomic writes for file systems and block devices' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.