From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751552AbdCAPSD (ORCPT ); Wed, 1 Mar 2017 10:18:03 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36260 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750734AbdCAPSA (ORCPT ); Wed, 1 Mar 2017 10:18:00 -0500 Date: Wed, 1 Mar 2017 20:46:59 +0530 From: "Naveen N. Rao" To: "Steven Rostedt (VMware)" Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Masami Hiramatsu , linuxppc-dev@lists.ozlabs.org, Ingo Molnar Subject: Re: [PATCH v2 3.5/5] trace/kprobes: Add back warning about offset in return probes References: <183e7ce2921a08c9c755ee9a5da3134febc6695b.1487770934.git.naveen.n.rao@linux.vnet.ibm.com> <20170227113252.05e9c0df@gandalf.local.home> <20170227115204.00f92846@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170227115204.00f92846@gandalf.local.home> User-Agent: Mutt/1.6.2 (2016-07-01) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17030115-7323-0000-0000-000000CFBEB3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17030115-7324-0000-0000-00000272CF5C Message-Id: <20170301151659.GO4212@naverao1-tp.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-01_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1703010141 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/02/27 11:52AM, Steven Rostedt (VMware) wrote: > Let's not remove the warning about offsets and return probes when the > offset is invalid. Good point! Thanks, Steve! > > Signed-off-by: Steven Rostedt (VMware) Acked-by: Naveen N. Rao > --- > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c > index 3f4f788..f626235 100644 > --- a/kernel/trace/trace_kprobe.c > +++ b/kernel/trace/trace_kprobe.c > @@ -695,6 +695,11 @@ static int create_trace_kprobe(int argc, char **argv) > pr_info("Failed to parse symbol.\n"); > return ret; > } > + if (offset && is_return && > + !arch_function_offset_within_entry(offset)) { > + pr_info("Given offset is not valid for return probe.\n"); > + return -EINVAL; > + } > } > argc -= 2; argv += 2; > >