From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Wed, 1 Mar 2017 19:43:43 +0100 Subject: [Buildroot] [PATCH 1/5] core/pkg-cmake: provide our own platform description In-Reply-To: <19fbcec2-68a4-a287-a20f-522c94ede5e7@mind.be> References: <20170301091731.5102e061@free-electrons.com> <19fbcec2-68a4-a287-a20f-522c94ede5e7@mind.be> Message-ID: <20170301184343.GB3578@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Arnout, All, On 2017-03-01 09:35 +0100, Arnout Vandecappelle spake thusly: > On 01-03-17 09:17, Thomas Petazzoni wrote: > > Hello, > > > > On Wed, 1 Mar 2017 08:58:31 +0100, Arnout Vandecappelle wrote: > > > >> Since you don't do any processing on the file, you could just use > >> > >> -DCMAKE_MODULE_PATH="$$(TOPDIR)/support/misc" \ > > > > I think the idea is that since the Buildroot.cmake platform files gets > > referenced by the toolchainfile.cmake, then Buildroot.cmake anyway > > needs to be installed in $(HOST_DIR)/usr/share/buildroot, so we can > > just as well point CMake to this place. > > > >> and avoid copying the file around. Of course, in that case, support/cmake is > >> probably a better place to put the file :-) > > > > No: copying the file is needed, otherwise our toolchainfile.cmake file > > no longer works for people using it outside of Buildroot. > > Good point. I still think it should be in staging rather than host, but for > sure it's more important to keep them together. Why would you want it in staging? When we build our own internal cmake, the moduels it installs are so installed in host, not staging. They are build-description files, not target files. Ergo, they should be in host, not staging. Regards, Yann E. MORIN. > Therefore: > > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) > > Regards, > Arnout > > -- > Arnout Vandecappelle arnout at mind be > Senior Embedded Software Architect +32-16-286500 > Essensium/Mind http://www.mind.be > G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven > LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle > GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'