Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

From: Daniel Vetter <daniel@ffwll.ch>
To: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Cc: Markus Heiser <markus.heiser@darmarit.de>,
	Jonathan Corbet <corbet@lwn.net>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-doc@vger.kernel.org,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Mauro Carvalho Chehab <mchehab@s-opensource.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images
Date: Thu, 2 Mar 2017 08:12:59 +0100	[thread overview]
Message-ID: <20170302071259.puoqarzmh7spcden@phenom.ffwll.local> (raw)
In-Reply-To: <87k289xa6j.fsf@dilma.collabora.co.uk>

On Wed, Mar 01, 2017 at 12:56:36PM -0300, Gabriel Krisman Bertazi wrote:
> Daniel Vetter <daniel.vetter@ffwll.ch> writes:
> 
> Hi Daniel,
> 
> > +    if dst_fname:
> > +        name = dst_fname[len(out_dir) + 1:]
> > +        # the builder needs not to copy one more time, so pop it if exists.
> > +        translator.builder.images.pop(img_node['uri'], None)
> > +        img_node['uri'] = dst_fname
> > +        img_node['candidates'] = {'*': dst_fname}
> > +
> > +        mkdir(path.dirname(dst_fname))
> > +
> > +        if in_ext == '.dot':
> > +            verbose('convert DOT to: {out}/' + name)
> > +            dot2format(src_fname, dst_fname)
> > +
> > +        elif in_ext == '.svg':
> > +            verbose('convert SVG to: {out}/' + name)
> > +            svg2pdf(src_fname, dst_fname)
> 
> Small nit, but, shouldn't you add dst_fname to img_node only if
> dot2format or svg2pdf was successful?

I kinda assumed they're always successful, since the media documentation
build already requires them.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel