From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> To: Peter Huewe <peterhuewe@gmx.de> Cc: Arnd Bergmann <arnd@arndb.de>, Marcel Selhorst <tpmdd@selhorst.net>, Jason Gunthorpe <jgunthorpe@obsidianresearch.com>, Stefan Berger <stefanb@linux.vnet.ibm.com>, Christophe Ricard <christophe.ricard@gmail.com>, Nayna Jain <nayna@linux.vnet.ibm.com>, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm: select CONFIG_CRYPTO Date: Thu, 2 Mar 2017 11:17:04 +0200 [thread overview] Message-ID: <20170302091704.wuxhmhqrj7xe4e2j@intel.com> (raw) In-Reply-To: <A83F6A3E-1BE9-48C9-8FB8-B3C061402061@gmx.de> On Tue, Feb 28, 2017 at 10:24:45PM +0100, Peter Huewe wrote: > > > Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann <arnd@arndb.de>: > >We get a newly introduced harmless warning when CONFIG_CRYPTO is > >disabled: > > > >warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO > >which has unmet direct dependencies (CRYPTO) > > > >This adds another select to avoid the warning, consistent with other > >users > >of the crypto code. > > > >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support > >multiple banks") > >Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Lgtm > > Reviewed-by: Peter Huewe <peterhuewe@gmx.de> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko > >--- > > drivers/char/tpm/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig > >index af985cca413c..d520ac51c11c 100644 > >--- a/drivers/char/tpm/Kconfig > >+++ b/drivers/char/tpm/Kconfig > >@@ -6,6 +6,7 @@ menuconfig TCG_TPM > > tristate "TPM Hardware Support" > > depends on HAS_IOMEM > > select SECURITYFS > >+ select CRYPTO > > select CRYPTO_HASH_INFO > > ---help--- > > If you have a TPM security chip in your system, which > > -- > Sent from my mobile
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> To: Peter Huewe <peterhuewe-Mmb7MZpHnFY@public.gmane.org> Cc: Christophe Ricard <christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Subject: Re: [PATCH] tpm: select CONFIG_CRYPTO Date: Thu, 2 Mar 2017 11:17:04 +0200 [thread overview] Message-ID: <20170302091704.wuxhmhqrj7xe4e2j@intel.com> (raw) In-Reply-To: <A83F6A3E-1BE9-48C9-8FB8-B3C061402061-Mmb7MZpHnFY@public.gmane.org> On Tue, Feb 28, 2017 at 10:24:45PM +0100, Peter Huewe wrote: > > > Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>: > >We get a newly introduced harmless warning when CONFIG_CRYPTO is > >disabled: > > > >warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO > >which has unmet direct dependencies (CRYPTO) > > > >This adds another select to avoid the warning, consistent with other > >users > >of the crypto code. > > > >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support > >multiple banks") > >Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> > Lgtm > > Reviewed-by: Peter Huewe <peterhuewe-Mmb7MZpHnFY@public.gmane.org> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> /Jarkko > >--- > > drivers/char/tpm/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig > >index af985cca413c..d520ac51c11c 100644 > >--- a/drivers/char/tpm/Kconfig > >+++ b/drivers/char/tpm/Kconfig > >@@ -6,6 +6,7 @@ menuconfig TCG_TPM > > tristate "TPM Hardware Support" > > depends on HAS_IOMEM > > select SECURITYFS > >+ select CRYPTO > > select CRYPTO_HASH_INFO > > ---help--- > > If you have a TPM security chip in your system, which > > -- > Sent from my mobile ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2017-03-02 9:17 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-28 21:12 [PATCH] tpm: select CONFIG_CRYPTO Arnd Bergmann 2017-02-28 21:24 ` Peter Huewe 2017-02-28 21:24 ` Peter Huewe 2017-03-02 9:17 ` Jarkko Sakkinen [this message] 2017-03-02 9:17 ` Jarkko Sakkinen 2017-03-14 21:40 Arnd Bergmann 2017-03-14 21:40 ` Arnd Bergmann 2017-03-15 8:30 ` Jarkko Sakkinen 2017-03-15 11:39 ` Arnd Bergmann 2017-03-15 11:39 ` Arnd Bergmann 2017-03-15 17:58 ` Jarkko Sakkinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170302091704.wuxhmhqrj7xe4e2j@intel.com \ --to=jarkko.sakkinen@linux.intel.com \ --cc=arnd@arndb.de \ --cc=christophe.ricard@gmail.com \ --cc=jgunthorpe@obsidianresearch.com \ --cc=linux-kernel@vger.kernel.org \ --cc=nayna@linux.vnet.ibm.com \ --cc=peterhuewe@gmx.de \ --cc=stefanb@linux.vnet.ibm.com \ --cc=tpmdd-devel@lists.sourceforge.net \ --cc=tpmdd@selhorst.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.