All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tpm: select CONFIG_CRYPTO
@ 2017-02-28 21:12 Arnd Bergmann
  2017-02-28 21:24   ` Peter Huewe
  0 siblings, 1 reply; 11+ messages in thread
From: Arnd Bergmann @ 2017-02-28 21:12 UTC (permalink / raw)
  To: Peter Huewe, Marcel Selhorst, Jarkko Sakkinen
  Cc: Arnd Bergmann, Jason Gunthorpe, Stefan Berger, Christophe Ricard,
	Nayna Jain, tpmdd-devel, linux-kernel

We get a newly introduced harmless warning when CONFIG_CRYPTO is disabled:

warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)

This adds another select to avoid the warning, consistent with other users
of the crypto code.

Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/tpm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index af985cca413c..d520ac51c11c 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -6,6 +6,7 @@ menuconfig TCG_TPM
 	tristate "TPM Hardware Support"
 	depends on HAS_IOMEM
 	select SECURITYFS
+	select CRYPTO
 	select CRYPTO_HASH_INFO
 	---help---
 	  If you have a TPM security chip in your system, which
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PATCH] tpm: select CONFIG_CRYPTO
@ 2017-02-28 21:24   ` Peter Huewe
  0 siblings, 0 replies; 11+ messages in thread
From: Peter Huewe @ 2017-02-28 21:24 UTC (permalink / raw)
  To: Arnd Bergmann, Marcel Selhorst, Jarkko Sakkinen
  Cc: Jason Gunthorpe, Stefan Berger, Christophe Ricard, Nayna Jain,
	tpmdd-devel, linux-kernel



Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann <arnd@arndb.de>:
>We get a newly introduced harmless warning when CONFIG_CRYPTO is
>disabled:
>
>warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO
>which has unmet direct dependencies (CRYPTO)
>
>This adds another select to avoid the warning, consistent with other
>users
>of the crypto code.
>
>Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support
>multiple banks")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Lgtm

Reviewed-by: Peter Huewe <peterhuewe@gmx.de>
>---
> drivers/char/tpm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
>index af985cca413c..d520ac51c11c 100644
>--- a/drivers/char/tpm/Kconfig
>+++ b/drivers/char/tpm/Kconfig
>@@ -6,6 +6,7 @@ menuconfig TCG_TPM
> 	tristate "TPM Hardware Support"
> 	depends on HAS_IOMEM
> 	select SECURITYFS
>+	select CRYPTO
> 	select CRYPTO_HASH_INFO
> 	---help---
> 	  If you have a TPM security chip in your system, which

-- 
Sent from my mobile

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] tpm: select CONFIG_CRYPTO
@ 2017-02-28 21:24   ` Peter Huewe
  0 siblings, 0 replies; 11+ messages in thread
From: Peter Huewe @ 2017-02-28 21:24 UTC (permalink / raw)
  To: Arnd Bergmann, Marcel Selhorst, Jarkko Sakkinen
  Cc: Christophe Ricard, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f



Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>:
>We get a newly introduced harmless warning when CONFIG_CRYPTO is
>disabled:
>
>warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO
>which has unmet direct dependencies (CRYPTO)
>
>This adds another select to avoid the warning, consistent with other
>users
>of the crypto code.
>
>Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support
>multiple banks")
>Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Lgtm

Reviewed-by: Peter Huewe <peterhuewe-Mmb7MZpHnFY@public.gmane.org>
>---
> drivers/char/tpm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
>index af985cca413c..d520ac51c11c 100644
>--- a/drivers/char/tpm/Kconfig
>+++ b/drivers/char/tpm/Kconfig
>@@ -6,6 +6,7 @@ menuconfig TCG_TPM
> 	tristate "TPM Hardware Support"
> 	depends on HAS_IOMEM
> 	select SECURITYFS
>+	select CRYPTO
> 	select CRYPTO_HASH_INFO
> 	---help---
> 	  If you have a TPM security chip in your system, which

-- 
Sent from my mobile

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] tpm: select CONFIG_CRYPTO
@ 2017-03-02  9:17     ` Jarkko Sakkinen
  0 siblings, 0 replies; 11+ messages in thread
From: Jarkko Sakkinen @ 2017-03-02  9:17 UTC (permalink / raw)
  To: Peter Huewe
  Cc: Arnd Bergmann, Marcel Selhorst, Jason Gunthorpe, Stefan Berger,
	Christophe Ricard, Nayna Jain, tpmdd-devel, linux-kernel

On Tue, Feb 28, 2017 at 10:24:45PM +0100, Peter Huewe wrote:
> 
> 
> Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann <arnd@arndb.de>:
> >We get a newly introduced harmless warning when CONFIG_CRYPTO is
> >disabled:
> >
> >warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO
> >which has unmet direct dependencies (CRYPTO)
> >
> >This adds another select to avoid the warning, consistent with other
> >users
> >of the crypto code.
> >
> >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support
> >multiple banks")
> >Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Lgtm
> 
> Reviewed-by: Peter Huewe <peterhuewe@gmx.de>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

> >---
> > drivers/char/tpm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> >index af985cca413c..d520ac51c11c 100644
> >--- a/drivers/char/tpm/Kconfig
> >+++ b/drivers/char/tpm/Kconfig
> >@@ -6,6 +6,7 @@ menuconfig TCG_TPM
> > 	tristate "TPM Hardware Support"
> > 	depends on HAS_IOMEM
> > 	select SECURITYFS
> >+	select CRYPTO
> > 	select CRYPTO_HASH_INFO
> > 	---help---
> > 	  If you have a TPM security chip in your system, which
> 
> -- 
> Sent from my mobile

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] tpm: select CONFIG_CRYPTO
@ 2017-03-02  9:17     ` Jarkko Sakkinen
  0 siblings, 0 replies; 11+ messages in thread
From: Jarkko Sakkinen @ 2017-03-02  9:17 UTC (permalink / raw)
  To: Peter Huewe
  Cc: Christophe Ricard, Arnd Bergmann,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

On Tue, Feb 28, 2017 at 10:24:45PM +0100, Peter Huewe wrote:
> 
> 
> Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>:
> >We get a newly introduced harmless warning when CONFIG_CRYPTO is
> >disabled:
> >
> >warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO
> >which has unmet direct dependencies (CRYPTO)
> >
> >This adds another select to avoid the warning, consistent with other
> >users
> >of the crypto code.
> >
> >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support
> >multiple banks")
> >Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> Lgtm
> 
> Reviewed-by: Peter Huewe <peterhuewe-Mmb7MZpHnFY@public.gmane.org>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

/Jarkko

> >---
> > drivers/char/tpm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> >index af985cca413c..d520ac51c11c 100644
> >--- a/drivers/char/tpm/Kconfig
> >+++ b/drivers/char/tpm/Kconfig
> >@@ -6,6 +6,7 @@ menuconfig TCG_TPM
> > 	tristate "TPM Hardware Support"
> > 	depends on HAS_IOMEM
> > 	select SECURITYFS
> >+	select CRYPTO
> > 	select CRYPTO_HASH_INFO
> > 	---help---
> > 	  If you have a TPM security chip in your system, which
> 
> -- 
> Sent from my mobile

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] tpm: select CONFIG_CRYPTO
  2017-03-15 11:39     ` Arnd Bergmann
  (?)
@ 2017-03-15 17:58     ` Jarkko Sakkinen
  -1 siblings, 0 replies; 11+ messages in thread
From: Jarkko Sakkinen @ 2017-03-15 17:58 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Peter Huewe, Marcel Selhorst, Jason Gunthorpe, Stefan Berger,
	Christophe Ricard, Nayna Jain, tpmdd-devel,
	Linux Kernel Mailing List

On Wed, Mar 15, 2017 at 12:39:16PM +0100, Arnd Bergmann wrote:
> On Wed, Mar 15, 2017 at 9:30 AM, Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> > Arnd,
> >
> > On Tue, Mar 14, 2017 at 10:40:24PM +0100, Arnd Bergmann wrote:
> >> As we need the CRYPTO_HASH_INFO implementation, we should also
> >> select CRYPTO itself to avoid this build warning:
> >>
> >> warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)
> >>
> >> Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > I've already merged this and put to my next branch.
> 
> Ah, I see my mistake: I had made an identical patch earlier, which you merged
> into linux-next, and I dropped it from my series after rebasing on
> -next, but then
> rebased again on mainline and did the new patch without checking whether
> it was already fixed in -next.
> 
> I guess the warning is rare enough that we don't really need this in v4.11
> even though it does apply there.
> 
>     Arnd

Ah. Right, now that I remember that was my conclusion. I'm sorry that
I did not remember to respond :-) If you think this would make sense
for 4.11 I could send it to stable.

/Jarkko

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] tpm: select CONFIG_CRYPTO
@ 2017-03-15 11:39     ` Arnd Bergmann
  0 siblings, 0 replies; 11+ messages in thread
From: Arnd Bergmann @ 2017-03-15 11:39 UTC (permalink / raw)
  To: Jarkko Sakkinen
  Cc: Peter Huewe, Marcel Selhorst, Jason Gunthorpe, Stefan Berger,
	Christophe Ricard, Nayna Jain, tpmdd-devel,
	Linux Kernel Mailing List

On Wed, Mar 15, 2017 at 9:30 AM, Jarkko Sakkinen
<jarkko.sakkinen@linux.intel.com> wrote:
> Arnd,
>
> On Tue, Mar 14, 2017 at 10:40:24PM +0100, Arnd Bergmann wrote:
>> As we need the CRYPTO_HASH_INFO implementation, we should also
>> select CRYPTO itself to avoid this build warning:
>>
>> warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)
>>
>> Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I've already merged this and put to my next branch.

Ah, I see my mistake: I had made an identical patch earlier, which you merged
into linux-next, and I dropped it from my series after rebasing on
-next, but then
rebased again on mainline and did the new patch without checking whether
it was already fixed in -next.

I guess the warning is rare enough that we don't really need this in v4.11
even though it does apply there.

    Arnd

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] tpm: select CONFIG_CRYPTO
@ 2017-03-15 11:39     ` Arnd Bergmann
  0 siblings, 0 replies; 11+ messages in thread
From: Arnd Bergmann @ 2017-03-15 11:39 UTC (permalink / raw)
  To: Jarkko Sakkinen
  Cc: Christophe Ricard, Linux Kernel Mailing List,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

On Wed, Mar 15, 2017 at 9:30 AM, Jarkko Sakkinen
<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote:
> Arnd,
>
> On Tue, Mar 14, 2017 at 10:40:24PM +0100, Arnd Bergmann wrote:
>> As we need the CRYPTO_HASH_INFO implementation, we should also
>> select CRYPTO itself to avoid this build warning:
>>
>> warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)
>>
>> Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")
>> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
>
> I've already merged this and put to my next branch.

Ah, I see my mistake: I had made an identical patch earlier, which you merged
into linux-next, and I dropped it from my series after rebasing on
-next, but then
rebased again on mainline and did the new patch without checking whether
it was already fixed in -next.

I guess the warning is rare enough that we don't really need this in v4.11
even though it does apply there.

    Arnd

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] tpm: select CONFIG_CRYPTO
  2017-03-14 21:40 ` Arnd Bergmann
  (?)
@ 2017-03-15  8:30 ` Jarkko Sakkinen
  2017-03-15 11:39     ` Arnd Bergmann
  -1 siblings, 1 reply; 11+ messages in thread
From: Jarkko Sakkinen @ 2017-03-15  8:30 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Peter Huewe, Marcel Selhorst, Jason Gunthorpe, Stefan Berger,
	Christophe Ricard, Nayna Jain, tpmdd-devel, linux-kernel

Arnd,

On Tue, Mar 14, 2017 at 10:40:24PM +0100, Arnd Bergmann wrote:
> As we need the CRYPTO_HASH_INFO implementation, we should also
> select CRYPTO itself to avoid this build warning:
> 
> warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)
> 
> Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I've already merged this and put to my next branch.

/Jarkko

> ---
>  drivers/char/tpm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index af985cca413c..d520ac51c11c 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -6,6 +6,7 @@ menuconfig TCG_TPM
>  	tristate "TPM Hardware Support"
>  	depends on HAS_IOMEM
>  	select SECURITYFS
> +	select CRYPTO
>  	select CRYPTO_HASH_INFO
>  	---help---
>  	  If you have a TPM security chip in your system, which
> -- 
> 2.9.0
> 

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH] tpm: select CONFIG_CRYPTO
@ 2017-03-14 21:40 ` Arnd Bergmann
  0 siblings, 0 replies; 11+ messages in thread
From: Arnd Bergmann @ 2017-03-14 21:40 UTC (permalink / raw)
  To: Peter Huewe, Marcel Selhorst, Jarkko Sakkinen
  Cc: Arnd Bergmann, Jason Gunthorpe, Stefan Berger, Christophe Ricard,
	Nayna Jain, tpmdd-devel, linux-kernel

As we need the CRYPTO_HASH_INFO implementation, we should also
select CRYPTO itself to avoid this build warning:

warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)

Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/char/tpm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index af985cca413c..d520ac51c11c 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -6,6 +6,7 @@ menuconfig TCG_TPM
 	tristate "TPM Hardware Support"
 	depends on HAS_IOMEM
 	select SECURITYFS
+	select CRYPTO
 	select CRYPTO_HASH_INFO
 	---help---
 	  If you have a TPM security chip in your system, which
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [PATCH] tpm: select CONFIG_CRYPTO
@ 2017-03-14 21:40 ` Arnd Bergmann
  0 siblings, 0 replies; 11+ messages in thread
From: Arnd Bergmann @ 2017-03-14 21:40 UTC (permalink / raw)
  To: Peter Huewe, Marcel Selhorst, Jarkko Sakkinen
  Cc: Christophe Ricard, Arnd Bergmann,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

As we need the CRYPTO_HASH_INFO implementation, we should also
select CRYPTO itself to avoid this build warning:

warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO which has unmet direct dependencies (CRYPTO)

Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support multiple banks")
Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
---
 drivers/char/tpm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index af985cca413c..d520ac51c11c 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -6,6 +6,7 @@ menuconfig TCG_TPM
 	tristate "TPM Hardware Support"
 	depends on HAS_IOMEM
 	select SECURITYFS
+	select CRYPTO
 	select CRYPTO_HASH_INFO
 	---help---
 	  If you have a TPM security chip in your system, which
-- 
2.9.0


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-03-15 17:58 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-28 21:12 [PATCH] tpm: select CONFIG_CRYPTO Arnd Bergmann
2017-02-28 21:24 ` Peter Huewe
2017-02-28 21:24   ` Peter Huewe
2017-03-02  9:17   ` Jarkko Sakkinen
2017-03-02  9:17     ` Jarkko Sakkinen
2017-03-14 21:40 Arnd Bergmann
2017-03-14 21:40 ` Arnd Bergmann
2017-03-15  8:30 ` Jarkko Sakkinen
2017-03-15 11:39   ` Arnd Bergmann
2017-03-15 11:39     ` Arnd Bergmann
2017-03-15 17:58     ` Jarkko Sakkinen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.