From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754508AbdCBJRg (ORCPT ); Thu, 2 Mar 2017 04:17:36 -0500 Received: from mga05.intel.com ([192.55.52.43]:21574 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754466AbdCBJRJ (ORCPT ); Thu, 2 Mar 2017 04:17:09 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,230,1484035200"; d="scan'208";a="231391694" Date: Thu, 2 Mar 2017 11:17:04 +0200 From: Jarkko Sakkinen To: Peter Huewe Cc: Arnd Bergmann , Marcel Selhorst , Jason Gunthorpe , Stefan Berger , Christophe Ricard , Nayna Jain , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm: select CONFIG_CRYPTO Message-ID: <20170302091704.wuxhmhqrj7xe4e2j@intel.com> References: <20170228211326.3667625-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 28, 2017 at 10:24:45PM +0100, Peter Huewe wrote: > > > Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann : > >We get a newly introduced harmless warning when CONFIG_CRYPTO is > >disabled: > > > >warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO > >which has unmet direct dependencies (CRYPTO) > > > >This adds another select to avoid the warning, consistent with other > >users > >of the crypto code. > > > >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support > >multiple banks") > >Signed-off-by: Arnd Bergmann > Lgtm > > Reviewed-by: Peter Huewe Reviewed-by: Jarkko Sakkinen /Jarkko > >--- > > drivers/char/tpm/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig > >index af985cca413c..d520ac51c11c 100644 > >--- a/drivers/char/tpm/Kconfig > >+++ b/drivers/char/tpm/Kconfig > >@@ -6,6 +6,7 @@ menuconfig TCG_TPM > > tristate "TPM Hardware Support" > > depends on HAS_IOMEM > > select SECURITYFS > >+ select CRYPTO > > select CRYPTO_HASH_INFO > > ---help--- > > If you have a TPM security chip in your system, which > > -- > Sent from my mobile From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH] tpm: select CONFIG_CRYPTO Date: Thu, 2 Mar 2017 11:17:04 +0200 Message-ID: <20170302091704.wuxhmhqrj7xe4e2j@intel.com> References: <20170228211326.3667625-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Peter Huewe Cc: Christophe Ricard , Arnd Bergmann , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Feb 28, 2017 at 10:24:45PM +0100, Peter Huewe wrote: > > > Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann : > >We get a newly introduced harmless warning when CONFIG_CRYPTO is > >disabled: > > > >warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO > >which has unmet direct dependencies (CRYPTO) > > > >This adds another select to avoid the warning, consistent with other > >users > >of the crypto code. > > > >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support > >multiple banks") > >Signed-off-by: Arnd Bergmann > Lgtm > > Reviewed-by: Peter Huewe Reviewed-by: Jarkko Sakkinen /Jarkko > >--- > > drivers/char/tpm/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig > >index af985cca413c..d520ac51c11c 100644 > >--- a/drivers/char/tpm/Kconfig > >+++ b/drivers/char/tpm/Kconfig > >@@ -6,6 +6,7 @@ menuconfig TCG_TPM > > tristate "TPM Hardware Support" > > depends on HAS_IOMEM > > select SECURITYFS > >+ select CRYPTO > > select CRYPTO_HASH_INFO > > ---help--- > > If you have a TPM security chip in your system, which > > -- > Sent from my mobile ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot