From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device Date: Thu, 2 Mar 2017 17:39:37 +0000 Message-ID: <20170302173936.GC11970@leverpostej> References: <148846752022.2349.13667498174822419498.stgit@brijesh-build-machine> <148846777589.2349.11698765767451886038.stgit@brijesh-build-machine> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: simon.guinot@sequanux.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, rkrcmar@redhat.com, matt@codeblueprint.co.uk, linux-pci@vger.kernel.org, linus.walleij@linaro.org, gary.hook@amd.com, linux-mm@kvack.org, paul.gortmaker@windriver.com, hpa@zytor.com, cl@linux.com, dan.j.williams@intel.com, aarcange@redhat.com, sfr@canb.auug.org.au, andriy.shevchenko@linux.intel.com, herbert@gondor.apana.org.au, bhe@redhat.com, xemul@parallels.com, joro@8bytes.org, x86@kernel.org, peterz@infradead.org, piotr.luc@intel.com, mingo@redhat.com, msalter@redhat.com, ross.zwisler@linux.intel.com, bp@suse.de, dyoung@redhat.com, thomas.lendacky@amd.com, jroedel@suse.de, keescook@chromium.org, arnd@arndb.de, toshi.kani@hpe.com, mathieu.desnoyers@efficios.com, luto@kernel.org, devel@linuxdriverproject.o To: Brijesh Singh Return-path: Received: from foss.arm.com ([217.140.101.70]:34332 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752605AbdCBRnp (ORCPT ); Thu, 2 Mar 2017 12:43:45 -0500 Content-Disposition: inline In-Reply-To: <148846777589.2349.11698765767451886038.stgit@brijesh-build-machine> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, Mar 02, 2017 at 10:16:15AM -0500, Brijesh Singh wrote: > The CCP device is part of the AMD Secure Processor. In order to expand the > usage of the AMD Secure Processor, create a framework that allows functional > components of the AMD Secure Processor to be initialized and handled > appropriately. > > Signed-off-by: Brijesh Singh > Signed-off-by: Tom Lendacky > --- > drivers/crypto/Kconfig | 10 + > drivers/crypto/ccp/Kconfig | 43 +++-- > drivers/crypto/ccp/Makefile | 8 - > drivers/crypto/ccp/ccp-dev-v3.c | 86 +++++----- > drivers/crypto/ccp/ccp-dev-v5.c | 73 ++++----- > drivers/crypto/ccp/ccp-dev.c | 137 +++++++++------- > drivers/crypto/ccp/ccp-dev.h | 35 ---- > drivers/crypto/ccp/sp-dev.c | 308 ++++++++++++++++++++++++++++++++++++ > drivers/crypto/ccp/sp-dev.h | 140 ++++++++++++++++ > drivers/crypto/ccp/sp-pci.c | 324 ++++++++++++++++++++++++++++++++++++++ > drivers/crypto/ccp/sp-platform.c | 268 +++++++++++++++++++++++++++++++ > include/linux/ccp.h | 3 > 12 files changed, 1240 insertions(+), 195 deletions(-) > create mode 100644 drivers/crypto/ccp/sp-dev.c > create mode 100644 drivers/crypto/ccp/sp-dev.h > create mode 100644 drivers/crypto/ccp/sp-pci.c > create mode 100644 drivers/crypto/ccp/sp-platform.c > diff --git a/drivers/crypto/ccp/Makefile b/drivers/crypto/ccp/Makefile > index 346ceb8..8127e18 100644 > --- a/drivers/crypto/ccp/Makefile > +++ b/drivers/crypto/ccp/Makefile > @@ -1,11 +1,11 @@ > -obj-$(CONFIG_CRYPTO_DEV_CCP_DD) += ccp.o > -ccp-objs := ccp-dev.o \ > +obj-$(CONFIG_CRYPTO_DEV_SP_DD) += ccp.o > +ccp-objs := sp-dev.o sp-platform.o > +ccp-$(CONFIG_PCI) += sp-pci.o > +ccp-$(CONFIG_CRYPTO_DEV_CCP) += ccp-dev.o \ > ccp-ops.o \ > ccp-dev-v3.o \ > ccp-dev-v5.o \ > - ccp-platform.o \ > ccp-dmaengine.o It looks like ccp-platform.c has morphed into sp-platform.c (judging by the compatible string and general shape of the code), and the original ccp-platform.c is no longer built. Shouldn't ccp-platform.c be deleted by this patch? Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753542AbdCBRns (ORCPT ); Thu, 2 Mar 2017 12:43:48 -0500 Received: from foss.arm.com ([217.140.101.70]:34332 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752605AbdCBRnp (ORCPT ); Thu, 2 Mar 2017 12:43:45 -0500 Date: Thu, 2 Mar 2017 17:39:37 +0000 From: Mark Rutland To: Brijesh Singh Cc: simon.guinot@sequanux.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, rkrcmar@redhat.com, matt@codeblueprint.co.uk, linux-pci@vger.kernel.org, linus.walleij@linaro.org, gary.hook@amd.com, linux-mm@kvack.org, paul.gortmaker@windriver.com, hpa@zytor.com, cl@linux.com, dan.j.williams@intel.com, aarcange@redhat.com, sfr@canb.auug.org.au, andriy.shevchenko@linux.intel.com, herbert@gondor.apana.org.au, bhe@redhat.com, xemul@parallels.com, joro@8bytes.org, x86@kernel.org, peterz@infradead.org, piotr.luc@intel.com, mingo@redhat.com, msalter@redhat.com, ross.zwisler@linux.intel.com, bp@suse.de, dyoung@redhat.com, thomas.lendacky@amd.com, jroedel@suse.de, keescook@chromium.org, arnd@arndb.de, toshi.kani@hpe.com, mathieu.desnoyers@efficios.com, luto@kernel.org, devel@linuxdriverproject.org, bhelgaas@google.com, tglx@linutronix.de, mchehab@kernel.org, iamjoonsoo.kim@lge.com, labbott@fedoraproject.org, tony.luck@intel.com, alexandre.bounine@idt.com, kuleshovmail@gmail.com, linux-kernel@vger.kernel.org, mcgrof@kernel.org, mst@redhat.com, linux-crypto@vger.kernel.org, tj@kernel.org, pbonzini@redhat.com, akpm@linux-foundation.org, davem@davemloft.net Subject: Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device Message-ID: <20170302173936.GC11970@leverpostej> References: <148846752022.2349.13667498174822419498.stgit@brijesh-build-machine> <148846777589.2349.11698765767451886038.stgit@brijesh-build-machine> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <148846777589.2349.11698765767451886038.stgit@brijesh-build-machine> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 02, 2017 at 10:16:15AM -0500, Brijesh Singh wrote: > The CCP device is part of the AMD Secure Processor. In order to expand the > usage of the AMD Secure Processor, create a framework that allows functional > components of the AMD Secure Processor to be initialized and handled > appropriately. > > Signed-off-by: Brijesh Singh > Signed-off-by: Tom Lendacky > --- > drivers/crypto/Kconfig | 10 + > drivers/crypto/ccp/Kconfig | 43 +++-- > drivers/crypto/ccp/Makefile | 8 - > drivers/crypto/ccp/ccp-dev-v3.c | 86 +++++----- > drivers/crypto/ccp/ccp-dev-v5.c | 73 ++++----- > drivers/crypto/ccp/ccp-dev.c | 137 +++++++++------- > drivers/crypto/ccp/ccp-dev.h | 35 ---- > drivers/crypto/ccp/sp-dev.c | 308 ++++++++++++++++++++++++++++++++++++ > drivers/crypto/ccp/sp-dev.h | 140 ++++++++++++++++ > drivers/crypto/ccp/sp-pci.c | 324 ++++++++++++++++++++++++++++++++++++++ > drivers/crypto/ccp/sp-platform.c | 268 +++++++++++++++++++++++++++++++ > include/linux/ccp.h | 3 > 12 files changed, 1240 insertions(+), 195 deletions(-) > create mode 100644 drivers/crypto/ccp/sp-dev.c > create mode 100644 drivers/crypto/ccp/sp-dev.h > create mode 100644 drivers/crypto/ccp/sp-pci.c > create mode 100644 drivers/crypto/ccp/sp-platform.c > diff --git a/drivers/crypto/ccp/Makefile b/drivers/crypto/ccp/Makefile > index 346ceb8..8127e18 100644 > --- a/drivers/crypto/ccp/Makefile > +++ b/drivers/crypto/ccp/Makefile > @@ -1,11 +1,11 @@ > -obj-$(CONFIG_CRYPTO_DEV_CCP_DD) += ccp.o > -ccp-objs := ccp-dev.o \ > +obj-$(CONFIG_CRYPTO_DEV_SP_DD) += ccp.o > +ccp-objs := sp-dev.o sp-platform.o > +ccp-$(CONFIG_PCI) += sp-pci.o > +ccp-$(CONFIG_CRYPTO_DEV_CCP) += ccp-dev.o \ > ccp-ops.o \ > ccp-dev-v3.o \ > ccp-dev-v5.o \ > - ccp-platform.o \ > ccp-dmaengine.o It looks like ccp-platform.c has morphed into sp-platform.c (judging by the compatible string and general shape of the code), and the original ccp-platform.c is no longer built. Shouldn't ccp-platform.c be deleted by this patch? Thanks, Mark.