From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751506AbdCCB45 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Mar 2017 20:56:57 -0500
Received: from mail.kernel.org ([198.145.29.136]:34280 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751083AbdCCB4z (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Mar 2017 20:56:55 -0500
Date: Thu, 2 Mar 2017 19:38:27 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Todd Brandt <todd.e.brandt@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, todd.e.brandt@intel.com
Subject: Re: [PATCH] ftrace: add ftrace_graph_max_depth kernel parameter
Message-ID: <20170302193827.6f5ee2eb@gandalf.local.home>
In-Reply-To: <1488499935-23216-1-git-send-email-todd.e.brandt@linux.intel.com>
References: <1488499935-23216-1-git-send-email-todd.e.brandt@linux.intel.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu,  2 Mar 2017 16:12:15 -0800
Todd Brandt <todd.e.brandt@linux.intel.com> wrote:

> Early trace callgraphs can be extremely large on systems with
> several seconds of boot time. The max_depth parameter limits how
> deep the graph trace goes and reduces the output size. This
> parameter is the same as the max_graph_depth file in debugfs.

I'll take this with one modification I'll make. s/debugfs/tracefs/
because it's really the tracefs file system now. It just happens to be
automatically mounted in the debugfs file system. But can be by itself
in /sys/kernel/tracing/

-- Steve

> 
> Signed-off-by: Todd Brandt <todd.e.brandt@linux.intel.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 6 ++++++
>  kernel/trace/ftrace.c                           | 9 +++++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 986e443..1a8575f 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1183,6 +1183,12 @@
>  			functions that can be changed at run time by the
>  			set_graph_notrace file in the debugfs tracing directory.
>  
> +	ftrace_graph_max_depth=<uint>
> +			[FTRACE] Used with the function graph tracer. This is
> +			the max depth it will trace into a function. This value
> +			can be changed at run time by the max_graph_depth file
> +			in the debugfs tracing directory. default: 0 (no limit)
> +
>  	gamecon.map[2|3]=
>  			[HW,JOY] Multisystem joystick and NES/SNES/PSX pad
>  			support via parallel port (up to 5 devices per port)
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 0c06093..fc6b024 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -4415,6 +4415,15 @@ static int __init set_graph_notrace_function(char *str)
>  }
>  __setup("ftrace_graph_notrace=", set_graph_notrace_function);
>  
> +static int __init set_graph_max_depth_function(char *str)
> +{
> +	if (!str)
> +		return 0;
> +	fgraph_max_depth = simple_strtoul(str, NULL, 0);
> +	return 1;
> +}
> +__setup("ftrace_graph_max_depth=", set_graph_max_depth_function);
> +
>  static void __init set_ftrace_early_graph(char *buf, int enable)
>  {
>  	int ret;