From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751558AbdCCAkv (ORCPT ); Thu, 2 Mar 2017 19:40:51 -0500 Received: from mail.kernel.org ([198.145.29.136]:56090 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbdCCAkr (ORCPT ); Thu, 2 Mar 2017 19:40:47 -0500 Date: Thu, 2 Mar 2017 19:39:43 -0500 From: Steven Rostedt To: Todd Brandt Cc: linux-kernel@vger.kernel.org, todd.e.brandt@intel.com Subject: Re: [PATCH] ftrace: add ftrace_graph_max_depth kernel parameter Message-ID: <20170302193943.3117fca7@gandalf.local.home> In-Reply-To: <20170302193827.6f5ee2eb@gandalf.local.home> References: <1488499935-23216-1-git-send-email-todd.e.brandt@linux.intel.com> <20170302193827.6f5ee2eb@gandalf.local.home> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Mar 2017 19:38:27 -0500 Steven Rostedt wrote: > On Thu, 2 Mar 2017 16:12:15 -0800 > Todd Brandt wrote: > > > Early trace callgraphs can be extremely large on systems with > > several seconds of boot time. The max_depth parameter limits how > > deep the graph trace goes and reduces the output size. This > > parameter is the same as the max_graph_depth file in debugfs. > > I'll take this with one modification I'll make. s/debugfs/tracefs/ > because it's really the tracefs file system now. It just happens to be > automatically mounted in the debugfs file system. But can be by itself > in /sys/kernel/tracing/ > > -- Steve > > > > > Signed-off-by: Todd Brandt > > --- > > Documentation/admin-guide/kernel-parameters.txt | 6 ++++++ > > kernel/trace/ftrace.c | 9 +++++++++ > > 2 files changed, 15 insertions(+) > > > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > > index 986e443..1a8575f 100644 > > --- a/Documentation/admin-guide/kernel-parameters.txt > > +++ b/Documentation/admin-guide/kernel-parameters.txt > > @@ -1183,6 +1183,12 @@ > > functions that can be changed at run time by the > > set_graph_notrace file in the debugfs tracing directory. I need to make a patch to update the old documentation to reflect this as well. But I'll do that another time. -- Steve