All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
	sre@kernel.org, pali.rohar@gmail.com,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	mchehab@kernel.org, ivo.g.dimitrov.75@gmail.com
Subject: Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)
Date: Thu, 2 Mar 2017 22:03:52 +0100	[thread overview]
Message-ID: <20170302210352.GA15572@amd> (raw)
In-Reply-To: <2358884.6crJRnJuOY@avalon>

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

Hi!

> > >  static int isp_fwnode_parse(struct device *dev, struct fwnode_handle
> > >  *fwn,
> > >  
> > >  			    struct isp_async_subdev *isd)
> > >  
> > >  {
> > > 
> > > -	struct isp_bus_cfg *buscfg = &isd->bus;
> > > +	struct isp_bus_cfg *buscfg;
> > > 
> > >  	struct v4l2_fwnode_endpoint vfwn;
> > >  	unsigned int i;
> > >  	int ret;
> > >  	bool csi1 = false;
> > > 
> > > +	buscfg = devm_kzalloc(dev, sizeof(*isd->bus), GFP_KERNEL);
> 
> Given that you recently get rid of devm_kzalloc() in the driver, let's not 
> introduce a new one here.

What is wrong with devm_kzalloc()?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2017-03-02 21:27 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 22:38 [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times Pavel Machek
2017-02-14 22:38 ` [PATCH 2/4] Core changes for CCP2/CSI1 support Pavel Machek
2017-02-14 22:39 ` [PATCH 3/4] smiapp: add CCP2 support Pavel Machek
2017-02-14 22:39 ` [PATCH 4/4] v4l: split lane parsing code Pavel Machek
2017-02-20 10:31 ` [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times Pavel Machek
2017-02-20 13:09   ` Sakari Ailus
2017-02-20 13:56     ` Sakari Ailus
2017-02-21 11:07       ` Pavel Machek
2017-02-21 11:11         ` Sakari Ailus
2017-02-23 22:52           ` Pavel Machek
2017-02-25  0:09           ` Pavel Machek
2017-02-25 13:44             ` Sakari Ailus
2017-02-25 21:53               ` camera subdevice support was " Pavel Machek
2017-02-25 22:56                 ` Pavel Machek
2017-02-25 23:17                 ` Sakari Ailus
2017-02-26  8:38                   ` Pavel Machek
2017-02-26 21:36                     ` Sakari Ailus
2017-03-04  8:55                   ` Pavel Machek
2017-03-04 12:30                     ` Sakari Ailus
2017-03-04 19:05                       ` Pavel Machek
2017-03-04 19:20                       ` Pavel Machek
2017-03-02  9:07               ` subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times) Pavel Machek
2017-03-02 14:16                 ` Sakari Ailus
2017-03-02 14:58                   ` Pavel Machek
2017-03-02 15:13                     ` Sakari Ailus
2017-03-03 23:24                       ` Pavel Machek
2017-03-02 18:39                   ` Laurent Pinchart
2017-03-02 21:03                     ` Pavel Machek [this message]
2017-03-02 21:18                     ` Sakari Ailus
2017-02-25 22:12           ` [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times Pavel Machek
2017-02-27 19:43             ` Pavel Machek
2017-02-27 20:54             ` Sakari Ailus
2017-02-28  9:17               ` Pavel Machek
2017-02-28 11:38               ` [PATCH] omap3isp: Parse CSI1 configuration from the device tree Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170302210352.GA15572@amd \
    --to=pavel@ucw.cz \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=sakari.ailus@iki.fi \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.