From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjYZk-0000D2-Im for qemu-devel@nongnu.org; Thu, 02 Mar 2017 16:47:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjYZj-0005mj-3m for qemu-devel@nongnu.org; Thu, 02 Mar 2017 16:47:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57638) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cjYZi-0005lV-RW for qemu-devel@nongnu.org; Thu, 02 Mar 2017 16:47:51 -0500 Date: Thu, 2 Mar 2017 23:47:46 +0200 From: "Michael S. Tsirkin" Message-ID: <20170302214746.GA4711@redhat.com> References: <1488479153-21203-1-git-send-email-felipe@nutanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488479153-21203-1-git-send-email-felipe@nutanix.com> Subject: Re: [Qemu-devel] [PATCH v5 0/4] Introduce vhost-user-scsi and sample application List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Felipe Franciosi Cc: Paolo Bonzini , Stefan Hajnoczi , Marc-Andre Lureau , "qemu-devel@nongnu.org" , "Daniel P. Berrange" On Thu, Mar 02, 2017 at 10:25:49AM -0800, Felipe Franciosi wrote: > Based on various discussions on the 2016 KVM Forum, I'm sending over a > vhost-user-scsi implementation for your consideration. > > This patchset introduces a new vhost-user SCSI device. While heavily > based on vhost-scsi, it is implemented using vhost's userspace > counterpart. The device has been coded and tested to work with live > migration. > > As part of this work, a new vhost-scsi-common device was created and > the existing vhost-scsi device moved underneath it. The new > vhost-user-scsi device is also placed underneath it. > > A sample application based on the newly introduced libvhost-user is > also included. It makes use of libiscsi for simplicity. > > For convenience, I'm maintaining an up-to-date version of these > patches (including some necessary fixes for libvhost-user) on: > > https://github.com/franciozzy/qemu/tree/vus-upstream-v5 > > See the individual patches for build and use instructions. > > Signed-off-by: Felipe Franciosi BTW, pls remember to ping after QEMU release. > v4 -> v5: > - Add a patch to fix a build issue with libvhost-user. > > v3 -> v4: > - Drop configure switches and build vus by default. > - Add sample application to .gitignore. > - Removed a whitespace error. > - Rebase on master. > > v2 -> v3: > - Rebase after vhost notifier fixes by Paolo. > - Exposed F_HOTPLUG and F_CHANGE on vhost-user-scsi. > > v1 -> v2: > - Introduce new vhost-scsi-common device type. > - Move vhost-scsi device underneath vhost-scsi-common. > - Move sample application from tests/ to contrib/. > - Make sample application use the glib event loop. > - Minor fixes. > > Felipe Franciosi (4): > libvhost-user: replace vasprintf() to fix build > vhost-scsi: create a vhost-scsi-common abstraction > vus: Introduce vhost-user-scsi host device > vus: Introduce a vhost-user-scsi sample application > > .gitignore | 1 + > Makefile | 3 + > Makefile.objs | 4 + > configure | 1 + > contrib/libvhost-user/libvhost-user.c | 2 +- > contrib/vhost-user-scsi/Makefile.objs | 1 + > contrib/vhost-user-scsi/vhost-user-scsi.c | 886 ++++++++++++++++++++++++++++++ > default-configs/pci.mak | 1 + > hw/scsi/Makefile.objs | 3 +- > hw/scsi/vhost-scsi-common.c | 143 +++++ > hw/scsi/vhost-scsi.c | 194 ++----- > hw/scsi/vhost-user-scsi.c | 215 ++++++++ > hw/virtio/virtio-pci.c | 54 ++ > hw/virtio/virtio-pci.h | 11 + > include/hw/virtio/vhost-scsi-common.h | 48 ++ > include/hw/virtio/vhost-scsi.h | 11 +- > include/hw/virtio/vhost-user-scsi.h | 35 ++ > include/hw/virtio/virtio-scsi.h | 5 + > 18 files changed, 1469 insertions(+), 149 deletions(-) > create mode 100644 contrib/vhost-user-scsi/Makefile.objs > create mode 100644 contrib/vhost-user-scsi/vhost-user-scsi.c > create mode 100644 hw/scsi/vhost-scsi-common.c > create mode 100644 hw/scsi/vhost-user-scsi.c > create mode 100644 include/hw/virtio/vhost-scsi-common.h > create mode 100644 include/hw/virtio/vhost-user-scsi.h > > -- > 1.9.4