All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH xf86-video-amdgpu 4/9] present: Also flush before using a flip to unflip
Date: Fri,  3 Mar 2017 18:07:40 +0900	[thread overview]
Message-ID: <20170303090745.2254-4-michel@daenzer.net> (raw)
In-Reply-To: <20170303090745.2254-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org>

From: Michel Dänzer <michel.daenzer@amd.com>

Not doing so might result in intermittently scanning out stale contents
of the screen pixmap.

(Ported from radeon commit 9a951a3e551db58ba50e7a594521ceac54d90615)

Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
 src/amdgpu_present.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/amdgpu_present.c b/src/amdgpu_present.c
index cf6e36b2f..4048f9844 100644
--- a/src/amdgpu_present.c
+++ b/src/amdgpu_present.c
@@ -366,6 +366,7 @@ amdgpu_present_unflip(ScreenPtr screen, uint64_t event_id)
 	event->event_id = event_id;
 	event->unflip = TRUE;
 
+	amdgpu_glamor_flush(scrn);
 	if (amdgpu_do_pageflip(scrn, AMDGPU_DRM_QUEUE_CLIENT_DEFAULT, pixmap,
 			       event_id, event, -1, amdgpu_present_flip_event,
 			       amdgpu_present_flip_abort, FLIP_VSYNC, 0))
-- 
2.11.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2017-03-03  9:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03  9:07 [PATCH xf86-video-amdgpu 1/9] Use drmmode_crtc_scanout_free in drmmode_fini Michel Dänzer
     [not found] ` <20170303090745.2254-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-03-03  9:07   ` [PATCH xf86-video-amdgpu 2/9] present: Only call drmModeRmFB after setting modes for unflip Michel Dänzer
2017-03-03  9:07   ` [PATCH xf86-video-amdgpu 3/9] present: Wait for GPU idle before " Michel Dänzer
2017-03-03  9:07   ` Michel Dänzer [this message]
2017-03-03  9:07   ` [PATCH xf86-video-amdgpu 5/9] present: Use async flip for unflip if possible Michel Dänzer
2017-03-03  9:07   ` [PATCH xf86-video-amdgpu 6/9] present: Flush before flipping Michel Dänzer
2017-03-03  9:07   ` [PATCH xf86-video-amdgpu 7/9] Call drmmode_set_desired_modes from a WindowExposures hook Michel Dänzer
     [not found]     ` <20170303090745.2254-7-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-03-06  1:47       ` [PATCH xf86-video-amdgpu v2 " Michel Dänzer
     [not found]         ` <20170306014759.9030-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-03-06 15:23           ` Alex Deucher
2017-03-03  9:07   ` [PATCH xf86-video-amdgpu 8/9] Move DPMS check from amdgpu_scanout_do_update to amdgpu_scanout_flip Michel Dänzer
2017-03-03  9:07   ` [PATCH xf86-video-amdgpu 9/9] Don't call amdgpu_glamor_flush in drmmode_copy_fb Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170303090745.2254-4-michel@daenzer.net \
    --to=michel-otuistvhuppr7s880joybq@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.