From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] ppp implemantation
Date: Fri, 3 Mar 2017 09:41:03 +0000
Message-ID: <20170303094103.GA189196@bricha3-MOBL3.ger.corp.intel.com>
References: <1488525977-15321-1-git-send-email-beilei.xing@intel.com>
 <1488525977-15321-3-git-send-email-beilei.xing@intel.com>
 <20170303093926.GB188460@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: jingjing.wu@intel.com, helin.zhang@intel.com, dev@dpdk.org
To: Beilei Xing <beilei.xing@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id E80AA3DC
 for <dev@dpdk.org>; Fri,  3 Mar 2017 10:41:07 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20170303093926.GB188460@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Mar 03, 2017 at 09:39:26AM +0000, Bruce Richardson wrote:
> Given that this patch is not about point-to-point protocol, i.e. the
> best-known expansion of "PPP", I think you need to clarify the acronym
> in the commit message, at minimum, if not also in the commit title.
> 
> /Bruce
> 

Never mind, I see your updated patchset has already been sent with
better titles.

/Bruce
> On Fri, Mar 03, 2017 at 03:26:07PM +0800, Beilei Xing wrote:
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > ---
> >  app/test-pmd/cmdline.c                  |  57 ++++++++
> >  app/test-pmd/config.c                   |  62 +++++++++
> >  app/test-pmd/testpmd.h                  |   3 +
> >  drivers/net/i40e/base/i40e_adminq_cmd.h |  32 +++++
> >  drivers/net/i40e/base/i40e_common.c     | 236 +++++++++++++++++++++++++++++++-
> >  drivers/net/i40e/base/i40e_prototype.h  |  17 +++
> >  drivers/net/i40e/base/i40e_type.h       |  79 +++++++++++
> >  drivers/net/i40e/i40e_ethdev.c          |  68 +++++++++
> >  drivers/net/i40e/rte_pmd_i40e.h         |   1 +
> >  9 files changed, 554 insertions(+), 1 deletion(-)
> >