From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:40935 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752263AbdCCR3S (ORCPT ); Fri, 3 Mar 2017 12:29:18 -0500 From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: Andy Yan , Archit Taneja , Fabio Estevam , Jose Abreu , Kieran Bingham , Neil Armstrong , Nickey Yang , Russell King , Vladimir Zapolskiy , linux-renesas-soc@vger.kernel.org Subject: [PATCH v5 03/10] drm: bridge: dw-hdmi: Enable CSC even for DVI Date: Fri, 3 Mar 2017 19:20:00 +0200 Message-Id: <20170303172007.26541-4-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <20170303172007.26541-1-laurent.pinchart+renesas@ideasonboard.com> References: <20170303172007.26541-1-laurent.pinchart+renesas@ideasonboard.com> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: From: Neil Armstrong If the input pixel format is not RGB, the CSC must be enabled in order to provide valid pixel to DVI sinks. This patch removes the hdmi only dependency on the CSC enabling. Reviewed-by: Jose Abreu Reviewed-by: Laurent Pinchart Signed-off-by: Neil Armstrong Tested-by: Neil Armstrong --- drivers/gpu/drm/bridge/dw-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c index 906583beb08b..d863b3393aee 100644 --- a/drivers/gpu/drm/bridge/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/dw-hdmi.c @@ -1291,8 +1291,8 @@ static void dw_hdmi_enable_video_path(struct dw_hdmi *hdmi) hdmi_writeb(hdmi, clkdis, HDMI_MC_CLKDIS); } - /* Enable color space conversion if needed (for HDMI sinks only). */ - if (hdmi->sink_is_hdmi && is_color_space_conversion(hdmi)) + /* Enable color space conversion if needed */ + if (is_color_space_conversion(hdmi)) hdmi_writeb(hdmi, HDMI_MC_FLOWCTRL_FEED_THROUGH_OFF_CSC_IN_PATH, HDMI_MC_FLOWCTRL); else -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: [PATCH v5 03/10] drm: bridge: dw-hdmi: Enable CSC even for DVI Date: Fri, 3 Mar 2017 19:20:00 +0200 Message-ID: <20170303172007.26541-4-laurent.pinchart+renesas@ideasonboard.com> References: <20170303172007.26541-1-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id B9A8C6ED9F for ; Fri, 3 Mar 2017 17:19:39 +0000 (UTC) In-Reply-To: <20170303172007.26541-1-laurent.pinchart+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Fabio Estevam , Jose Abreu , Neil Armstrong , Kieran Bingham , linux-renesas-soc@vger.kernel.org, Nickey Yang , Russell King , Andy Yan , Vladimir Zapolskiy List-Id: dri-devel@lists.freedesktop.org RnJvbTogTmVpbCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdAYmF5bGlicmUuY29tPgoKSWYgdGhlIGlu cHV0IHBpeGVsIGZvcm1hdCBpcyBub3QgUkdCLCB0aGUgQ1NDIG11c3QgYmUgZW5hYmxlZCBpbiBv cmRlciB0bwpwcm92aWRlIHZhbGlkIHBpeGVsIHRvIERWSSBzaW5rcy4KVGhpcyBwYXRjaCByZW1v dmVzIHRoZSBoZG1pIG9ubHkgZGVwZW5kZW5jeSBvbiB0aGUgQ1NDIGVuYWJsaW5nLgoKUmV2aWV3 ZWQtYnk6IEpvc2UgQWJyZXUgPGpvYWJyZXVAc3lub3BzeXMuY29tPgpSZXZpZXdlZC1ieTogTGF1 cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgpTaWduZWQt b2ZmLWJ5OiBOZWlsIEFybXN0cm9uZyA8bmFybXN0cm9uZ0BiYXlsaWJyZS5jb20+ClRlc3RlZC1i eTogTmVpbCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdAYmF5bGlicmUuY29tPgotLS0KIGRyaXZlcnMv Z3B1L2RybS9icmlkZ2UvZHctaGRtaS5jIHwgNCArKy0tCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9i cmlkZ2UvZHctaGRtaS5jIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9kdy1oZG1pLmMKaW5kZXgg OTA2NTgzYmViMDhiLi5kODYzYjMzOTNhZWUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9i cmlkZ2UvZHctaGRtaS5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHctaGRtaS5jCkBA IC0xMjkxLDggKzEyOTEsOCBAQCBzdGF0aWMgdm9pZCBkd19oZG1pX2VuYWJsZV92aWRlb19wYXRo KHN0cnVjdCBkd19oZG1pICpoZG1pKQogCQloZG1pX3dyaXRlYihoZG1pLCBjbGtkaXMsIEhETUlf TUNfQ0xLRElTKTsKIAl9CiAKLQkvKiBFbmFibGUgY29sb3Igc3BhY2UgY29udmVyc2lvbiBpZiBu ZWVkZWQgKGZvciBIRE1JIHNpbmtzIG9ubHkpLiAqLwotCWlmIChoZG1pLT5zaW5rX2lzX2hkbWkg JiYgaXNfY29sb3Jfc3BhY2VfY29udmVyc2lvbihoZG1pKSkKKwkvKiBFbmFibGUgY29sb3Igc3Bh Y2UgY29udmVyc2lvbiBpZiBuZWVkZWQgKi8KKwlpZiAoaXNfY29sb3Jfc3BhY2VfY29udmVyc2lv bihoZG1pKSkKIAkJaGRtaV93cml0ZWIoaGRtaSwgSERNSV9NQ19GTE9XQ1RSTF9GRUVEX1RIUk9V R0hfT0ZGX0NTQ19JTl9QQVRILAogCQkJICAgIEhETUlfTUNfRkxPV0NUUkwpOwogCWVsc2UKLS0g ClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK