All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/5] support/testing: add core tests
Date: Sun, 5 Mar 2017 15:11:25 +0100	[thread overview]
Message-ID: <20170305151125.13a32242@free-electrons.com> (raw)
In-Reply-To: <58b779b582a46_1c373ff16a8e2ec09216c@ultri3.mail>

Hello,

On Wed, 01 Mar 2017 22:47:33 -0300, Ricardo Martincoski wrote:
> Thomas,
> 
> On Tue, Feb 07, 2017 at 09:36 AM, Thomas Petazzoni wrote:
> 
> [snip]
> > +++ b/support/testing/tests/core/test_post_scripts.py  
> [snip]
> > +    # TODO  
> 
> This comment can be removed. The method is already implemented.

Indeed.

> > +        emulator.login("root")  
> 
> Shouldn't it be like this?
>         emulator.login()

Correct. I did the mistake in a number of places. I guess the fact that
I chose "root" as the root password for the Dropbear test confused me
into thinking that the argument was the user name, and not the
password. So I've also changed the root password of the Dropbear test
case to be "testpwd" instead.

I've fixed all instances of emulator.login("root") that should have
been emulator.login().

While doing this, I also noticed that the emulator.login() method did
not ensure we reached the shell prompt. So I've changed it to make sure
we reached the prompt, and if not, abort.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-03-05 14:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 11:35 [Buildroot] [PATCH 0/5] Runtime testing infrastructure Thomas Petazzoni
2017-02-07 11:35 ` [Buildroot] [PATCH 1/5] support/testing: core " Thomas Petazzoni
2017-02-08  9:50   ` Thomas De Schampheleire
2017-02-08 10:05     ` Thomas Petazzoni
2017-02-08 11:42       ` Thomas De Schampheleire
2017-03-04 18:12         ` Luca Ceresoli
2017-03-05  7:27           ` Thomas De Schampheleire
2017-03-05  8:29           ` Thomas Petazzoni
2017-03-07 21:59             ` Luca Ceresoli
2017-03-07 22:09               ` Thomas Petazzoni
2017-03-07 23:10                 ` Luca Ceresoli
2017-03-08  1:48                   ` Ricardo Martincoski
2017-03-02  1:46   ` Ricardo Martincoski
2017-03-05 14:09     ` Thomas Petazzoni
2017-03-04 23:26   ` Luca Ceresoli
2017-03-05 14:44     ` Thomas Petazzoni
2017-02-07 11:36 ` [Buildroot] [PATCH 2/5] support/testing: add core tests Thomas Petazzoni
2017-03-02  1:47   ` Ricardo Martincoski
2017-03-05 14:11     ` Thomas Petazzoni [this message]
2017-02-07 11:36 ` [Buildroot] [PATCH 3/5] support/testing: add fs tests Thomas Petazzoni
2017-03-02  1:51   ` Ricardo Martincoski
2017-03-05 14:13     ` Thomas Petazzoni
2017-02-07 11:36 ` [Buildroot] [PATCH 4/5] support/testing: add package tests Thomas Petazzoni
2017-03-02  1:53   ` Ricardo Martincoski
2017-03-05 14:14     ` Thomas Petazzoni
2017-02-07 11:36 ` [Buildroot] [PATCH 5/5] support/testing: add toolchain tests Thomas Petazzoni
2017-03-02  1:54   ` Ricardo Martincoski
2017-03-02  1:45 ` [Buildroot] [PATCH 0/5] Runtime testing infrastructure Ricardo Martincoski
2017-03-05 14:08   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170305151125.13a32242@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.