From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:39717 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754071AbdCFJob (ORCPT ); Mon, 6 Mar 2017 04:44:31 -0500 From: Jiri Slaby To: stable@vger.kernel.org Cc: Theodore Ts'o , Jiri Slaby Subject: [patch added to 3.12-stable] ext4: fix fencepost in s_first_meta_bg validation Date: Mon, 6 Mar 2017 10:09:14 +0100 Message-Id: <20170306090936.30522-2-jslaby@suse.cz> In-Reply-To: <20170306090936.30522-1-jslaby@suse.cz> References: <20170306090936.30522-1-jslaby@suse.cz> Sender: stable-owner@vger.kernel.org List-ID: From: Theodore Ts'o This patch has been added to the 3.12 stable tree. If you have any objections, please let us know. =============== commit 2ba3e6e8afc9b6188b471f27cf2b5e3cf34e7af2 upstream. It is OK for s_first_meta_bg to be equal to the number of block group descriptor blocks. (It rarely happens, but it shouldn't cause any problems.) https://bugzilla.kernel.org/show_bug.cgi?id=194567 Fixes: 3a4b77cd47bb837b8557595ec7425f281f2ca1fe Signed-off-by: Theodore Ts'o Signed-off-by: Jiri Slaby --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index a263fa90edfa..7bc05f7bb2a7 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3853,7 +3853,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) db_count = (sbi->s_groups_count + EXT4_DESC_PER_BLOCK(sb) - 1) / EXT4_DESC_PER_BLOCK(sb); if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_META_BG)) { - if (le32_to_cpu(es->s_first_meta_bg) >= db_count) { + if (le32_to_cpu(es->s_first_meta_bg) > db_count) { ext4_msg(sb, KERN_WARNING, "first meta block group too large: %u " "(group descriptor block count %u)", -- 2.12.0