From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753998AbdCFOS1 (ORCPT ); Mon, 6 Mar 2017 09:18:27 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33888 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932229AbdCFOSB (ORCPT ); Mon, 6 Mar 2017 09:18:01 -0500 Date: Mon, 6 Mar 2017 17:17:46 +0300 From: "Kirill A. Shutemov" To: Dmitry Safonov <0x7f454c46@gmail.com> Cc: Andy Lutomirski , "Kirill A. Shutemov" , Dmitry Safonov , Linus Torvalds , Andrew Morton , X86 ML , Thomas Gleixner , Ingo Molnar , Arnd Bergmann , "H. Peter Anvin" , Andi Kleen , Dave Hansen , linux-arch , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Catalin Marinas , Linux API Subject: Re: [PATCHv3 33/33] mm, x86: introduce PR_SET_MAX_VADDR and PR_GET_MAX_VADDR Message-ID: <20170306141746.GA27719@node.shutemov.name> References: <20170217141328.164563-1-kirill.shutemov@linux.intel.com> <20170217141328.164563-34-kirill.shutemov@linux.intel.com> <20170221124217.GB13174@node.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 06, 2017 at 05:00:28PM +0300, Dmitry Safonov wrote: > 2017-02-21 15:42 GMT+03:00 Kirill A. Shutemov : > > On Tue, Feb 21, 2017 at 02:54:20PM +0300, Dmitry Safonov wrote: > >> 2017-02-17 19:50 GMT+03:00 Andy Lutomirski : > >> > On Fri, Feb 17, 2017 at 6:13 AM, Kirill A. Shutemov > >> > wrote: > >> >> This patch introduces two new prctl(2) handles to manage maximum virtual > >> >> address available to userspace to map. > >> ... > >> > Anyway, can you and Dmitry try to reconcile your patches? > >> > >> So, how can I help that? > >> Is there the patch's version, on which I could rebase? > >> Here are BTW the last patches, which I will resend with trivial ifdef-fixup > >> after the merge window: > >> http://marc.info/?i=20170214183621.2537-1-dsafonov%20()%20virtuozzo%20!%20com > > > > Could you check if this patch collides with anything you do: > > > > http://lkml.kernel.org/r/20170220131515.GA9502@node.shutemov.name > > Ok, sorry for the late reply - it was the merge window anyway and I've got > urgent work to do. > > Let's see: > > I'll need minor merge fixup here: > >-#define TASK_UNMAPPED_BASE (PAGE_ALIGN(TASK_SIZE / 3)) > >+#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 3)) > while in my patches: > >+#define __TASK_UNMAPPED_BASE(task_size) (PAGE_ALIGN(task_size / 3)) > >+#define TASK_UNMAPPED_BASE __TASK_UNMAPPED_BASE(TASK_SIZE) > > This should be just fine with my changes: > >- info.high_limit = end; > >+ info.high_limit = min(end, DEFAULT_MAP_WINDOW); > > This will need another minor fixup: > >-#define MAX_GAP (TASK_SIZE/6*5) > >+#define MAX_GAP (DEFAULT_MAP_WINDOW/6*5) > I've moved it from macro to mmap_base() as local var, > which depends on task_size parameter. > > That's all, as far as I can see at this moment. > Does not seems hard to fix. So I suggest sending patches sets > in parallel, the second accepted will rebase the set. > Is it convenient for you? Works for me. In fact, I've just sent v4 of the patchset. -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: [PATCHv3 33/33] mm, x86: introduce PR_SET_MAX_VADDR and PR_GET_MAX_VADDR Date: Mon, 6 Mar 2017 17:17:46 +0300 Message-ID: <20170306141746.GA27719@node.shutemov.name> References: <20170217141328.164563-1-kirill.shutemov@linux.intel.com> <20170217141328.164563-34-kirill.shutemov@linux.intel.com> <20170221124217.GB13174@node.shutemov.name> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: Dmitry Safonov <0x7f454c46@gmail.com> Cc: Andy Lutomirski , "Kirill A. Shutemov" , Dmitry Safonov , Linus Torvalds , Andrew Morton , X86 ML , Thomas Gleixner , Ingo Molnar , Arnd Bergmann , "H. Peter Anvin" , Andi Kleen , Dave Hansen , linux-arch , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Catalin Marinas , Linux API List-Id: linux-api@vger.kernel.org On Mon, Mar 06, 2017 at 05:00:28PM +0300, Dmitry Safonov wrote: > 2017-02-21 15:42 GMT+03:00 Kirill A. Shutemov : > > On Tue, Feb 21, 2017 at 02:54:20PM +0300, Dmitry Safonov wrote: > >> 2017-02-17 19:50 GMT+03:00 Andy Lutomirski : > >> > On Fri, Feb 17, 2017 at 6:13 AM, Kirill A. Shutemov > >> > wrote: > >> >> This patch introduces two new prctl(2) handles to manage maximum virtual > >> >> address available to userspace to map. > >> ... > >> > Anyway, can you and Dmitry try to reconcile your patches? > >> > >> So, how can I help that? > >> Is there the patch's version, on which I could rebase? > >> Here are BTW the last patches, which I will resend with trivial ifdef-fixup > >> after the merge window: > >> http://marc.info/?i=20170214183621.2537-1-dsafonov%20()%20virtuozzo%20!%20com > > > > Could you check if this patch collides with anything you do: > > > > http://lkml.kernel.org/r/20170220131515.GA9502@node.shutemov.name > > Ok, sorry for the late reply - it was the merge window anyway and I've got > urgent work to do. > > Let's see: > > I'll need minor merge fixup here: > >-#define TASK_UNMAPPED_BASE (PAGE_ALIGN(TASK_SIZE / 3)) > >+#define TASK_UNMAPPED_BASE (PAGE_ALIGN(DEFAULT_MAP_WINDOW / 3)) > while in my patches: > >+#define __TASK_UNMAPPED_BASE(task_size) (PAGE_ALIGN(task_size / 3)) > >+#define TASK_UNMAPPED_BASE __TASK_UNMAPPED_BASE(TASK_SIZE) > > This should be just fine with my changes: > >- info.high_limit = end; > >+ info.high_limit = min(end, DEFAULT_MAP_WINDOW); > > This will need another minor fixup: > >-#define MAX_GAP (TASK_SIZE/6*5) > >+#define MAX_GAP (DEFAULT_MAP_WINDOW/6*5) > I've moved it from macro to mmap_base() as local var, > which depends on task_size parameter. > > That's all, as far as I can see at this moment. > Does not seems hard to fix. So I suggest sending patches sets > in parallel, the second accepted will rebase the set. > Is it convenient for you? Works for me. In fact, I've just sent v4 of the patchset. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org