From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756701AbdCHDYi (ORCPT ); Tue, 7 Mar 2017 22:24:38 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:41258 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756523AbdCHDYh (ORCPT ); Tue, 7 Mar 2017 22:24:37 -0500 Date: Tue, 07 Mar 2017 13:59:28 -0800 (PST) Message-Id: <20170307.135928.594434139062899205.davem@davemloft.net> To: dhowells@redhat.com Cc: netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] rxrpc: Call state should be read with READ_ONCE() under some circumstances From: David Miller In-Reply-To: <148858570121.7759.13967054786116725339.stgit@warthog.procyon.org.uk> References: <148858570121.7759.13967054786116725339.stgit@warthog.procyon.org.uk> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 07 Mar 2017 13:59:29 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Howells Date: Sat, 04 Mar 2017 00:01:41 +0000 > The call state may be changed at any time by the data-ready routine in > response to received packets, so if the call state is to be read and acted > upon several times in a function, READ_ONCE() must be used unless the call > state lock is held. > > Signed-off-by: David Howells Applied.